root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Prefer local hostAddress in ReactorServerHttpRequest 

Closes gh-28601
This commit is contained in:
rstoyanchev 2023-02-15 10:26:49 +00:00
parent 569df6eecc
commit 5847454aa4
2 changed files with 18 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
spring-web/src/main/java/org/springframework/http/server/reactive/ReactorNetty2ServerHttpRequest.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2022 the original author or authors. * Copyright 2002-2023 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -80,6 +80,12 @@ class ReactorNetty2ServerHttpRequest extends AbstractServerHttpRequest {
private static URI resolveBaseUrl(HttpServerRequest request) throws URISyntaxException { private static URI resolveBaseUrl(HttpServerRequest request) throws URISyntaxException {
String scheme = getScheme(request); String scheme = getScheme(request);
InetSocketAddress hostAddress = request.hostAddress();
if (hostAddress != null) {
return new URI(scheme, null, hostAddress.getHostString(), hostAddress.getPort(), null, null, null);
}
CharSequence charSequence = request.requestHeaders().get(HttpHeaderNames.HOST); CharSequence charSequence = request.requestHeaders().get(HttpHeaderNames.HOST);
if (charSequence != null) { if (charSequence != null) {
String header = charSequence.toString(); String header = charSequence.toString();
@ -103,12 +109,8 @@ class ReactorNetty2ServerHttpRequest extends AbstractServerHttpRequest {
return new URI(scheme, header, null, null); return new URI(scheme, header, null, null);
} }
} }
else {
InetSocketAddress localAddress = request.hostAddress(); throw new IllegalStateException("Neither local hostAddress nor HOST header available");
Assert.state(localAddress != null, "No host address available");
return new URI(scheme, null, localAddress.getHostString(),
localAddress.getPort(), null, null, null);
}
} }
private static String getScheme(HttpServerRequest request) { private static String getScheme(HttpServerRequest request) {

16
spring-web/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2022 the original author or authors. * Copyright 2002-2023 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -79,6 +79,12 @@ class ReactorServerHttpRequest extends AbstractServerHttpRequest {
private static URI resolveBaseUrl(HttpServerRequest request) throws URISyntaxException { private static URI resolveBaseUrl(HttpServerRequest request) throws URISyntaxException {
String scheme = getScheme(request); String scheme = getScheme(request);
InetSocketAddress hostAddress = request.hostAddress();
if (hostAddress != null) {
return new URI(scheme, null, hostAddress.getHostString(), hostAddress.getPort(), null, null, null);
}
String header = request.requestHeaders().get(HttpHeaderNames.HOST); String header = request.requestHeaders().get(HttpHeaderNames.HOST);
if (header != null) { if (header != null) {
final int portIndex; final int portIndex;
@ -101,12 +107,8 @@ class ReactorServerHttpRequest extends AbstractServerHttpRequest {
return new URI(scheme, header, null, null); return new URI(scheme, header, null, null);
} }
} }
else {
InetSocketAddress localAddress = request.hostAddress(); throw new IllegalStateException("Neither local hostAddress nor HOST header available");
Assert.state(localAddress != null, "No host address available");
return new URI(scheme, null, localAddress.getHostString(),
localAddress.getPort(), null, null, null);
}
} }
private static String getScheme(HttpServerRequest request) { private static String getScheme(HttpServerRequest request) {