root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

refined logging in JMS SingleConnectionFactory and DefaultMessageListenerContainer

This commit is contained in:
Juergen Hoeller 2009-08-26 12:01:51 +00:00
parent 5c2d63745f
commit 5a55b8384a
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
org.springframework.jms/src/main/java/org/springframework/jms/connection/SingleConnectionFactory.java
View File

@ -234,7 +234,7 @@ public class SingleConnectionFactory
} }
public QueueConnection createQueueConnection() throws JMSException { public QueueConnection createQueueConnection() throws JMSException {
Connection con = null; Connection con;
synchronized (this.connectionMonitor) { synchronized (this.connectionMonitor) {
this.pubSubMode = Boolean.FALSE; this.pubSubMode = Boolean.FALSE;
con = createConnection(); con = createConnection();
@ -252,7 +252,7 @@ public class SingleConnectionFactory
} }
public TopicConnection createTopicConnection() throws JMSException { public TopicConnection createTopicConnection() throws JMSException {
Connection con = null; Connection con;
synchronized (this.connectionMonitor) { synchronized (this.connectionMonitor) {
this.pubSubMode = Boolean.TRUE; this.pubSubMode = Boolean.TRUE;
con = createConnection(); con = createConnection();
@ -298,6 +298,7 @@ public class SingleConnectionFactory
* Exception listener callback that renews the underlying single Connection. * Exception listener callback that renews the underlying single Connection.
*/ */
public void onException(JMSException ex) { public void onException(JMSException ex) {
logger.warn("Encountered a JMSException - resetting the underlying JMS Connection", ex);
resetConnection(); resetConnection();
} }

10
org.springframework.jms/src/main/java/org/springframework/jms/listener/DefaultMessageListenerContainer.java
View File

@ -738,10 +738,10 @@ public class DefaultMessageListenerContainer extends AbstractPollingMessageListe
msg.append(getDestinationDescription()).append("' - trying to recover. Cause: "); msg.append(getDestinationDescription()).append("' - trying to recover. Cause: ");
msg.append(ex instanceof JMSException ? JmsUtils.buildExceptionMessage((JMSException) ex) : ex.getMessage()); msg.append(ex instanceof JMSException ? JmsUtils.buildExceptionMessage((JMSException) ex) : ex.getMessage());
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.info(msg, ex); logger.warn(msg, ex);
} }
else { else {
logger.info(msg); logger.warn(msg);
} }
} }
} }
@ -792,10 +792,10 @@ public class DefaultMessageListenerContainer extends AbstractPollingMessageListe
msg.append(this.recoveryInterval).append(" ms. Cause: "); msg.append(this.recoveryInterval).append(" ms. Cause: ");
msg.append(ex instanceof JMSException ? JmsUtils.buildExceptionMessage((JMSException) ex) : ex.getMessage()); msg.append(ex instanceof JMSException ? JmsUtils.buildExceptionMessage((JMSException) ex) : ex.getMessage());
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.info(msg, ex); logger.warn(msg, ex);
} }
else if (logger.isInfoEnabled()) { else {
logger.info(msg); logger.warn(msg);
} }
} }
sleepInbetweenRecoveryAttempts(); sleepInbetweenRecoveryAttempts();