Extend nested placeholders resolution to any CharSequence

See gh-32876
This commit is contained in:
Yanming Zhou 2024-05-23 09:48:05 +08:00 committed by Stéphane Nicoll
parent 181b68088a
commit 5a7bfa9dec
2 changed files with 42 additions and 3 deletions

View File

@ -1,5 +1,5 @@
/*
* Copyright 2002-2022 the original author or authors.
* Copyright 2002-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@ -24,6 +24,7 @@ import org.springframework.lang.Nullable;
*
* @author Chris Beams
* @author Juergen Hoeller
* @author Yanming Zhou
* @since 3.1
* @see PropertySource
* @see PropertySources
@ -84,8 +85,8 @@ public class PropertySourcesPropertyResolver extends AbstractPropertyResolver {
}
Object value = propertySource.getProperty(key);
if (value != null) {
if (resolveNestedPlaceholders && value instanceof String string) {
value = resolveNestedPlaceholders(string);
if (resolveNestedPlaceholders && value instanceof CharSequence cs) {
value = resolveNestedPlaceholders(cs.toString());
}
logKeyFound(key, propertySource, value);
return convertValueIfNecessary(value, targetValueType);

View File

@ -34,6 +34,7 @@ import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
/**
* @author Chris Beams
* @author Yanming Zhou
* @since 3.1
*/
class PropertySourcesPropertyResolverTests {
@ -300,6 +301,43 @@ class PropertySourcesPropertyResolverTests {
.withMessageContaining("Circular");
}
@Test
void resolveNestedPlaceholdersIfValueIsCharSequence() {
MutablePropertySources ps = new MutablePropertySources();
ps.addFirst(new MockPropertySource()
.withProperty("p1", "v1")
.withProperty("p2", "v2")
.withProperty("p3", new CharSequence() {
static final String underlying = "${p1}:${p2}";
@Override
public int length() {
return underlying.length();
}
@Override
public char charAt(int index) {
return underlying.charAt(index);
}
@Override
public CharSequence subSequence(int start, int end) {
return underlying.subSequence(start, end);
}
@Override
public String toString() {
return underlying;
}
})
);
ConfigurablePropertyResolver pr = new PropertySourcesPropertyResolver(ps);
assertThat(pr.getProperty("p1")).isEqualTo("v1");
assertThat(pr.getProperty("p2")).isEqualTo("v2");
assertThat(pr.getProperty("p3")).isEqualTo("v1:v2");
}
@Test
void ignoreUnresolvableNestedPlaceholdersIsConfigurable() {
MutablePropertySources ps = new MutablePropertySources();