Extend nested placeholders resolution to any CharSequence
See gh-32876
This commit is contained in:
parent
181b68088a
commit
5a7bfa9dec
|
|
@ -1,5 +1,5 @@
|
||||||
/*
|
/*
|
||||||
* Copyright 2002-2022 the original author or authors.
|
* Copyright 2002-2024 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
|
@ -24,6 +24,7 @@ import org.springframework.lang.Nullable;
|
||||||
*
|
*
|
||||||
* @author Chris Beams
|
* @author Chris Beams
|
||||||
* @author Juergen Hoeller
|
* @author Juergen Hoeller
|
||||||
|
* @author Yanming Zhou
|
||||||
* @since 3.1
|
* @since 3.1
|
||||||
* @see PropertySource
|
* @see PropertySource
|
||||||
* @see PropertySources
|
* @see PropertySources
|
||||||
|
|
@ -84,8 +85,8 @@ public class PropertySourcesPropertyResolver extends AbstractPropertyResolver {
|
||||||
}
|
}
|
||||||
Object value = propertySource.getProperty(key);
|
Object value = propertySource.getProperty(key);
|
||||||
if (value != null) {
|
if (value != null) {
|
||||||
if (resolveNestedPlaceholders && value instanceof String string) {
|
if (resolveNestedPlaceholders && value instanceof CharSequence cs) {
|
||||||
value = resolveNestedPlaceholders(string);
|
value = resolveNestedPlaceholders(cs.toString());
|
||||||
}
|
}
|
||||||
logKeyFound(key, propertySource, value);
|
logKeyFound(key, propertySource, value);
|
||||||
return convertValueIfNecessary(value, targetValueType);
|
return convertValueIfNecessary(value, targetValueType);
|
||||||
|
|
|
||||||
|
|
@ -34,6 +34,7 @@ import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @author Chris Beams
|
* @author Chris Beams
|
||||||
|
* @author Yanming Zhou
|
||||||
* @since 3.1
|
* @since 3.1
|
||||||
*/
|
*/
|
||||||
class PropertySourcesPropertyResolverTests {
|
class PropertySourcesPropertyResolverTests {
|
||||||
|
|
@ -300,6 +301,43 @@ class PropertySourcesPropertyResolverTests {
|
||||||
.withMessageContaining("Circular");
|
.withMessageContaining("Circular");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
void resolveNestedPlaceholdersIfValueIsCharSequence() {
|
||||||
|
MutablePropertySources ps = new MutablePropertySources();
|
||||||
|
ps.addFirst(new MockPropertySource()
|
||||||
|
.withProperty("p1", "v1")
|
||||||
|
.withProperty("p2", "v2")
|
||||||
|
.withProperty("p3", new CharSequence() {
|
||||||
|
|
||||||
|
static final String underlying = "${p1}:${p2}";
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public int length() {
|
||||||
|
return underlying.length();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public char charAt(int index) {
|
||||||
|
return underlying.charAt(index);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public CharSequence subSequence(int start, int end) {
|
||||||
|
return underlying.subSequence(start, end);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public String toString() {
|
||||||
|
return underlying;
|
||||||
|
}
|
||||||
|
})
|
||||||
|
);
|
||||||
|
ConfigurablePropertyResolver pr = new PropertySourcesPropertyResolver(ps);
|
||||||
|
assertThat(pr.getProperty("p1")).isEqualTo("v1");
|
||||||
|
assertThat(pr.getProperty("p2")).isEqualTo("v2");
|
||||||
|
assertThat(pr.getProperty("p3")).isEqualTo("v1:v2");
|
||||||
|
}
|
||||||
|
|
||||||
@Test
|
@Test
|
||||||
void ignoreUnresolvableNestedPlaceholdersIsConfigurable() {
|
void ignoreUnresolvableNestedPlaceholdersIsConfigurable() {
|
||||||
MutablePropertySources ps = new MutablePropertySources();
|
MutablePropertySources ps = new MutablePropertySources();
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue