GenericTypeAwarePropertyDescriptor implements equals/hashCode for proper lookups on IBM JVM 6

Issue: SPR-12185

spring-beans/src/main/java/org/springframework/beans/ExtendedBeanInfo.java

@@ -30,15 +30,12 @@ import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
-import java.util.Enumeration;
 import java.util.List;
 import java.util.Set;
 import java.util.TreeSet;
 
 import org.springframework.util.ObjectUtils;
 
-import static org.springframework.beans.PropertyDescriptorUtils.*;
-
 /**
  * Decorator for a standard {@link BeanInfo} object, e.g. as created by
  * {@link Introspector#getBeanInfo(Class)}, designed to discover and register static
@@ -243,10 +240,9 @@ class ExtendedBeanInfo implements BeanInfo {
 	public MethodDescriptor[] getMethodDescriptors() {
 		return this.delegate.getMethodDescriptors();
 	}
-}
 
 
-class SimplePropertyDescriptor extends PropertyDescriptor {
+	static class SimplePropertyDescriptor extends PropertyDescriptor {
 
 		private Method readMethod;
 
@@ -258,14 +254,14 @@ class SimplePropertyDescriptor extends PropertyDescriptor {
 
 		public SimplePropertyDescriptor(PropertyDescriptor original) throws IntrospectionException {
 			this(original.getName(), original.getReadMethod(), original.getWriteMethod());
-		copyNonMethodProperties(original, this);
+			PropertyDescriptorUtils.copyNonMethodProperties(original, this);
 		}
 
 		public SimplePropertyDescriptor(String propertyName, Method readMethod, Method writeMethod) throws IntrospectionException {
 			super(propertyName, null, null);
 			this.readMethod = readMethod;
 			this.writeMethod = writeMethod;
-		this.propertyType = findPropertyType(readMethod, writeMethod);
+			this.propertyType = PropertyDescriptorUtils.findPropertyType(readMethod, writeMethod);
 		}
 
 		@Override
@@ -292,7 +288,7 @@ class SimplePropertyDescriptor extends PropertyDescriptor {
 		public Class<?> getPropertyType() {
 			if (this.propertyType == null) {
 				try {
-				this.propertyType = findPropertyType(this.readMethod, this.writeMethod);
+					this.propertyType = PropertyDescriptorUtils.findPropertyType(this.readMethod, this.writeMethod);
 				}
 				catch (IntrospectionException ex) {
 					// Ignore, as does PropertyDescriptor#getPropertyType
@@ -330,7 +326,7 @@ class SimplePropertyDescriptor extends PropertyDescriptor {
 	}
 
 
-class SimpleIndexedPropertyDescriptor extends IndexedPropertyDescriptor {
+	static class SimpleIndexedPropertyDescriptor extends IndexedPropertyDescriptor {
 
 		private Method readMethod;
 
@@ -349,7 +345,7 @@ class SimpleIndexedPropertyDescriptor extends IndexedPropertyDescriptor {
 		public SimpleIndexedPropertyDescriptor(IndexedPropertyDescriptor original) throws IntrospectionException {
 			this(original.getName(), original.getReadMethod(), original.getWriteMethod(),
 					original.getIndexedReadMethod(), original.getIndexedWriteMethod());
-		copyNonMethodProperties(original, this);
+			PropertyDescriptorUtils.copyNonMethodProperties(original, this);
 		}
 
 		public SimpleIndexedPropertyDescriptor(String propertyName, Method readMethod, Method writeMethod,
@@ -358,10 +354,11 @@ class SimpleIndexedPropertyDescriptor extends IndexedPropertyDescriptor {
 			super(propertyName, null, null, null, null);
 			this.readMethod = readMethod;
 			this.writeMethod = writeMethod;
-		this.propertyType = findPropertyType(readMethod, writeMethod);
+			this.propertyType = PropertyDescriptorUtils.findPropertyType(readMethod, writeMethod);
 			this.indexedReadMethod = indexedReadMethod;
 			this.indexedWriteMethod = indexedWriteMethod;
-		this.indexedPropertyType = findIndexedPropertyType(propertyName, this.propertyType, indexedReadMethod, indexedWriteMethod);
+			this.indexedPropertyType = PropertyDescriptorUtils.findIndexedPropertyType(
+					propertyName, this.propertyType, indexedReadMethod, indexedWriteMethod);
 		}
 
 		@Override
@@ -388,7 +385,7 @@ class SimpleIndexedPropertyDescriptor extends IndexedPropertyDescriptor {
 		public Class<?> getPropertyType() {
 			if (this.propertyType == null) {
 				try {
-				this.propertyType = findPropertyType(this.readMethod, this.writeMethod);
+					this.propertyType = PropertyDescriptorUtils.findPropertyType(this.readMethod, this.writeMethod);
 				}
 				catch (IntrospectionException ex) {
 					// Ignore, as does IndexedPropertyDescriptor#getPropertyType
@@ -421,7 +418,7 @@ class SimpleIndexedPropertyDescriptor extends IndexedPropertyDescriptor {
 		public Class<?> getIndexedPropertyType() {
 			if (this.indexedPropertyType == null) {
 				try {
-				this.indexedPropertyType = findIndexedPropertyType(
+					this.indexedPropertyType = PropertyDescriptorUtils.findIndexedPropertyType(
 							getName(), getPropertyType(), this.indexedReadMethod, this.indexedWriteMethod);
 				}
 				catch (IntrospectionException ex) {
@@ -478,150 +475,12 @@ class SimpleIndexedPropertyDescriptor extends IndexedPropertyDescriptor {
 	}
 
 
-class PropertyDescriptorUtils {
-
-	/*
-	 * See java.beans.FeatureDescriptor#FeatureDescriptor(FeatureDescriptor)
-	 */
-	public static void copyNonMethodProperties(PropertyDescriptor source, PropertyDescriptor target)
-			throws IntrospectionException {
-
-		target.setExpert(source.isExpert());
-		target.setHidden(source.isHidden());
-		target.setPreferred(source.isPreferred());
-		target.setName(source.getName());
-		target.setShortDescription(source.getShortDescription());
-		target.setDisplayName(source.getDisplayName());
-
-		// Copy all attributes (emulating behavior of private FeatureDescriptor#addTable)
-		Enumeration<String> keys = source.attributeNames();
-		while (keys.hasMoreElements()) {
-			String key = keys.nextElement();
-			target.setValue(key, source.getValue(key));
-		}
-
-		// See java.beans.PropertyDescriptor#PropertyDescriptor(PropertyDescriptor)
-		target.setPropertyEditorClass(source.getPropertyEditorClass());
-		target.setBound(source.isBound());
-		target.setConstrained(source.isConstrained());
-	}
-
-	/*
-	 * See PropertyDescriptor#findPropertyType
-	 */
-	public static Class<?> findPropertyType(Method readMethod, Method writeMethod) throws IntrospectionException {
-		Class<?> propertyType = null;
-		if (readMethod != null) {
-			Class<?>[] params = readMethod.getParameterTypes();
-			if (params.length != 0) {
-				throw new IntrospectionException("Bad read method arg count: " + readMethod);
-			}
-			propertyType = readMethod.getReturnType();
-			if (propertyType == Void.TYPE) {
-				throw new IntrospectionException("Read method returns void: " + readMethod);
-			}
-		}
-		if (writeMethod != null) {
-			Class<?> params[] = writeMethod.getParameterTypes();
-			if (params.length != 1) {
-				throw new IntrospectionException("Bad write method arg count: " + writeMethod);
-			}
-			if (propertyType != null) {
-				if (propertyType.isAssignableFrom(params[0])) {
-					// Write method's property type potentially more specific
-					propertyType = params[0];
-				}
-				else if (params[0].isAssignableFrom(propertyType)) {
-					// Proceed with read method's property type
-				}
-				else {
-					throw new IntrospectionException(
-							"Type mismatch between read and write methods: " + readMethod + " - " + writeMethod);
-				}
-			}
-			else {
-				propertyType = params[0];
-			}
-		}
-		return propertyType;
-	}
-
-	/*
-	 * See IndexedPropertyDescriptor#findIndexedPropertyType
-	 */
-	public static Class<?> findIndexedPropertyType(String name, Class<?> propertyType,
-			Method indexedReadMethod, Method indexedWriteMethod) throws IntrospectionException {
-
-		Class<?> indexedPropertyType = null;
-		if (indexedReadMethod != null) {
-			Class<?> params[] = indexedReadMethod.getParameterTypes();
-			if (params.length != 1) {
-				throw new IntrospectionException("Bad indexed read method arg count: " + indexedReadMethod);
-			}
-			if (params[0] != Integer.TYPE) {
-				throw new IntrospectionException("Non int index to indexed read method: " + indexedReadMethod);
-			}
-			indexedPropertyType = indexedReadMethod.getReturnType();
-			if (indexedPropertyType == Void.TYPE) {
-				throw new IntrospectionException("Indexed read method returns void: " + indexedReadMethod);
-			}
-		}
-		if (indexedWriteMethod != null) {
-			Class<?> params[] = indexedWriteMethod.getParameterTypes();
-			if (params.length != 2) {
-				throw new IntrospectionException("Bad indexed write method arg count: " + indexedWriteMethod);
-			}
-			if (params[0] != Integer.TYPE) {
-				throw new IntrospectionException("Non int index to indexed write method: " + indexedWriteMethod);
-			}
-			if (indexedPropertyType != null) {
-				if (indexedPropertyType.isAssignableFrom(params[1])) {
-					// Write method's property type potentially more specific
-					indexedPropertyType = params[1];
-				}
-				else if (params[1].isAssignableFrom(indexedPropertyType)) {
-					// Proceed with read method's property type
-				}
-				else {
-					throw new IntrospectionException("Type mismatch between indexed read and write methods: " +
-							indexedReadMethod + " - " + indexedWriteMethod);
-				}
-			}
-			else {
-				indexedPropertyType = params[1];
-			}
-		}
-		if (propertyType != null && (!propertyType.isArray() ||
-				propertyType.getComponentType() != indexedPropertyType)) {
-			throw new IntrospectionException("Type mismatch between indexed and non-indexed methods: " +
-					indexedReadMethod + " - " + indexedWriteMethod);
-		}
-		return indexedPropertyType;
-	}
-
-	/**
-	 * Compare the given {@link PropertyDescriptor} against the given {@link Object} and
-	 * return {@code true} if they are objects are equivalent, i.e. both are {@code
-	 * PropertyDescriptor}s whose read method, write method, property types, property
-	 * editor and flags are equivalent.
-	 * @see PropertyDescriptor#equals(Object)
-	 */
-	public static boolean equals(PropertyDescriptor pd, PropertyDescriptor otherPd) {
-		return (ObjectUtils.nullSafeEquals(pd.getReadMethod(), otherPd.getReadMethod()) &&
-				ObjectUtils.nullSafeEquals(pd.getWriteMethod(), otherPd.getWriteMethod()) &&
-				ObjectUtils.nullSafeEquals(pd.getPropertyType(), otherPd.getPropertyType()) &&
-				ObjectUtils.nullSafeEquals(pd.getPropertyEditorClass(), otherPd.getPropertyEditorClass()) &&
-				pd.isBound() == otherPd.isBound() && pd.isConstrained() == otherPd.isConstrained());
-	}
-}
-
-
 	/**
 	 * Sorts PropertyDescriptor instances alpha-numerically to emulate the behavior of
 	 * {@link java.beans.BeanInfo#getPropertyDescriptors()}.
 	 * @see ExtendedBeanInfo#propertyDescriptors
 	 */
-class PropertyDescriptorComparator implements Comparator<PropertyDescriptor> {
+	static class PropertyDescriptorComparator implements Comparator<PropertyDescriptor> {
 
 		@Override
 		public int compare(PropertyDescriptor desc1, PropertyDescriptor desc2) {
@@ -639,3 +498,5 @@ class PropertyDescriptorComparator implements Comparator<PropertyDescriptor> {
 			return left.length() - right.length();
 		}
 	}
+
+}

spring-beans/src/main/java/org/springframework/beans/GenericTypeAwarePropertyDescriptor.java

@@ -28,6 +28,7 @@ import org.springframework.core.BridgeMethodResolver;
 import org.springframework.core.GenericTypeResolver;
 import org.springframework.core.MethodParameter;
 import org.springframework.util.ClassUtils;
+import org.springframework.util.ObjectUtils;
 import org.springframework.util.StringUtils;
 
 /**
@@ -38,12 +39,10 @@ import org.springframework.util.StringUtils;
  * @author Juergen Hoeller
  * @since 2.5.2
  */
-class GenericTypeAwarePropertyDescriptor extends PropertyDescriptor {
+final class GenericTypeAwarePropertyDescriptor extends PropertyDescriptor {
 
 	private final Class<?> beanClass;
 
-	private final Class<?> propertyEditorClass;
-
 	private final Method readMethod;
 
 	private final Method writeMethod;
@@ -54,14 +53,19 @@ class GenericTypeAwarePropertyDescriptor extends PropertyDescriptor {
 
 	private Class<?> propertyType;
 
+	private final Class<?> propertyEditorClass;
+
 
 	public GenericTypeAwarePropertyDescriptor(Class<?> beanClass, String propertyName,
 			Method readMethod, Method writeMethod, Class<?> propertyEditorClass)
 			throws IntrospectionException {
 
 		super(propertyName, null, null);
+
+		if (beanClass == null)  {
+			throw new IntrospectionException("Bean class must not be null");
+		}
 		this.beanClass = beanClass;
-		this.propertyEditorClass = propertyEditorClass;
 
 		Method readMethodToUse = BridgeMethodResolver.findBridgedMethod(readMethod);
 		Method writeMethodToUse = BridgeMethodResolver.findBridgedMethod(writeMethod);
@@ -104,6 +108,8 @@ class GenericTypeAwarePropertyDescriptor extends PropertyDescriptor {
 		else if (this.writeMethodParameter != null) {
 			this.propertyType = this.writeMethodParameter.getParameterType();
 		}
+
+		this.propertyEditorClass = propertyEditorClass;
 	}
 
 
@@ -111,11 +117,6 @@ class GenericTypeAwarePropertyDescriptor extends PropertyDescriptor {
 		return this.beanClass;
 	}
 
-	@Override
-	public Class<?> getPropertyEditorClass() {
-		return this.propertyEditorClass;
-	}
-
 	@Override
 	public Method getReadMethod() {
 		return this.readMethod;
@@ -146,4 +147,30 @@ class GenericTypeAwarePropertyDescriptor extends PropertyDescriptor {
 		return this.propertyType;
 	}
 
+	@Override
+	public Class<?> getPropertyEditorClass() {
+		return this.propertyEditorClass;
+	}
+
+
+	@Override
+	public boolean equals(Object other) {
+		if (this == other) {
+			return true;
+		}
+		if (!(other instanceof GenericTypeAwarePropertyDescriptor)) {
+			return false;
+		}
+		GenericTypeAwarePropertyDescriptor otherPd = (GenericTypeAwarePropertyDescriptor) other;
+		return (getBeanClass().equals(otherPd.getBeanClass()) && PropertyDescriptorUtils.equals(this, otherPd));
+	}
+
+	@Override
+	public int hashCode() {
+		int hashCode = getBeanClass().hashCode();
+		hashCode = 29 * hashCode + ObjectUtils.nullSafeHashCode(getReadMethod());
+		hashCode = 29 * hashCode + ObjectUtils.nullSafeHashCode(getWriteMethod());
+		return hashCode;
+	}
+
 }

spring-beans/src/test/java/org/springframework/beans/ExtendedBeanInfoTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -776,7 +776,7 @@ public class ExtendedBeanInfoTests {
 
 	@Test
 	public void propertyDescriptorComparator() throws IntrospectionException {
-		PropertyDescriptorComparator c = new PropertyDescriptorComparator();
+		ExtendedBeanInfo.PropertyDescriptorComparator c = new ExtendedBeanInfo.PropertyDescriptorComparator();
 
 		assertThat(c.compare(new PropertyDescriptor("a", null, null), new PropertyDescriptor("a", null, null)), equalTo(0));
 		assertThat(c.compare(new PropertyDescriptor("abc", null, null), new PropertyDescriptor("abc", null, null)), equalTo(0));
@@ -793,53 +793,6 @@ public class ExtendedBeanInfoTests {
 		assertThat(c.compare(new PropertyDescriptor("a", null, null), new PropertyDescriptor("A", null, null)), greaterThan(0));
 	}
 
-	private boolean hasWriteMethodForProperty(BeanInfo beanInfo, String propertyName) {
-		for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) {
-			if (pd.getName().equals(propertyName)) {
-				return pd.getWriteMethod() != null;
-			}
-		}
-		return false;
-	}
-
-	private boolean hasReadMethodForProperty(BeanInfo beanInfo, String propertyName) {
-		for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) {
-			if (pd.getName().equals(propertyName)) {
-				return pd.getReadMethod() != null;
-			}
-		}
-		return false;
-	}
-
-	private boolean hasIndexedWriteMethodForProperty(BeanInfo beanInfo, String propertyName) {
-		for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) {
-			if (pd.getName().equals(propertyName)) {
-				if (!(pd instanceof IndexedPropertyDescriptor)) {
-					return false;
-				}
-				return ((IndexedPropertyDescriptor)pd).getIndexedWriteMethod() != null;
-			}
-		}
-		return false;
-	}
-
-	private boolean hasIndexedReadMethodForProperty(BeanInfo beanInfo, String propertyName) {
-		for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) {
-			if (pd.getName().equals(propertyName)) {
-				if (!(pd instanceof IndexedPropertyDescriptor)) {
-					return false;
-				}
-				return ((IndexedPropertyDescriptor)pd).getIndexedReadMethod() != null;
-			}
-		}
-		return false;
-	}
-
-	private boolean trueUntilJdk17() {
-		return JdkVersion.getMajorJavaVersion() < JdkVersion.JAVA_17;
-	}
-
-
 	@Test
 	public void reproSpr8806() throws IntrospectionException {
 		// does not throw
@@ -923,20 +876,71 @@ public class ExtendedBeanInfoTests {
 	}
 
 
+	private boolean hasWriteMethodForProperty(BeanInfo beanInfo, String propertyName) {
+		for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) {
+			if (pd.getName().equals(propertyName)) {
+				return pd.getWriteMethod() != null;
+			}
+		}
+		return false;
+	}
+
+	private boolean hasReadMethodForProperty(BeanInfo beanInfo, String propertyName) {
+		for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) {
+			if (pd.getName().equals(propertyName)) {
+				return pd.getReadMethod() != null;
+			}
+		}
+		return false;
+	}
+
+	private boolean hasIndexedWriteMethodForProperty(BeanInfo beanInfo, String propertyName) {
+		for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) {
+			if (pd.getName().equals(propertyName)) {
+				if (!(pd instanceof IndexedPropertyDescriptor)) {
+					return false;
+				}
+				return ((IndexedPropertyDescriptor)pd).getIndexedWriteMethod() != null;
+			}
+		}
+		return false;
+	}
+
+	private boolean hasIndexedReadMethodForProperty(BeanInfo beanInfo, String propertyName) {
+		for (PropertyDescriptor pd : beanInfo.getPropertyDescriptors()) {
+			if (pd.getName().equals(propertyName)) {
+				if (!(pd instanceof IndexedPropertyDescriptor)) {
+					return false;
+				}
+				return ((IndexedPropertyDescriptor)pd).getIndexedReadMethod() != null;
+			}
+		}
+		return false;
+	}
+
+	private boolean trueUntilJdk17() {
+		return JdkVersion.getMajorJavaVersion() < JdkVersion.JAVA_17;
+	}
+
+
 	interface Spr9453<T> {
 
 		T getProp();
 	}
 
+
 	interface Book {
 	}
 
+
 	interface TextBook extends Book {
 	}
 
+
 	interface LawBook extends TextBook {
 	}
 
+
 	interface BookOperations {
 
 		Book getBook();
@@ -944,12 +948,14 @@ public class ExtendedBeanInfoTests {
 		void setBook(Book book);
 	}
 
+
 	interface TextBookOperations extends BookOperations {
 
 		@Override
 		TextBook getBook();
 	}
 
+
 	abstract class Library {
 
 		public Book getBook() {
@@ -960,6 +966,7 @@ public class ExtendedBeanInfoTests {
 		}
 	}
 
+
 	class LawLibrary extends Library implements TextBookOperations {
 
 		@Override
@@ -968,6 +975,7 @@ public class ExtendedBeanInfoTests {
 		}
 	}
 
+
 	static class WithStaticWriteMethod {
 
 		public static void setProp1(String prop1) {

spring-beans/src/test/java/org/springframework/beans/SimplePropertyDescriptorTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2014 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -19,7 +19,6 @@ package org.springframework.beans;
 import java.beans.IndexedPropertyDescriptor;
 import java.beans.IntrospectionException;
 import java.beans.PropertyDescriptor;
-
 import java.lang.reflect.Method;
 
 import org.junit.Test;
@@ -28,9 +27,6 @@ import static org.hamcrest.CoreMatchers.*;
 import static org.junit.Assert.*;
 
 /**
- * Unit tests for {@link SimplePropertyDescriptor} and
- * {@link SimpleIndexedPropertyDescriptor}.
- *
  * @author Chris Beams
  * @see ExtendedBeanInfoTests
  */
@@ -39,7 +35,7 @@ public class SimplePropertyDescriptorTests {
 	@Test
 	public void toStringOutput() throws IntrospectionException, SecurityException, NoSuchMethodException {
 		{
-			Object pd = new SimplePropertyDescriptor("foo", null, null);
+			Object pd = new ExtendedBeanInfo.SimplePropertyDescriptor("foo", null, null);
 			assertThat(pd.toString(), containsString(
 					"PropertyDescriptor[name=foo, propertyType=null, readMethod=null"));
 		}
@@ -49,14 +45,14 @@ public class SimplePropertyDescriptorTests {
 				public Object setFoo(String foo) { return null; }
 			}
 			Method m = C.class.getMethod("setFoo", String.class);
-			Object pd = new SimplePropertyDescriptor("foo", null, m);
+			Object pd = new ExtendedBeanInfo.SimplePropertyDescriptor("foo", null, m);
 			assertThat(pd.toString(), allOf(
 					containsString("PropertyDescriptor[name=foo"),
 					containsString("propertyType=class java.lang.String"),
 					containsString("readMethod=null, writeMethod=public java.lang.Object")));
 		}
 		{
-			Object pd = new SimpleIndexedPropertyDescriptor("foo", null, null, null, null);
+			Object pd = new ExtendedBeanInfo.SimpleIndexedPropertyDescriptor("foo", null, null, null, null);
 			assertThat(pd.toString(), containsString(
 					"PropertyDescriptor[name=foo, propertyType=null, indexedPropertyType=null"));
 		}
@@ -66,7 +62,7 @@ public class SimplePropertyDescriptorTests {
 				public Object setFoo(int i, String foo) { return null; }
 			}
 			Method m = C.class.getMethod("setFoo", int.class, String.class);
-			Object pd = new SimpleIndexedPropertyDescriptor("foo", null, null, null, m);
+			Object pd = new ExtendedBeanInfo.SimpleIndexedPropertyDescriptor("foo", null, null, null, m);
 			assertThat(pd.toString(), allOf(
 					containsString("PropertyDescriptor[name=foo, propertyType=null"),
 					containsString("indexedPropertyType=class java.lang.String"),
@@ -76,10 +72,10 @@ public class SimplePropertyDescriptorTests {
 
 	@Test
 	public void nonIndexedEquality() throws IntrospectionException, SecurityException, NoSuchMethodException {
-		Object pd1 = new SimplePropertyDescriptor("foo", null, null);
+		Object pd1 = new ExtendedBeanInfo.SimplePropertyDescriptor("foo", null, null);
 		assertThat(pd1, equalTo(pd1));
 
-		Object pd2 = new SimplePropertyDescriptor("foo", null, null);
+		Object pd2 = new ExtendedBeanInfo.SimplePropertyDescriptor("foo", null, null);
 		assertThat(pd1, equalTo(pd2));
 		assertThat(pd2, equalTo(pd1));
 
@@ -89,12 +85,12 @@ public class SimplePropertyDescriptorTests {
 			public String getFoo() { return null; }
 		}
 		Method wm1 = C.class.getMethod("setFoo", String.class);
-		Object pd3 = new SimplePropertyDescriptor("foo", null, wm1);
+		Object pd3 = new ExtendedBeanInfo.SimplePropertyDescriptor("foo", null, wm1);
 		assertThat(pd1, not(equalTo(pd3)));
 		assertThat(pd3, not(equalTo(pd1)));
 
 		Method rm1 = C.class.getMethod("getFoo");
-		Object pd4 = new SimplePropertyDescriptor("foo", rm1, null);
+		Object pd4 = new ExtendedBeanInfo.SimplePropertyDescriptor("foo", rm1, null);
 		assertThat(pd1, not(equalTo(pd4)));
 		assertThat(pd4, not(equalTo(pd1)));
 
@@ -113,10 +109,10 @@ public class SimplePropertyDescriptorTests {
 
 	@Test
 	public void indexedEquality() throws IntrospectionException, SecurityException, NoSuchMethodException {
-		Object pd1 = new SimpleIndexedPropertyDescriptor("foo", null, null, null, null);
+		Object pd1 = new ExtendedBeanInfo.SimpleIndexedPropertyDescriptor("foo", null, null, null, null);
 		assertThat(pd1, equalTo(pd1));
 
-		Object pd2 = new SimpleIndexedPropertyDescriptor("foo", null, null, null, null);
+		Object pd2 = new ExtendedBeanInfo.SimpleIndexedPropertyDescriptor("foo", null, null, null, null);
 		assertThat(pd1, equalTo(pd2));
 		assertThat(pd2, equalTo(pd1));
 
@@ -126,12 +122,12 @@ public class SimplePropertyDescriptorTests {
 			public String getFoo(int i) { return null; }
 		}
 		Method wm1 = C.class.getMethod("setFoo", int.class, String.class);
-		Object pd3 = new SimpleIndexedPropertyDescriptor("foo", null, null, null, wm1);
+		Object pd3 = new ExtendedBeanInfo.SimpleIndexedPropertyDescriptor("foo", null, null, null, wm1);
 		assertThat(pd1, not(equalTo(pd3)));
 		assertThat(pd3, not(equalTo(pd1)));
 
 		Method rm1 = C.class.getMethod("getFoo", int.class);
-		Object pd4 = new SimpleIndexedPropertyDescriptor("foo", null, null, rm1, null);
+		Object pd4 = new ExtendedBeanInfo.SimpleIndexedPropertyDescriptor("foo", null, null, rm1, null);
 		assertThat(pd1, not(equalTo(pd4)));
 		assertThat(pd4, not(equalTo(pd1)));