root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Improve diagnostics for flaky ParallelApplicationEventsIntegrationTests

This commit is contained in:
Sam Brannen 2021-02-12 12:02:37 +01:00
parent 566ff54782
commit 5d70aaacef
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
spring-test/src/test/java/org/springframework/test/context/junit/jupiter/event/ParallelApplicationEventsIntegrationTests.java
View File

@ -75,13 +75,16 @@ class ParallelApplicationEventsIntegrationTests {
assertThat(payloads).hasSize(10); assertThat(payloads).hasSize(10);
assertThat(testNames).hasSize(10); assertThat(testNames).hasSize(10);
int availableProcessors = Runtime.getRuntime().availableProcessors();
// Skip the following assertion entirely if too few processors are available // Skip the following assertion entirely if too few processors are available
// to the current JVM. // to the current JVM.
if (Runtime.getRuntime().availableProcessors() >= 4) { if (availableProcessors >= 6) {
// There are probably 10 different thread names on a developer's machine, // There are probably 10 different thread names on a developer's machine,
// but we really just want to assert that at least two different threads // but we really just want to assert that at least two different threads
// were used, since the CI server often has fewer threads available. // were used, since the CI server often has fewer threads available.
assertThat(threadNames).hasSizeGreaterThanOrEqualTo(2); assertThat(threadNames)
.as("number of threads used with " + availableProcessors + " available processors")
.hasSizeGreaterThanOrEqualTo(2);
} }
} }