root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Avoid StringBuilder.append(Object) in ContentDisposition 

This commit avoids invoking StringBuilder.append(Object) in favor
of explicit method calls to append(String) and append(char) in
ContentDisposition.escapeQuotationsInFilename(String).

Closes gh-25056
This commit is contained in:
Сергей Цыпанов 2020-05-12 19:36:31 +03:00 committed by GitHub
parent 311b333814
commit 6305a69cc1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
spring-web/src/main/java/org/springframework/http/ContentDisposition.java
View File

@ -39,6 +39,7 @@ import static java.time.format.DateTimeFormatter.RFC_1123_DATE_TIME;
* @author Sebastien Deleuze * @author Sebastien Deleuze
* @author Juergen Hoeller * @author Juergen Hoeller
* @author Rossen Stoyanchev * @author Rossen Stoyanchev
* @author Sergey Tsypanov
* @since 5.0 * @since 5.0
* @see <a href="https://tools.ietf.org/html/rfc6266">RFC 6266</a> * @see <a href="https://tools.ietf.org/html/rfc6266">RFC 6266</a>
*/ */
@ -436,7 +437,11 @@ public final class ContentDisposition {
boolean escaped = false; boolean escaped = false;
StringBuilder sb = new StringBuilder(); StringBuilder sb = new StringBuilder();
for (char c : filename.toCharArray()) { for (char c : filename.toCharArray()) {
sb.append((c == '"' && !escaped) ? "\\\"" : c); if (!escaped && c == '"') {
sb.append("\\\"");
} else {
sb.append(c);
}
escaped = (!escaped && c == '\\'); escaped = (!escaped && c == '\\');
} }
// Remove backslash at the end.. // Remove backslash at the end..