diff --git a/org.springframework.context/src/main/java/org/springframework/model/binder/BindingResults.java b/org.springframework.context/src/main/java/org/springframework/model/binder/BindingResults.java index 6b95155af36..4f39f3ad438 100644 --- a/org.springframework.context/src/main/java/org/springframework/model/binder/BindingResults.java +++ b/org.springframework.context/src/main/java/org/springframework/model/binder/BindingResults.java @@ -30,13 +30,19 @@ public interface BindingResults extends Iterable { */ BindingResults successes(); + /** + * If there is at least one failed BindingResult. + * @see BindingResult#isFailure() + */ + boolean hasFailures(); + /** * The subset of BindingResults that failed. */ BindingResults failures(); /** - * The number of results. + * The total number of results. */ int size(); diff --git a/org.springframework.context/src/main/java/org/springframework/model/binder/MissingFieldException.java b/org.springframework.context/src/main/java/org/springframework/model/binder/MissingFieldException.java index d1cbe1474af..74b5eaff3bd 100644 --- a/org.springframework.context/src/main/java/org/springframework/model/binder/MissingFieldException.java +++ b/org.springframework.context/src/main/java/org/springframework/model/binder/MissingFieldException.java @@ -31,17 +31,17 @@ public class MissingFieldException extends RuntimeException { private List missing; /** - * Creates a new missing source values exeption. + * Creates a new missing field exceptions. * @param missing - * @param sourceValues + * @param fieldValues */ - public MissingFieldException(List missing, Map sourceValues) { - super(getMessage(missing, sourceValues)); + public MissingFieldException(List missing, Map fieldValues) { + super(getMessage(missing, fieldValues)); this.missing = missing; } /** - * The property paths for which source values were missing. + * The names of the fields that are missing. */ public List getMissing() { return missing; diff --git a/org.springframework.context/src/main/java/org/springframework/model/ui/binder/ArrayListBindingResults.java b/org.springframework.context/src/main/java/org/springframework/model/ui/binder/ArrayListBindingResults.java index a0a03421b5e..72721a599fb 100644 --- a/org.springframework.context/src/main/java/org/springframework/model/ui/binder/ArrayListBindingResults.java +++ b/org.springframework.context/src/main/java/org/springframework/model/ui/binder/ArrayListBindingResults.java @@ -56,6 +56,10 @@ class ArrayListBindingResults implements BindingResults { return results; } + public boolean hasFailures() { + return failures().size() > 0; + } + public BindingResults failures() { ArrayListBindingResults results = new ArrayListBindingResults(); for (BindingResult result : this) { diff --git a/org.springframework.context/src/main/java/org/springframework/model/ui/binder/FieldNotEditableResult.java b/org.springframework.context/src/main/java/org/springframework/model/ui/binder/FieldNotEditableResult.java index 3b79a3ccb33..b10fc5bfb40 100644 --- a/org.springframework.context/src/main/java/org/springframework/model/ui/binder/FieldNotEditableResult.java +++ b/org.springframework.context/src/main/java/org/springframework/model/ui/binder/FieldNotEditableResult.java @@ -52,7 +52,7 @@ class FieldNotEditableResult implements BindingResult { public Alert getAlert() { return new Alert() { public String getCode() { - return "propertyNotWriteable"; + return "fieldNotEditable"; } public Severity getSeverity() { diff --git a/org.springframework.context/src/main/java/org/springframework/model/ui/binder/FieldNotFoundResult.java b/org.springframework.context/src/main/java/org/springframework/model/ui/binder/FieldNotFoundResult.java index 92413551aea..18511d35552 100644 --- a/org.springframework.context/src/main/java/org/springframework/model/ui/binder/FieldNotFoundResult.java +++ b/org.springframework.context/src/main/java/org/springframework/model/ui/binder/FieldNotFoundResult.java @@ -52,7 +52,7 @@ class FieldNotFoundResult implements BindingResult { public Alert getAlert() { return new Alert() { public String getCode() { - return "propertyNotFound"; + return "fieldNotFound"; } public Severity getSeverity() {