From 63b2787da6d8efa71d1675ad04d21a1798e0c769 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adam=20Ostro=C5=BEl=C3=ADk?= Date: Sat, 9 Dec 2023 16:01:37 +0100 Subject: [PATCH] Use String.repeat instead of explicit cycle See gh-31802 --- .../org/springframework/beans/factory/parsing/ParseState.java | 4 +--- spring-core/src/main/java/org/springframework/asm/Type.java | 4 +--- .../java/org/springframework/cglib/core/ReflectUtils.java | 4 +--- .../web/util/pattern/PatternParseException.java | 4 +--- .../web/reactive/function/server/ToStringVisitor.java | 4 +--- .../springframework/web/servlet/function/ToStringVisitor.java | 4 +--- .../web/socket/sockjs/frame/AbstractSockJsMessageCodec.java | 4 +--- 7 files changed, 7 insertions(+), 21 deletions(-) diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/parsing/ParseState.java b/spring-beans/src/main/java/org/springframework/beans/factory/parsing/ParseState.java index 0277bc0a0f..d83e016798 100644 --- a/spring-beans/src/main/java/org/springframework/beans/factory/parsing/ParseState.java +++ b/spring-beans/src/main/java/org/springframework/beans/factory/parsing/ParseState.java @@ -98,9 +98,7 @@ public final class ParseState { for (ParseState.Entry entry : this.state) { if (i > 0) { sb.append('\n'); - for (int j = 0; j < i; j++) { - sb.append('\t'); - } + sb.append("\t".repeat(i)); sb.append("-> "); } sb.append(entry); diff --git a/spring-core/src/main/java/org/springframework/asm/Type.java b/spring-core/src/main/java/org/springframework/asm/Type.java index 7e35a139c0..e1a2b13e47 100644 --- a/spring-core/src/main/java/org/springframework/asm/Type.java +++ b/spring-core/src/main/java/org/springframework/asm/Type.java @@ -462,9 +462,7 @@ public final class Type { return "double"; case ARRAY: StringBuilder stringBuilder = new StringBuilder(getElementType().getClassName()); - for (int i = getDimensions(); i > 0; --i) { - stringBuilder.append("[]"); - } + stringBuilder.append("[]".repeat(Math.max(0, getDimensions()))); return stringBuilder.toString(); case OBJECT: case INTERNAL: diff --git a/spring-core/src/main/java/org/springframework/cglib/core/ReflectUtils.java b/spring-core/src/main/java/org/springframework/cglib/core/ReflectUtils.java index 9bd022ccee..9c4141ccdd 100644 --- a/spring-core/src/main/java/org/springframework/cglib/core/ReflectUtils.java +++ b/spring-core/src/main/java/org/springframework/cglib/core/ReflectUtils.java @@ -218,9 +218,7 @@ public class ReflectUtils { dimensions++; } StringBuilder brackets = new StringBuilder(className.length() - dimensions); - for (int i = 0; i < dimensions; i++) { - brackets.append('['); - } + brackets.append("[".repeat(Math.max(0, dimensions))); className = className.substring(0, className.length() - 2 * dimensions); String prefix = (dimensions > 0) ? brackets + "L" : ""; diff --git a/spring-web/src/main/java/org/springframework/web/util/pattern/PatternParseException.java b/spring-web/src/main/java/org/springframework/web/util/pattern/PatternParseException.java index 1e49751da8..9c6efc95ed 100644 --- a/spring-web/src/main/java/org/springframework/web/util/pattern/PatternParseException.java +++ b/spring-web/src/main/java/org/springframework/web/util/pattern/PatternParseException.java @@ -68,9 +68,7 @@ public class PatternParseException extends IllegalArgumentException { public String toDetailedString() { StringBuilder sb = new StringBuilder(); sb.append(this.pattern).append('\n'); - for (int i = 0; i < this.position; i++) { - sb.append(' '); - } + sb.append(" ".repeat(Math.max(0, this.position))); sb.append("^\n"); sb.append(getMessage()); return sb.toString(); diff --git a/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ToStringVisitor.java b/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ToStringVisitor.java index 3adb272358..00416bf01a 100644 --- a/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ToStringVisitor.java +++ b/spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ToStringVisitor.java @@ -81,9 +81,7 @@ class ToStringVisitor implements RouterFunctions.Visitor, RequestPredicates.Visi } private void indent() { - for (int i = 0; i < this.indent; i++) { - this.builder.append(' '); - } + this.builder.append(" ".repeat(Math.max(0, this.indent))); } diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/function/ToStringVisitor.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/function/ToStringVisitor.java index dbbe254804..6654d85fdc 100644 --- a/spring-webmvc/src/main/java/org/springframework/web/servlet/function/ToStringVisitor.java +++ b/spring-webmvc/src/main/java/org/springframework/web/servlet/function/ToStringVisitor.java @@ -80,9 +80,7 @@ class ToStringVisitor implements RouterFunctions.Visitor, RequestPredicates.Visi } private void indent() { - for (int i = 0; i < this.indent; i++) { - this.builder.append(' '); - } + this.builder.append(" ".repeat(Math.max(0, this.indent))); } diff --git a/spring-websocket/src/main/java/org/springframework/web/socket/sockjs/frame/AbstractSockJsMessageCodec.java b/spring-websocket/src/main/java/org/springframework/web/socket/sockjs/frame/AbstractSockJsMessageCodec.java index 6fb86f4df4..01ba5afda3 100644 --- a/spring-websocket/src/main/java/org/springframework/web/socket/sockjs/frame/AbstractSockJsMessageCodec.java +++ b/spring-websocket/src/main/java/org/springframework/web/socket/sockjs/frame/AbstractSockJsMessageCodec.java @@ -59,9 +59,7 @@ public abstract class AbstractSockJsMessageCodec implements SockJsMessageCodec { if (isSockJsSpecialChar(c)) { result.append('\\').append('u'); String hex = Integer.toHexString(c).toLowerCase(); - for (int i = 0; i < (4 - hex.length()); i++) { - result.append('0'); - } + result.append("0".repeat(Math.max(0, (4 - hex.length())))); result.append(hex); } else {