diff --git a/spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java b/spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java index d33452bee57..1b27b8e4b07 100644 --- a/spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java +++ b/spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java @@ -2567,7 +2567,7 @@ public class DefaultListableBeanFactoryTests { @Test public void testSingletonLookupByNameIsFastEnough() { - // Assume.group(TestGroup.PERFORMANCE); + Assume.group(TestGroup.PERFORMANCE); Assume.notLogging(factoryLog); DefaultListableBeanFactory lbf = new DefaultListableBeanFactory(); lbf.registerBeanDefinition("test", new RootBeanDefinition(TestBean.class)); @@ -2584,7 +2584,7 @@ public class DefaultListableBeanFactoryTests { @Test public void testSingletonLookupByTypeIsFastEnough() { - // Assume.group(TestGroup.PERFORMANCE); + Assume.group(TestGroup.PERFORMANCE); Assume.notLogging(factoryLog); DefaultListableBeanFactory lbf = new DefaultListableBeanFactory(); lbf.registerBeanDefinition("test", new RootBeanDefinition(TestBean.class)); diff --git a/spring-jdbc/src/main/java/org/springframework/jdbc/support/GeneratedKeyHolder.java b/spring-jdbc/src/main/java/org/springframework/jdbc/support/GeneratedKeyHolder.java index c531f71a6c2..51d720f077e 100644 --- a/spring-jdbc/src/main/java/org/springframework/jdbc/support/GeneratedKeyHolder.java +++ b/spring-jdbc/src/main/java/org/springframework/jdbc/support/GeneratedKeyHolder.java @@ -26,12 +26,12 @@ import org.springframework.dao.InvalidDataAccessApiUsageException; import org.springframework.lang.Nullable; /** - * Default implementation of the {@link KeyHolder} interface, to be used for + * The standard implementation of the {@link KeyHolder} interface, to be used for * holding auto-generated keys (as potentially returned by JDBC insert statements). * - *

Create an instance of this class for each insert operation, and pass - * it to the corresponding {@link org.springframework.jdbc.core.JdbcTemplate} - * or {org.springframework.jdbc.object.SqlUpdate} methods. + *

Create an instance of this class for each insert operation, and pass it + * to the corresponding {@link org.springframework.jdbc.core.JdbcTemplate} or + * {@link org.springframework.jdbc.object.SqlUpdate} methods. * * @author Thomas Risberg * @author Juergen Hoeller diff --git a/spring-jdbc/src/main/java/org/springframework/jdbc/support/KeyHolder.java b/spring-jdbc/src/main/java/org/springframework/jdbc/support/KeyHolder.java index e71725bd10d..930fa0029f3 100644 --- a/spring-jdbc/src/main/java/org/springframework/jdbc/support/KeyHolder.java +++ b/spring-jdbc/src/main/java/org/springframework/jdbc/support/KeyHolder.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2012 the original author or authors. + * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -52,17 +52,17 @@ public interface KeyHolder { * multiple entries as well. If this method encounters multiple entries in * either the map or the list meaning that multiple keys were returned, * then an InvalidDataAccessApiUsageException is thrown. - * @return the generated key - * @throws InvalidDataAccessApiUsageException if multiple keys are encountered. + * @return the generated key as a number + * @throws InvalidDataAccessApiUsageException if multiple keys are encountered */ @Nullable Number getKey() throws InvalidDataAccessApiUsageException; /** - * Retrieve the first map of keys. If there are multiple entries in the list - * (meaning that multiple rows had keys returned), then an - * InvalidDataAccessApiUsageException is thrown. - * @return the Map of generated keys + * Retrieve the first map of keys. + *

If there are multiple entries in the list (meaning that multiple rows + * had keys returned), then an InvalidDataAccessApiUsageException is thrown. + * @return the Map of generated keys for a single row * @throws InvalidDataAccessApiUsageException if keys for multiple rows are encountered */ @Nullable @@ -70,10 +70,10 @@ public interface KeyHolder { /** * Return a reference to the List that contains the keys. - * Can be used for extracting keys for multiple rows (an unusual case), + *

Can be used for extracting keys for multiple rows (an unusual case), * and also for adding new maps of keys. - * @return the List for the generated keys, with each entry being a Map - * of column names and key values + * @return the List for the generated keys, with each entry representing + * an individual row through a Map of column names and key values */ List> getKeyList();