diff --git a/spring-beans/src/test/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessorTests.java b/spring-beans/src/test/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessorTests.java index 8912f7bf737..305e07e5a27 100644 --- a/spring-beans/src/test/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessorTests.java +++ b/spring-beans/src/test/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessorTests.java @@ -1274,17 +1274,17 @@ public class AutowiredAnnotationBeanPostProcessorTests { MapFieldInjectionBean bean = bf.getBean("annotatedBean", MapFieldInjectionBean.class); assertThat(bean.getTestBeanMap()).hasSize(2); - assertThat(bean.getTestBeanMap().keySet().contains("testBean1")).isTrue(); - assertThat(bean.getTestBeanMap().keySet().contains("testBean2")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb1)).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb2)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean1"); + assertThat(bean.getTestBeanMap()).containsKey("testBean2"); + assertThat(bean.getTestBeanMap()).containsValue(tb1); + assertThat(bean.getTestBeanMap()).containsValue(tb2); bean = bf.getBean("annotatedBean", MapFieldInjectionBean.class); assertThat(bean.getTestBeanMap()).hasSize(2); - assertThat(bean.getTestBeanMap().keySet().contains("testBean1")).isTrue(); - assertThat(bean.getTestBeanMap().keySet().contains("testBean2")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb1)).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb2)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean1"); + assertThat(bean.getTestBeanMap()).containsKey("testBean2"); + assertThat(bean.getTestBeanMap()).containsValue(tb1); + assertThat(bean.getTestBeanMap()).containsValue(tb2); } @Test @@ -1297,14 +1297,14 @@ public class AutowiredAnnotationBeanPostProcessorTests { MapMethodInjectionBean bean = bf.getBean("annotatedBean", MapMethodInjectionBean.class); assertThat(bean.getTestBeanMap()).hasSize(1); - assertThat(bean.getTestBeanMap().keySet().contains("testBean")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean"); + assertThat(bean.getTestBeanMap()).containsValue(tb); assertThat(bean.getTestBean()).isSameAs(tb); bean = bf.getBean("annotatedBean", MapMethodInjectionBean.class); assertThat(bean.getTestBeanMap()).hasSize(1); - assertThat(bean.getTestBeanMap().keySet().contains("testBean")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean"); + assertThat(bean.getTestBeanMap()).containsValue(tb); assertThat(bean.getTestBean()).isSameAs(tb); } @@ -1329,8 +1329,8 @@ public class AutowiredAnnotationBeanPostProcessorTests { MapMethodInjectionBean bean = bf.getBean("annotatedBean", MapMethodInjectionBean.class); TestBean tb = bf.getBean("testBean1", TestBean.class); assertThat(bean.getTestBeanMap()).hasSize(1); - assertThat(bean.getTestBeanMap().keySet().contains("testBean1")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean1"); + assertThat(bean.getTestBeanMap()).containsValue(tb); assertThat(bean.getTestBean()).isSameAs(tb); } diff --git a/spring-beans/src/test/java/org/springframework/beans/factory/annotation/InjectAnnotationBeanPostProcessorTests.java b/spring-beans/src/test/java/org/springframework/beans/factory/annotation/InjectAnnotationBeanPostProcessorTests.java index e94e472d0af..e7ccfb45cc8 100644 --- a/spring-beans/src/test/java/org/springframework/beans/factory/annotation/InjectAnnotationBeanPostProcessorTests.java +++ b/spring-beans/src/test/java/org/springframework/beans/factory/annotation/InjectAnnotationBeanPostProcessorTests.java @@ -222,17 +222,17 @@ public class InjectAnnotationBeanPostProcessorTests { MapConstructorInjectionBean bean = (MapConstructorInjectionBean) bf.getBean("annotatedBean"); assertThat(bean.getTestBeanMap()).hasSize(2); - assertThat(bean.getTestBeanMap().keySet().contains("testBean1")).isTrue(); - assertThat(bean.getTestBeanMap().keySet().contains("testBean2")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb1)).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb2)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean1"); + assertThat(bean.getTestBeanMap()).containsKey("testBean2"); + assertThat(bean.getTestBeanMap()).containsValue(tb1); + assertThat(bean.getTestBeanMap()).containsValue(tb2); bean = (MapConstructorInjectionBean) bf.getBean("annotatedBean"); assertThat(bean.getTestBeanMap()).hasSize(2); - assertThat(bean.getTestBeanMap().keySet().contains("testBean1")).isTrue(); - assertThat(bean.getTestBeanMap().keySet().contains("testBean2")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb1)).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb2)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean1"); + assertThat(bean.getTestBeanMap()).containsKey("testBean2"); + assertThat(bean.getTestBeanMap()).containsValue(tb1); + assertThat(bean.getTestBeanMap()).containsValue(tb2); } @Test @@ -247,17 +247,17 @@ public class InjectAnnotationBeanPostProcessorTests { MapFieldInjectionBean bean = (MapFieldInjectionBean) bf.getBean("annotatedBean"); assertThat(bean.getTestBeanMap()).hasSize(2); - assertThat(bean.getTestBeanMap().keySet().contains("testBean1")).isTrue(); - assertThat(bean.getTestBeanMap().keySet().contains("testBean2")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb1)).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb2)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean1"); + assertThat(bean.getTestBeanMap()).containsKey("testBean2"); + assertThat(bean.getTestBeanMap()).containsValue(tb1); + assertThat(bean.getTestBeanMap()).containsValue(tb2); bean = (MapFieldInjectionBean) bf.getBean("annotatedBean"); assertThat(bean.getTestBeanMap()).hasSize(2); - assertThat(bean.getTestBeanMap().keySet().contains("testBean1")).isTrue(); - assertThat(bean.getTestBeanMap().keySet().contains("testBean2")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb1)).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb2)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean1"); + assertThat(bean.getTestBeanMap()).containsKey("testBean2"); + assertThat(bean.getTestBeanMap()).containsValue(tb1); + assertThat(bean.getTestBeanMap()).containsValue(tb2); } @Test @@ -270,14 +270,14 @@ public class InjectAnnotationBeanPostProcessorTests { MapMethodInjectionBean bean = (MapMethodInjectionBean) bf.getBean("annotatedBean"); assertThat(bean.getTestBeanMap()).hasSize(1); - assertThat(bean.getTestBeanMap().keySet().contains("testBean")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean"); + assertThat(bean.getTestBeanMap()).containsValue(tb); assertThat(bean.getTestBean()).isSameAs(tb); bean = (MapMethodInjectionBean) bf.getBean("annotatedBean"); assertThat(bean.getTestBeanMap()).hasSize(1); - assertThat(bean.getTestBeanMap().keySet().contains("testBean")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean"); + assertThat(bean.getTestBeanMap()).containsValue(tb); assertThat(bean.getTestBean()).isSameAs(tb); } @@ -301,8 +301,8 @@ public class InjectAnnotationBeanPostProcessorTests { MapMethodInjectionBean bean = (MapMethodInjectionBean) bf.getBean("annotatedBean"); TestBean tb = (TestBean) bf.getBean("testBean1"); assertThat(bean.getTestBeanMap()).hasSize(1); - assertThat(bean.getTestBeanMap().keySet().contains("testBean1")).isTrue(); - assertThat(bean.getTestBeanMap().values().contains(tb)).isTrue(); + assertThat(bean.getTestBeanMap()).containsKey("testBean1"); + assertThat(bean.getTestBeanMap()).containsValue(tb); assertThat(bean.getTestBean()).isSameAs(tb); } diff --git a/spring-context/src/test/java/org/springframework/scripting/bsh/BshScriptFactoryTests.java b/spring-context/src/test/java/org/springframework/scripting/bsh/BshScriptFactoryTests.java index e265610c69d..d9ea27b5417 100644 --- a/spring-context/src/test/java/org/springframework/scripting/bsh/BshScriptFactoryTests.java +++ b/spring-context/src/test/java/org/springframework/scripting/bsh/BshScriptFactoryTests.java @@ -78,8 +78,8 @@ class BshScriptFactoryTests { String desiredMessage = "Hello World!"; assertThat(messenger.getMessage()).as("Message is incorrect").isEqualTo(desiredMessage); - assertThat(ctx.getBeansOfType(Calculator.class).values().contains(calc)).isTrue(); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Calculator.class)).containsValue(calc); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); ctx.close(); } @@ -91,7 +91,7 @@ class BshScriptFactoryTests { ConfigurableMessenger messenger = (ConfigurableMessenger) ctx.getBean("messengerWithConfig"); messenger.setMessage(null); assertThat(messenger.getMessage()).isNull(); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); ctx.close(); } @@ -103,7 +103,7 @@ class BshScriptFactoryTests { ConfigurableMessenger messenger = (ConfigurableMessenger) ctx.getBean("messengerWithConfigExtra"); messenger.setMessage(null); assertThat(messenger.getMessage()).isNull(); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); ctx.close(); assertThat(messenger.getMessage()).isNull(); @@ -117,7 +117,7 @@ class BshScriptFactoryTests { Messenger messenger = (Messenger) ctx.getBean("messengerInstance"); String desiredMessage = "Hello World!"; assertThat(messenger.getMessage()).as("Message is incorrect").isEqualTo(desiredMessage); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); ctx.close(); assertThat(messenger.getMessage()).isNull(); @@ -131,7 +131,7 @@ class BshScriptFactoryTests { Messenger messenger = (Messenger) ctx.getBean("messengerImpl"); String desiredMessage = "Hello World!"; assertThat(messenger.getMessage()).as("Message is incorrect").isEqualTo(desiredMessage); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); ctx.close(); assertThat(messenger.getMessage()).isNull(); diff --git a/spring-context/src/test/java/org/springframework/scripting/groovy/GroovyScriptFactoryTests.java b/spring-context/src/test/java/org/springframework/scripting/groovy/GroovyScriptFactoryTests.java index ffe5a19f2a0..f26f0aa9312 100644 --- a/spring-context/src/test/java/org/springframework/scripting/groovy/GroovyScriptFactoryTests.java +++ b/spring-context/src/test/java/org/springframework/scripting/groovy/GroovyScriptFactoryTests.java @@ -94,8 +94,8 @@ public class GroovyScriptFactoryTests { String desiredMessage = "Hello World!"; assertThat(messenger.getMessage()).as("Message is incorrect").isEqualTo(desiredMessage); - assertThat(ctx.getBeansOfType(Calculator.class).values().contains(calc)).isTrue(); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Calculator.class)).containsValue(calc); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); } @Test @@ -127,8 +127,8 @@ public class GroovyScriptFactoryTests { String desiredMessage = "Hello World!"; assertThat(messenger.getMessage()).as("Message is incorrect").isEqualTo(desiredMessage); - assertThat(ctx.getBeansOfType(Calculator.class).values().contains(calc)).isTrue(); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Calculator.class)).containsValue(calc); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); } @Test @@ -183,7 +183,7 @@ public class GroovyScriptFactoryTests { String desiredMessage = "Hello World!"; assertThat(messenger.getMessage()).as("Message is incorrect").isEqualTo(desiredMessage); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); } @Test @@ -198,7 +198,7 @@ public class GroovyScriptFactoryTests { String desiredMessage = "Hello World!"; assertThat(messenger.getMessage()).as("Message is incorrect").isEqualTo(desiredMessage); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); } @Test @@ -213,7 +213,7 @@ public class GroovyScriptFactoryTests { String desiredMessage = "Hello World!"; assertThat(messenger.getMessage()).as("Message is incorrect").isEqualTo(desiredMessage); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); } @Test @@ -228,7 +228,7 @@ public class GroovyScriptFactoryTests { String desiredMessage = "Hello World!"; assertThat(messenger.getMessage()).as("Message is incorrect").isEqualTo(desiredMessage); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); } @Test @@ -427,7 +427,7 @@ public class GroovyScriptFactoryTests { assertThat(messenger.getMessage()).isEqualTo("Hello World!"); assertThat(countingAspect.getCalls()).isEqualTo(1); - assertThat(ctx.getBeansOfType(Messenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(Messenger.class)).containsValue(messenger); } @Test // SPR-6268 @@ -443,7 +443,7 @@ public class GroovyScriptFactoryTests { assertThat(condition).isTrue(); assertThat(messenger.getMessage()).isEqualTo("Hello World!"); - assertThat(ctx.getBeansOfType(ConcreteMessenger.class).values().contains(messenger)).isTrue(); + assertThat(ctx.getBeansOfType(ConcreteMessenger.class)).containsValue((ConcreteMessenger) messenger); // Check that AnnotationUtils works with concrete proxied script classes assertThat(AnnotationUtils.findAnnotation(messenger.getClass(), Component.class)).isNotNull(); diff --git a/spring-web/src/test/java/org/springframework/http/converter/json/SpringHandlerInstantiatorTests.java b/spring-web/src/test/java/org/springframework/http/converter/json/SpringHandlerInstantiatorTests.java index 429cbfd1645..f5f1021369f 100644 --- a/spring-web/src/test/java/org/springframework/http/converter/json/SpringHandlerInstantiatorTests.java +++ b/spring-web/src/test/java/org/springframework/http/converter/json/SpringHandlerInstantiatorTests.java @@ -98,8 +98,8 @@ public class SpringHandlerInstantiatorTests { public void autowiredKeyDeserializer() throws IOException { String json = "{\"credentials\":{\"bob\":\"admin\"}}"; SecurityRegistry registry = this.objectMapper.readValue(json, SecurityRegistry.class); - assertThat(registry.getCredentials().keySet().contains("BOB")).isTrue(); - assertThat(registry.getCredentials().keySet().contains("bob")).isFalse(); + assertThat(registry.getCredentials()).containsKey("BOB"); + assertThat(registry.getCredentials()).doesNotContainKey("bob"); } @Test diff --git a/spring-websocket/src/test/java/org/springframework/web/socket/config/HandlersBeanDefinitionParserTests.java b/spring-websocket/src/test/java/org/springframework/web/socket/config/HandlersBeanDefinitionParserTests.java index 18c31b5d4e5..02254ccf3c6 100644 --- a/spring-websocket/src/test/java/org/springframework/web/socket/config/HandlersBeanDefinitionParserTests.java +++ b/spring-websocket/src/test/java/org/springframework/web/socket/config/HandlersBeanDefinitionParserTests.java @@ -88,7 +88,7 @@ public class HandlersBeanDefinitionParserTests { assertThat(condition2).isTrue(); SimpleUrlHandlerMapping shm = (SimpleUrlHandlerMapping) hm; - if (shm.getUrlMap().keySet().contains("/foo")) { + if (shm.getUrlMap().containsKey("/foo")) { assertThat(shm.getUrlMap()).containsOnlyKeys("/foo", "/bar"); WebSocketHttpRequestHandler handler = (WebSocketHttpRequestHandler) shm.getUrlMap().get("/foo"); assertThat(handler).isNotNull();