diff --git a/spring-aop/src/main/java/org/springframework/aop/framework/JdkDynamicAopProxy.java b/spring-aop/src/main/java/org/springframework/aop/framework/JdkDynamicAopProxy.java index 43895091f46..43223de5a2b 100644 --- a/spring-aop/src/main/java/org/springframework/aop/framework/JdkDynamicAopProxy.java +++ b/spring-aop/src/main/java/org/springframework/aop/framework/JdkDynamicAopProxy.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -154,7 +154,6 @@ final class JdkDynamicAopProxy implements AopProxy, InvocationHandler, Serializa @Override @Nullable public Object invoke(Object proxy, Method method, Object[] args) throws Throwable { - MethodInvocation invocation; Object oldProxy = null; boolean setProxyContext = false; @@ -207,7 +206,8 @@ final class JdkDynamicAopProxy implements AopProxy, InvocationHandler, Serializa } else { // We need to create a method invocation... - invocation = new ReflectiveMethodInvocation(proxy, target, method, args, targetClass, chain); + MethodInvocation invocation = + new ReflectiveMethodInvocation(proxy, target, method, args, targetClass, chain); // Proceed to the joinpoint through the interceptor chain. retVal = invocation.proceed(); } diff --git a/spring-beans/src/main/java/org/springframework/beans/TypeConverterDelegate.java b/spring-beans/src/main/java/org/springframework/beans/TypeConverterDelegate.java index 192d08060d3..38a59ba3d68 100644 --- a/spring-beans/src/main/java/org/springframework/beans/TypeConverterDelegate.java +++ b/spring-beans/src/main/java/org/springframework/beans/TypeConverterDelegate.java @@ -522,8 +522,7 @@ class TypeConverterDelegate { return original; } - int i = 0; - for (; it.hasNext(); i++) { + for (int i = 0; it.hasNext(); i++) { Object element = it.next(); String indexedPropertyName = buildIndexedPropertyName(propertyName, i); Object convertedElement = convertIfNecessary(indexedPropertyName, null, element, diff --git a/spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java b/spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java index 6763c867815..185c2fe947c 100644 --- a/spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java +++ b/spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,7 +21,6 @@ import java.util.concurrent.Callable; import java.util.function.Consumer; import java.util.function.Supplier; - import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -60,7 +59,7 @@ public class DeferredResult { @Nullable - private final Long timeout; + private final Long timeoutValue; private final Supplier timeoutResult; @@ -89,35 +88,36 @@ public class DeferredResult { *

By default not set in which case the default configured in the MVC * Java Config or the MVC namespace is used, or if that's not set, then the * timeout depends on the default of the underlying server. - * @param timeout timeout value in milliseconds + * @param timeoutValue timeout value in milliseconds */ - public DeferredResult(Long timeout) { - this(timeout, () -> RESULT_NONE); + public DeferredResult(Long timeoutValue) { + this(timeoutValue, () -> RESULT_NONE); } /** * Create a DeferredResult with a timeout value and a default result to use * in case of timeout. - * @param timeout timeout value in milliseconds (ignored if {@code null}) + * @param timeoutValue timeout value in milliseconds (ignored if {@code null}) * @param timeoutResult the result to use */ - public DeferredResult(@Nullable Long timeout, final Object timeoutResult) { + public DeferredResult(@Nullable Long timeoutValue, final Object timeoutResult) { this.timeoutResult = () -> timeoutResult; - this.timeout = timeout; + this.timeoutValue = timeoutValue; } /** * Variant of {@link #DeferredResult(Long, Object)} that accepts a dynamic * fallback value based on a {@link Supplier}. - * @param timeout timeout value in milliseconds (ignored if {@code null}) + * @param timeoutValue timeout value in milliseconds (ignored if {@code null}) * @param timeoutResult the result supplier to use * @since 5.1.1 */ - public DeferredResult(@Nullable Long timeout, Supplier timeoutResult) { + public DeferredResult(@Nullable Long timeoutValue, Supplier timeoutResult) { this.timeoutResult = timeoutResult; - this.timeout = timeout; + this.timeoutValue = timeoutValue; } + /** * Return {@code true} if this DeferredResult is no longer usable either * because it was previously set or because the underlying request expired. @@ -155,7 +155,7 @@ public class DeferredResult { */ @Nullable final Long getTimeoutValue() { - return this.timeout; + return this.timeoutValue; } /** diff --git a/spring-websocket/src/main/java/org/springframework/web/socket/sockjs/support/AbstractSockJsService.java b/spring-websocket/src/main/java/org/springframework/web/socket/sockjs/support/AbstractSockJsService.java index bb003bdebed..eb01ff72177 100644 --- a/spring-websocket/src/main/java/org/springframework/web/socket/sockjs/support/AbstractSockJsService.java +++ b/spring-websocket/src/main/java/org/springframework/web/socket/sockjs/support/AbstractSockJsService.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -354,7 +354,7 @@ public abstract class AbstractSockJsService implements SockJsService, CorsConfig String requestInfo = (logger.isDebugEnabled() ? request.getMethod() + " " + request.getURI() : null); try { - if (sockJsPath.equals("") || sockJsPath.equals("/")) { + if (sockJsPath.isEmpty() || sockJsPath.equals("/")) { if (requestInfo != null) { logger.debug("Processing transport request: " + requestInfo); }