diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanDefinition.java b/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanDefinition.java index cfa57d8436b..1109b75c06b 100644 --- a/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanDefinition.java +++ b/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanDefinition.java @@ -815,6 +815,7 @@ public abstract class AbstractBeanDefinition extends BeanMetadataAttributeAccess /** * Return if there are constructor argument values defined for this bean. */ + @Override public boolean hasConstructorArgumentValues() { return (this.constructorArgumentValues != null && !this.constructorArgumentValues.isEmpty()); } @@ -841,6 +842,7 @@ public abstract class AbstractBeanDefinition extends BeanMetadataAttributeAccess * Return if there are property values values defined for this bean. * @since 5.0.2 */ + @Override public boolean hasPropertyValues() { return (this.propertyValues != null && !this.propertyValues.isEmpty()); } diff --git a/spring-test/src/test/java/org/springframework/mock/web/MockHttpServletRequestTests.java b/spring-test/src/test/java/org/springframework/mock/web/MockHttpServletRequestTests.java index 64f7cab0c77..568b1156ec5 100644 --- a/spring-test/src/test/java/org/springframework/mock/web/MockHttpServletRequestTests.java +++ b/spring-test/src/test/java/org/springframework/mock/web/MockHttpServletRequestTests.java @@ -508,6 +508,7 @@ public class MockHttpServletRequestTests { request.getDateHeader(IF_MODIFIED_SINCE); } + private void assertEqualEnumerations(Enumeration enum1, Enumeration enum2) { assertNotNull(enum1); assertNotNull(enum2); diff --git a/spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandlerTests.java b/spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandlerTests.java index 5279cb29e28..0638b987213 100644 --- a/spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandlerTests.java +++ b/spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandlerTests.java @@ -62,8 +62,7 @@ public class ResourceHttpRequestHandlerTests { @Before - public void setUp() throws Exception { - + public void setup() throws Exception { List paths = new ArrayList<>(2); paths.add(new ClassPathResource("test/", getClass())); paths.add(new ClassPathResource("testalternatepath/", getClass())); @@ -79,6 +78,7 @@ public class ResourceHttpRequestHandlerTests { this.response = new MockHttpServletResponse(); } + @Test public void getResource() throws Exception { this.request.setAttribute(HandlerMapping.PATH_WITHIN_HANDLER_MAPPING_ATTRIBUTE, "foo.css"); @@ -598,8 +598,7 @@ public class ResourceHttpRequestHandlerTests { assertEquals("t.", ranges[11]); } - // SPR-14005 - @Test + @Test // SPR-14005 public void doOverwriteExistingCacheControlHeaders() throws Exception { this.request.setAttribute(HandlerMapping.PATH_WITHIN_HANDLER_MAPPING_ATTRIBUTE, "foo.css"); this.response.setHeader("Cache-Control", "no-store");