root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid multiple warnings related to jackson-module-kotlin 

Issue: SPR-16497
This commit is contained in:
Juergen Hoeller 2018-02-14 21:19:57 +01:00
parent 1aeae5d40d
commit 7baf33fea0
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
spring-web/src/main/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.java
View File

@ -98,6 +98,8 @@ import org.springframework.util.xml.StaxUtils;
*/ */
public class Jackson2ObjectMapperBuilder { public class Jackson2ObjectMapperBuilder {
private static volatile boolean kotlinWarningLogged = false;
private final Log logger = LogFactory.getLog(getClass()); private final Log logger = LogFactory.getLog(getClass());
private final Map<Class<?>, Class<?>> mixIns = new HashMap<>(); private final Map<Class<?>, Class<?>> mixIns = new HashMap<>();
@ -543,7 +545,7 @@ public class Jackson2ObjectMapperBuilder {
/** /**
* Set whether to let Jackson find available modules via the JDK ServiceLoader, * Set whether to let Jackson find available modules via the JDK ServiceLoader,
* based on META-INF metadata in the classpath. Requires Jackson 2.2 or higher. * based on META-INF metadata in the classpath.
* <p>If this mode is not set, Spring's Jackson2ObjectMapperBuilder itself * <p>If this mode is not set, Spring's Jackson2ObjectMapperBuilder itself
* will try to find the JSR-310 and Joda-Time support modules on the classpath - * will try to find the JSR-310 and Joda-Time support modules on the classpath -
* provided that Java 8 and Joda-Time themselves are available, respectively. * provided that Java 8 and Joda-Time themselves are available, respectively.
@ -616,7 +618,6 @@ public class Jackson2ObjectMapperBuilder {
Assert.notNull(objectMapper, "ObjectMapper must not be null"); Assert.notNull(objectMapper, "ObjectMapper must not be null");
if (this.findModulesViaServiceLoader) { if (this.findModulesViaServiceLoader) {
// Jackson 2.2+
objectMapper.registerModules(ObjectMapper.findModules(this.moduleClassLoader)); objectMapper.registerModules(ObjectMapper.findModules(this.moduleClassLoader));
} }
else if (this.findWellKnownModules) { else if (this.findWellKnownModules) {
@ -624,10 +625,7 @@ public class Jackson2ObjectMapperBuilder {
} }
if (this.modules != null) { if (this.modules != null) {
for (Module module : this.modules) { objectMapper.registerModules(this.modules);
// Using Jackson 2.0+ registerModule method, not Jackson 2.2+ registerModules
objectMapper.registerModule(module);
}
} }
if (this.moduleClasses != null) { if (this.moduleClasses != null) {
for (Class<? extends Module> module : this.moduleClasses) { for (Class<? extends Module> module : this.moduleClasses) {
@ -770,13 +768,15 @@ public class Jackson2ObjectMapperBuilder {
if (KotlinDetector.isKotlinPresent()) { if (KotlinDetector.isKotlinPresent()) {
try { try {
Class<? extends Module> kotlinModule = (Class<? extends Module>) Class<? extends Module> kotlinModule = (Class<? extends Module>)
ClassUtils.forName("com.fasterxml.jackson.module.kotlin.KotlinModule", ClassUtils.forName("com.fasterxml.jackson.module.kotlin.KotlinModule", this.moduleClassLoader);
this.moduleClassLoader);
objectMapper.registerModule(BeanUtils.instantiateClass(kotlinModule)); objectMapper.registerModule(BeanUtils.instantiateClass(kotlinModule));
} }
catch (ClassNotFoundException ex) { catch (ClassNotFoundException ex) {
logger.warn("For Jackson Kotlin classes support please add " + if (!kotlinWarningLogged) {
"\"com.fasterxml.jackson.module:jackson-module-kotlin\" to the classpath"); kotlinWarningLogged = true;
logger.warn("For Jackson Kotlin classes support please add " +
"\"com.fasterxml.jackson.module:jackson-module-kotlin\" to the classpath");
}
} }
} }
} }