diff --git a/spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/MessagingRSocket.java b/spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/MessagingRSocket.java index 32e4787c02d..8d80a424067 100644 --- a/spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/MessagingRSocket.java +++ b/spring-messaging/src/main/java/org/springframework/messaging/rsocket/annotation/support/MessagingRSocket.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -174,7 +174,7 @@ class MessagingRSocket extends AbstractRSocket { .doFinally(s -> { // Subscription should have happened by now due to ChannelSendOperator if (!read.get()) { - buffers.subscribe(DataBufferUtils::release); + firstPayload.release(); } }) .thenMany(Flux.defer(() -> replyMono.isTerminated() ? diff --git a/spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketBufferLeakTests.java b/spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketBufferLeakTests.java index 94451b2f3db..f9ad8b4b19f 100644 --- a/spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketBufferLeakTests.java +++ b/spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketBufferLeakTests.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2019 the original author or authors. + * Copyright 2002-2020 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -27,6 +27,7 @@ import io.rsocket.AbstractRSocket; import io.rsocket.RSocket; import io.rsocket.RSocketFactory; import io.rsocket.SocketAcceptor; +import io.rsocket.exceptions.ApplicationErrorException; import io.rsocket.frame.decoder.PayloadDecoder; import io.rsocket.plugins.RSocketInterceptor; import io.rsocket.transport.netty.server.CloseableChannel; @@ -149,6 +150,13 @@ class RSocketBufferLeakTests { StepVerifier.create(result).expectNext("bar").thenCancel().verify(Duration.ofSeconds(5)); } + @Test // gh-24741 + void noSuchRouteOnChannelInteraction() { + Flux input = Flux.just("foo", "bar", "baz"); + Flux result = requester.route("no-such-route").data(input).retrieveFlux(String.class); + StepVerifier.create(result).expectError(ApplicationErrorException.class).verify(Duration.ofSeconds(5)); + } + @Controller static class ServerController {