root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Introduce logging for ContextCustomizer[Factory] to improve diagnostics 

Prior to this commit, we logged which default TestExecutionListeners
were discovered and which listeners were used, but we did not log
anything for ContextCustomizerFactory and ContextCustomizer.

This commit therefore introduces similar logging for
ContextCustomizerFactory and ContextCustomizer to improve diagnostics.

Closes gh-29036
This commit is contained in:
Sam Brannen 2022-08-28 16:08:38 +02:00
parent aa7ef79478
commit 7f88f315a4
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
spring-test/src/main/java/org/springframework/test/context/support/AbstractTestContextBootstrapper.java
View File

@ -202,13 +202,10 @@ public abstract class AbstractTestContextBootstrapper implements TestContextBoot
protected List<TestExecutionListener> getDefaultTestExecutionListeners() {
List<TestExecutionListener> listeners = SpringFactoriesLoader.forDefaultResourceLocation()
.load(TestExecutionListener.class, this::handleListenerInstantiationFailure);
if (logger.isInfoEnabled()) {
List<String> classNames = listeners.stream().map(Object::getClass).map(Class::getName).toList();
logger.info("Loaded default TestExecutionListener implementations from location [%s]: %s"
.formatted(SpringFactoriesLoader.FACTORIES_RESOURCE_LOCATION, classNames));
if (logger.isDebugEnabled()) {
logger.debug("Loaded default TestExecutionListener implementations from location [%s]: %s"
.formatted(SpringFactoriesLoader.FACTORIES_RESOURCE_LOCATION, classNames(listeners)));
}
return Collections.unmodifiableList(listeners);
}
@ -426,6 +423,9 @@ public abstract class AbstractTestContextBootstrapper implements TestContextBoot
customizers.add(customizer);
}
}
if (logger.isInfoEnabled()) {
logger.info("Using ContextCustomizers: " + customizers);
}
return customizers;
}
@ -438,7 +438,13 @@ public abstract class AbstractTestContextBootstrapper implements TestContextBoot
* @see SpringFactoriesLoader#loadFactories
*/
protected List<ContextCustomizerFactory> getContextCustomizerFactories() {
return SpringFactoriesLoader.loadFactories(ContextCustomizerFactory.class, getClass().getClassLoader());
List<ContextCustomizerFactory> factories =
SpringFactoriesLoader.loadFactories(ContextCustomizerFactory.class, getClass().getClassLoader());
if (logger.isDebugEnabled()) {
logger.debug("Loaded ContextCustomizerFactory implementations from location [%s]: %s"
.formatted(SpringFactoriesLoader.FACTORIES_RESOURCE_LOCATION, classNames(factories)));
}
return factories;
}
/**
@ -562,6 +568,10 @@ public abstract class AbstractTestContextBootstrapper implements TestContextBoot
}
private static List<String> classNames(List<?> components) {
return components.stream().map(Object::getClass).map(Class::getName).toList();
}
private static boolean areAllEmpty(Collection<?>... collections) {
return Arrays.stream(collections).allMatch(Collection::isEmpty);
}