Ignore 'value' attribute in AnnotationTypeMapping

Update `addConventionAnnotationValues` so that `value` attributes
do not override existing annotation values. The aligns the new
`MergedAnnotations` API with the previous `AnnotatedElementUtils`
logic.

Closes gh-22703
This commit is contained in:
Phillip Webb 2019-03-28 13:44:35 -07:00
parent 45e42214b2
commit 800cbf2524
3 changed files with 80 additions and 2 deletions

View File

@ -272,11 +272,11 @@ final class AnnotationTypeMapping {
private void addConventionAnnotationValues() { private void addConventionAnnotationValues() {
for (int i = 0; i < this.attributes.size(); i++) { for (int i = 0; i < this.attributes.size(); i++) {
Method attribute = this.attributes.get(i); Method attribute = this.attributes.get(i);
boolean isValueAttribute = MergedAnnotation.VALUE.equals(attribute.getName());
AnnotationTypeMapping mapping = this; AnnotationTypeMapping mapping = this;
while (mapping != null && mapping.depth > 0) { while (mapping != null && mapping.depth > 0) {
int mapped = mapping.getAttributes().indexOf(attribute.getName()); int mapped = mapping.getAttributes().indexOf(attribute.getName());
if (mapped != -1 && (this.annotationValueMappings[i] == -1 || if (mapped != -1 && isBetterConventionAnnotationValue(i, isValueAttribute, mapping)) {
this.annotationValueSource[i].depth > mapping.depth)) {
this.annotationValueMappings[i] = mapped; this.annotationValueMappings[i] = mapped;
this.annotationValueSource[i] = mapping; this.annotationValueSource[i] = mapping;
} }
@ -285,6 +285,15 @@ final class AnnotationTypeMapping {
} }
} }
private boolean isBetterConventionAnnotationValue(int index, boolean isValueAttribute,
AnnotationTypeMapping mapping) {
if (this.annotationValueMappings[index] == -1) {
return true;
}
int existingDepth = this.annotationValueSource[index].depth;
return !isValueAttribute && existingDepth > mapping.depth;
}
/** /**
* Method called after all mappings have been set. At this point no further * Method called after all mappings have been set. At this point no further
* lookups from child mappings will occur. * lookups from child mappings will occur.

View File

@ -822,6 +822,14 @@ public class AnnotatedElementUtilsTests {
assertThat(element.getDeclaredAnnotations()).isNotSameAs(element.getDeclaredAnnotations()); assertThat(element.getDeclaredAnnotations()).isNotSameAs(element.getDeclaredAnnotations());
} }
@Test // gh-22703
public void getMergedAnnotationOnThreeDeepMetaWithValue() {
ValueAttribute annotation = AnnotatedElementUtils.getMergedAnnotation(
ValueAttributeMetaMetaClass.class, ValueAttribute.class);
assertThat(annotation.value()).containsExactly("FromValueAttributeMeta");
}
// ------------------------------------------------------------------------- // -------------------------------------------------------------------------
@MetaCycle3 @MetaCycle3
@ -1394,4 +1402,32 @@ public class AnnotatedElementUtilsTests {
class ForAnnotationsClass { class ForAnnotationsClass {
} }
@Retention(RetentionPolicy.RUNTIME)
static @interface ValueAttribute {
String[] value();
}
@Retention(RetentionPolicy.RUNTIME)
@ValueAttribute("FromValueAttributeMeta")
static @interface ValueAttributeMeta {
@AliasFor("alias")
String[] value() default {};
@AliasFor("value")
String[] alias() default {};
}
@Retention(RetentionPolicy.RUNTIME)
@ValueAttributeMeta("FromValueAttributeMetaMeta")
static @interface ValueAttributeMetaMeta {
}
@ValueAttributeMetaMeta
static class ValueAttributeMetaMetaClass {
}
} }

View File

@ -2045,6 +2045,14 @@ public class MergedAnnotationsTests {
assertThat(annotation.getString("value")).isEqualTo("meta"); assertThat(annotation.getString("value")).isEqualTo("meta");
} }
@Test // gh-22703
public void getValueWhenThreeDeepMetaWithValue() {
MergedAnnotation<?> annotation = MergedAnnotations.from(
ValueAttributeMetaMetaClass.class).get(ValueAttribute.class);
assertThat(annotation.getStringArray(MergedAnnotation.VALUE)).containsExactly(
"FromValueAttributeMeta");
}
// @formatter:off // @formatter:off
@Retention(RetentionPolicy.RUNTIME) @Retention(RetentionPolicy.RUNTIME)
@ -3430,6 +3438,31 @@ public class MergedAnnotationsTests {
} }
@Retention(RetentionPolicy.RUNTIME)
static @interface ValueAttribute {
String[] value();
}
@Retention(RetentionPolicy.RUNTIME)
@ValueAttribute("FromValueAttributeMeta")
static @interface ValueAttributeMeta {
String[] value() default {};
}
@Retention(RetentionPolicy.RUNTIME)
@ValueAttributeMeta("FromValueAttributeMetaMeta")
static @interface ValueAttributeMetaMeta {
}
@ValueAttributeMetaMeta
static class ValueAttributeMetaMetaClass {
}
// @formatter:on // @formatter:on
} }