root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Fix NPE when calling NettyHeadersAdapter.add() 

Prior to this commit, the `NettyHeadersAdapter` would directly delegate
the `add()` and `set()` calls to the adapted
`io.netty.handler.codec.http.HttpHeaders`. This implementation rejects
`null` values with exceptions.

This commit aligns the behavior here with other implementations, by not
rejecting null values but simply ignoring them.

Fixes gh-26274
This commit is contained in:
Brian Clozel 2020-12-15 13:23:53 +01:00
parent bcfbde9848
commit 83c19cd60e
3 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spring-web/src/main/java/org/springframework/http/client/reactive/NettyHeadersAdapter.java
View File

@ -56,7 +56,9 @@ class NettyHeadersAdapter implements MultiValueMap<String, String> {
@Override @Override
public void add(String key, @Nullable String value) { public void add(String key, @Nullable String value) {
this.headers.add(key, value); if (value != null) {
this.headers.add(key, value);
}
} }
@Override @Override
@ -71,7 +73,9 @@ class NettyHeadersAdapter implements MultiValueMap<String, String> {
@Override @Override
public void set(String key, @Nullable String value) { public void set(String key, @Nullable String value) {
this.headers.set(key, value); if (value != null) {
this.headers.set(key, value);
}
} }
@Override @Override

8
spring-web/src/main/java/org/springframework/http/server/reactive/NettyHeadersAdapter.java
View File

@ -56,7 +56,9 @@ class NettyHeadersAdapter implements MultiValueMap<String, String> {
@Override @Override
public void add(String key, @Nullable String value) { public void add(String key, @Nullable String value) {
this.headers.add(key, value); if (value != null) {
this.headers.add(key, value);
}
} }
@Override @Override
@ -71,7 +73,9 @@ class NettyHeadersAdapter implements MultiValueMap<String, String> {
@Override @Override
public void set(String key, @Nullable String value) { public void set(String key, @Nullable String value) {
this.headers.set(key, value); if (value != null) {
this.headers.set(key, value);
}
} }
@Override @Override

8
spring-web/src/test/java/org/springframework/http/server/reactive/HeadersAdaptersTests.java
View File

@ -94,6 +94,14 @@ class HeadersAdaptersTests {
assertThat(headers.get("TestHeader").size()).isEqualTo(1); assertThat(headers.get("TestHeader").size()).isEqualTo(1);
} }
@ParameterizedHeadersTest
void nullValuesShouldNotFail(String displayName, MultiValueMap<String, String> headers) {
headers.add("TestHeader", null);
assertThat(headers.getFirst("TestHeader")).isNull();
headers.set("TestHeader", null);
assertThat(headers.getFirst("TestHeader")).isNull();
}
@Retention(RetentionPolicy.RUNTIME) @Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.METHOD) @Target(ElementType.METHOD)
@ParameterizedTest(name = "[{index}] {0}") @ParameterizedTest(name = "[{index}] {0}")