root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Assign Jetty SockJS tests to "performance" test group 

This change designates Jetty SockJS integration tests to run as part of
the "performance", but not the main "publication", CI build due to
recurring low-level failures suspected to be Jetty issues, e.g.
"java.io.IOException: Cannot append to finished buffer" or
"java.io.IOException: Out of order Continuation frame encountered".

The tests will still run at once a day with the performance build but
should not fail the main build with false negatives. Also note that
an Undertow variant of the exact same tests, which hasn't been failing,
will continue to run as part of the main build.
This commit is contained in:
Rossen Stoyanchev 2015-01-06 09:43:54 -05:00
parent bce145c06e
commit 8a47c181f7
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spring-websocket/src/test/java/org/springframework/web/socket/sockjs/client/JettySockJsIntegrationTests.java
View File

@ -17,9 +17,11 @@
package org.springframework.web.socket.sockjs.client; package org.springframework.web.socket.sockjs.client;
import org.eclipse.jetty.client.HttpClient; import org.eclipse.jetty.client.HttpClient;
import org.junit.BeforeClass;
import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration; import org.springframework.context.annotation.Configuration;
import org.springframework.tests.Assume;
import org.springframework.tests.TestGroup;
import org.springframework.web.socket.JettyWebSocketTestServer; import org.springframework.web.socket.JettyWebSocketTestServer;
import org.springframework.web.socket.client.jetty.JettyWebSocketClient; import org.springframework.web.socket.client.jetty.JettyWebSocketClient;
import org.springframework.web.socket.server.RequestUpgradeStrategy; import org.springframework.web.socket.server.RequestUpgradeStrategy;
@ -32,6 +34,10 @@ import org.springframework.web.socket.server.jetty.JettyRequestUpgradeStrategy;
*/ */
public class JettySockJsIntegrationTests extends AbstractSockJsIntegrationTests { public class JettySockJsIntegrationTests extends AbstractSockJsIntegrationTests {
@BeforeClass
public static void setUpOnce() throws Exception {
Assume.group(TestGroup.PERFORMANCE);
}
@Override @Override
protected Class<?> upgradeStrategyConfigClass() { protected Class<?> upgradeStrategyConfigClass() {