From 91f6123167ff888feb8fd61d94ca5a3a453a4efd Mon Sep 17 00:00:00 2001 From: Phillip Webb Date: Wed, 24 Oct 2012 10:39:11 -0700 Subject: [PATCH] Support SQL exception translation for ORA-06550 Oracle error ORA-06550 will now raise a BadSqlGrammarException. Issue: SPR-9853 --- .../org/springframework/jdbc/support/sql-error-codes.xml | 2 +- .../jdbc/support/SQLErrorCodesFactoryTests.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/spring-jdbc/src/main/resources/org/springframework/jdbc/support/sql-error-codes.xml b/spring-jdbc/src/main/resources/org/springframework/jdbc/support/sql-error-codes.xml index a6a0f5c8363..dd3b4b0b55e 100644 --- a/spring-jdbc/src/main/resources/org/springframework/jdbc/support/sql-error-codes.xml +++ b/spring-jdbc/src/main/resources/org/springframework/jdbc/support/sql-error-codes.xml @@ -166,7 +166,7 @@ - 900,903,904,917,936,942,17006 + 900,903,904,917,936,942,17006,6550 17003 diff --git a/spring-jdbc/src/test/java/org/springframework/jdbc/support/SQLErrorCodesFactoryTests.java b/spring-jdbc/src/test/java/org/springframework/jdbc/support/SQLErrorCodesFactoryTests.java index bcdbdf65051..f2d5debc4fe 100644 --- a/spring-jdbc/src/test/java/org/springframework/jdbc/support/SQLErrorCodesFactoryTests.java +++ b/spring-jdbc/src/test/java/org/springframework/jdbc/support/SQLErrorCodesFactoryTests.java @@ -57,8 +57,9 @@ public class SQLErrorCodesFactoryTests extends TestCase { private void assertIsOracle(SQLErrorCodes sec) { assertTrue(sec.getBadSqlGrammarCodes().length > 0); assertTrue(sec.getDataIntegrityViolationCodes().length > 0); - // This had better be a Bad SQL Grammar code + // These had better be a Bad SQL Grammar code assertTrue(Arrays.binarySearch(sec.getBadSqlGrammarCodes(), "942") >= 0); + assertTrue(Arrays.binarySearch(sec.getBadSqlGrammarCodes(), "6550") >= 0); // This had better NOT be assertFalse(Arrays.binarySearch(sec.getBadSqlGrammarCodes(), "9xx42") >= 0); }