root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Consistently log exceptions from TestExecutionListeners at WARN level 

Prior to this commit, the TestContextManager logged an exception from a
TestExecutionListener at WARN level except in prepareTestInstance()
where such an exception was logged at ERROR level (except for a skipped
exception which is logged at INFO level).

For consistency, this commit modifies TestContextManager so that it
always logs non-skipped exceptions from TestExecutionListeners at WARN
level.

Closes gh-31688
This commit is contained in:
Sam Brannen 2023-11-26 12:44:06 +01:00
parent b17f3bc07b
commit 97264c77dd
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spring-test/src/main/java/org/springframework/test/context/TestContextManager.java
View File

@ -268,8 +268,8 @@ public class TestContextManager {
.formatted(typeName(testExecutionListener), testInstance), ex); .formatted(typeName(testExecutionListener), testInstance), ex);
} }
} }
else if (logger.isErrorEnabled()) { else if (logger.isWarnEnabled()) {
logger.error(""" logger.warn("""
Caught exception while allowing TestExecutionListener [%s] to \ Caught exception while allowing TestExecutionListener [%s] to \
prepare test instance [%s]""" prepare test instance [%s]"""
.formatted(typeName(testExecutionListener), testInstance), ex); .formatted(typeName(testExecutionListener), testInstance), ex);