From 9a5c4cab7204cf0e8de4714ca2ac15dea6aaa1da Mon Sep 17 00:00:00 2001 From: Keith Donald Date: Mon, 8 Jun 2009 20:42:09 +0000 Subject: [PATCH] polish --- .../java/org/springframework/ui/message/MessageContext.java | 6 +++--- .../ui/message/support/DefaultMessageContext.java | 2 +- .../ui/message/support/DefaultMessageContextTests.java | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/org.springframework.context/src/main/java/org/springframework/ui/message/MessageContext.java b/org.springframework.context/src/main/java/org/springframework/ui/message/MessageContext.java index 554e6fdf5b3..f53d7bd90f1 100644 --- a/org.springframework.context/src/main/java/org/springframework/ui/message/MessageContext.java +++ b/org.springframework.context/src/main/java/org/springframework/ui/message/MessageContext.java @@ -38,10 +38,10 @@ public interface MessageContext { public List getMessages(String element); /** - * Add a new message to this context. + * Add a new message to an element. + * @param message the resolver that will resolve the message to be added; typically constructed by a {@link MessageBuilder}. * @param element the id of the UI element the message should be associated with - * @param messageResolver the resolver that will resolve the message to be added */ - public void addMessage(String element, MessageResolver messageResolver); + public void add(MessageResolver message, String element); } diff --git a/org.springframework.context/src/main/java/org/springframework/ui/message/support/DefaultMessageContext.java b/org.springframework.context/src/main/java/org/springframework/ui/message/support/DefaultMessageContext.java index dea0def44f0..75f7b19bf62 100644 --- a/org.springframework.context/src/main/java/org/springframework/ui/message/support/DefaultMessageContext.java +++ b/org.springframework.context/src/main/java/org/springframework/ui/message/support/DefaultMessageContext.java @@ -91,7 +91,7 @@ public class DefaultMessageContext implements MessageContext { return Collections.unmodifiableList(messages); } - public void addMessage(String element, MessageResolver messageResolver) { + public void add(MessageResolver messageResolver, String element) { List messages = messagesByElement.get(element); messages.add(new ResolvableMessage(messageResolver)); } diff --git a/org.springframework.context/src/test/java/org/springframework/ui/message/support/DefaultMessageContextTests.java b/org.springframework.context/src/test/java/org/springframework/ui/message/support/DefaultMessageContextTests.java index ef9d9eeaa27..f795274c18e 100644 --- a/org.springframework.context/src/test/java/org/springframework/ui/message/support/DefaultMessageContextTests.java +++ b/org.springframework.context/src/test/java/org/springframework/ui/message/support/DefaultMessageContextTests.java @@ -39,7 +39,7 @@ public class DefaultMessageContextTests { MessageBuilder builder = new MessageBuilder(); MessageResolver message = builder.severity(Severity.ERROR).code("invalidFormat").resolvableArg( "mathForm.decimalField").arg("#,###.##").defaultText("Field must be in format #,###.##").build(); - context.addMessage("mathForm.decimalField", message); + context.add(message, "mathForm.decimalField"); Map> messages = context.getMessages(); assertEquals(1, messages.size()); assertEquals("Decimal Field must be in format #,###.##", messages.get("mathForm.decimalField").get(0).getText());