root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Defensive singleton check for non-registered bean 

Closes gh-33286
This commit is contained in:
Juergen Hoeller 2024-07-29 10:47:08 +02:00
parent 5aa38833dd
commit 9d9e621efe
2 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
spring-context/src/main/java/org/springframework/scheduling/annotation/ScheduledAnnotationBeanPostProcessor.java
View File

@ -308,8 +308,9 @@ public class ScheduledAnnotationBeanPostProcessor
logger.trace(annotatedMethods.size() + " @Scheduled methods processed on bean '" + beanName + logger.trace(annotatedMethods.size() + " @Scheduled methods processed on bean '" + beanName +
"': " + annotatedMethods); "': " + annotatedMethods);
} }
if ((this.beanFactory != null && !this.beanFactory.isSingleton(beanName)) || if ((this.beanFactory != null &&
(this.beanFactory instanceof SingletonBeanRegistry sbr && sbr.containsSingleton(beanName))) { (!this.beanFactory.containsBean(beanName) || !this.beanFactory.isSingleton(beanName)) ||
(this.beanFactory instanceof SingletonBeanRegistry sbr && sbr.containsSingleton(beanName)))) {
// Either a prototype/scoped bean or a FactoryBean with a pre-existing managed singleton // Either a prototype/scoped bean or a FactoryBean with a pre-existing managed singleton
// -> trigger manual cancellation when ContextClosedEvent comes in // -> trigger manual cancellation when ContextClosedEvent comes in
this.manualCancellationOnContextClose.add(bean); this.manualCancellationOnContextClose.add(bean);

19
spring-context/src/test/java/org/springframework/scheduling/annotation/ScheduledAnnotationBeanPostProcessorTests.java
View File

@ -30,6 +30,7 @@ import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Properties; import java.util.Properties;
import java.util.Set;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.AfterEach;
@ -294,6 +295,24 @@ class ScheduledAnnotationBeanPostProcessorTests {
assertThat(task.getInitialDelayDuration()).isEqualTo(Duration.ofMillis(2_000L)); assertThat(task.getInitialDelayDuration()).isEqualTo(Duration.ofMillis(2_000L));
} }
@Test
void oneTimeTaskOnNonRegisteredBean() {
BeanDefinition processorDefinition = new RootBeanDefinition(ScheduledAnnotationBeanPostProcessor.class);
context.registerBeanDefinition("postProcessor", processorDefinition);
context.refresh();
ScheduledTaskHolder postProcessor = context.getBean("postProcessor", ScheduledTaskHolder.class);
assertThat(postProcessor.getScheduledTasks()).hasSize(0);
Object target = context.getAutowireCapableBeanFactory().createBean(OneTimeTaskBean.class);
assertThat(postProcessor.getScheduledTasks()).hasSize(1);
@SuppressWarnings("unchecked")
Set<Object> manualTasks = (Set<Object>)
new DirectFieldAccessor(postProcessor).getPropertyValue("manualCancellationOnContextClose");
assertThat(manualTasks).hasSize(1);
assertThat(manualTasks).contains(target);
}
@Test @Test
void cronTask() { void cronTask() {
BeanDefinition processorDefinition = new RootBeanDefinition(ScheduledAnnotationBeanPostProcessor.class); BeanDefinition processorDefinition = new RootBeanDefinition(ScheduledAnnotationBeanPostProcessor.class);