revised TypedValue toString representation (SPR-7569)

This commit is contained in:
Juergen Hoeller 2010-10-10 21:29:18 +00:00
parent f7cd9865f4
commit a0fead1880
2 changed files with 7 additions and 7 deletions

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2009 the original author or authors. * Copyright 2002-2010 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -20,10 +20,11 @@ import org.springframework.core.convert.TypeDescriptor;
/** /**
* Encapsulates an object and a type descriptor that describes it. * Encapsulates an object and a type descriptor that describes it.
* The type descriptor can hold generic information that would * The type descriptor can hold generic information that would not be
* not be accessible through a simple getClass() call on the object. * accessible through a simple <code>getClass()</code> call on the object.
* *
* @author Andy Clement * @author Andy Clement
* @author Juergen Hoeller
* @since 3.0 * @since 3.0
*/ */
public class TypedValue { public class TypedValue {
@ -72,7 +73,7 @@ public class TypedValue {
@Override @Override
public String toString() { public String toString() {
StringBuilder str = new StringBuilder(); StringBuilder str = new StringBuilder();
str.append("TypedValue: ").append(this.value).append(" of ").append(this.getTypeDescriptor()); str.append("TypedValue: '").append(this.value).append("' of [").append(getTypeDescriptor() + "]");
return str.toString(); return str.toString();
} }

View File

@ -25,6 +25,7 @@ import java.util.List;
import junit.framework.Assert; import junit.framework.Assert;
import org.junit.Test; import org.junit.Test;
import org.springframework.core.convert.TypeDescriptor;
import org.springframework.expression.EvaluationContext; import org.springframework.expression.EvaluationContext;
import org.springframework.expression.ParseException; import org.springframework.expression.ParseException;
import org.springframework.expression.PropertyAccessor; import org.springframework.expression.PropertyAccessor;
@ -36,8 +37,6 @@ import org.springframework.expression.spel.SpelUtilities;
import org.springframework.expression.spel.ast.FormatHelper; import org.springframework.expression.spel.ast.FormatHelper;
import org.springframework.expression.spel.standard.SpelExpression; import org.springframework.expression.spel.standard.SpelExpression;
import org.springframework.expression.spel.support.ReflectionHelper.ArgsMatchKind; import org.springframework.expression.spel.support.ReflectionHelper.ArgsMatchKind;
import org.springframework.core.convert.TypeDescriptor;
import org.springframework.core.MethodParameter;
/** /**
* Tests for any helper code. * Tests for any helper code.
@ -99,7 +98,7 @@ public class ReflectionHelperTests extends ExpressionTestCase {
public void testTypedValue() { public void testTypedValue() {
TypedValue tValue = new TypedValue("hello"); TypedValue tValue = new TypedValue("hello");
Assert.assertEquals(String.class,tValue.getTypeDescriptor().getType()); Assert.assertEquals(String.class,tValue.getTypeDescriptor().getType());
Assert.assertEquals("TypedValue: hello of [TypeDescriptor java.lang.String]",tValue.toString()); Assert.assertEquals("TypedValue: 'hello' of [java.lang.String]",tValue.toString());
} }
@Test @Test