root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Filter non-existing static resource locations 

See gh-27538
This commit is contained in:
Rossen Stoyanchev 2021-10-12 11:59:39 +01:00
parent 5bd90538b3
commit a2c52a97ba
2 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandler.java
View File

@ -25,6 +25,7 @@ import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Locale; import java.util.Locale;
import java.util.Map; import java.util.Map;
import java.util.stream.Collectors;
import javax.servlet.ServletException; import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletRequest;
@ -424,6 +425,7 @@ public class ResourceHttpRequestHandler extends WebContentGenerator
} }
private void resolveResourceLocations() { private void resolveResourceLocations() {
List<Resource> result = new ArrayList<>();
if (!this.locationValues.isEmpty()) { if (!this.locationValues.isEmpty()) {
ApplicationContext applicationContext = obtainApplicationContext(); ApplicationContext applicationContext = obtainApplicationContext();
for (String location : this.locationValues) { for (String location : this.locationValues) {
@ -452,7 +454,7 @@ public class ResourceHttpRequestHandler extends WebContentGenerator
"but resolved to a Resource of type: " + resource.getClass() + ". " + "but resolved to a Resource of type: " + resource.getClass() + ". " +
"If this is intentional, please pass it as a pre-configured Resource via setLocations."); "If this is intentional, please pass it as a pre-configured Resource via setLocations.");
} }
this.locationsToUse.add(resource); result.add(resource);
if (charset != null) { if (charset != null) {
if (!(resource instanceof UrlResource)) { if (!(resource instanceof UrlResource)) {
throw new IllegalArgumentException("Unexpected charset for non-UrlResource: " + resource); throw new IllegalArgumentException("Unexpected charset for non-UrlResource: " + resource);
@ -461,7 +463,11 @@ public class ResourceHttpRequestHandler extends WebContentGenerator
} }
} }
} }
this.locationsToUse.addAll(this.locationResources);
result.addAll(this.locationResources);
result = result.stream().filter(Resource::exists).collect(Collectors.toList());
this.locationsToUse.addAll(result);
} }
/** /**

20
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandlerTests.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2020 the original author or authors. * Copyright 2002-2021 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -312,6 +312,24 @@ public class ResourceHttpRequestHandlerTests {
assertThat(this.response.getContentAsString()).isEqualTo("h1 { color:red; }"); assertThat(this.response.getContentAsString()).isEqualTo("h1 { color:red; }");
} }
@Test // gh-27538
public void filterNonExistingLocations() throws Exception {
List<Resource> inputLocations = Arrays.asList(
new ClassPathResource("test/", getClass()),
new ClassPathResource("testalternatepath/", getClass()),
new ClassPathResource("nosuchpath/", getClass()));
ResourceHttpRequestHandler handler = new ResourceHttpRequestHandler();
handler.setServletContext(new MockServletContext());
handler.setLocations(inputLocations);
handler.afterPropertiesSet();
List<Resource> actual = handler.getLocations();
assertThat(actual).hasSize(2);
assertThat(actual.get(0).getURL().toString()).endsWith("test/");
assertThat(actual.get(1).getURL().toString()).endsWith("testalternatepath/");
}
@Test @Test
public void testInvalidPath() throws Exception { public void testInvalidPath() throws Exception {