root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Add missing break statements to stop looping when result is known 

Closes gh-22573
This commit is contained in:
Сергей Цыпанов 2019-03-12 14:15:59 +02:00 committed by Sam Brannen
parent 96cd4411e5
commit a35adc6ea6
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
spring-beans/src/test/java/org/springframework/beans/ExtendedBeanInfoTests.java
View File

@ -754,6 +754,7 @@ public class ExtendedBeanInfoTests {
for (PropertyDescriptor pd : ebi.getPropertyDescriptors()) { for (PropertyDescriptor pd : ebi.getPropertyDescriptors()) {
if (pd.getName().equals("foo")) { if (pd.getName().equals("foo")) {
found = true; found = true;
break;
} }
} }
assertThat(found, is(true)); assertThat(found, is(true));

1
spring-context/src/main/java/org/springframework/scripting/support/StandardScriptFactory.java
View File

@ -151,6 +151,7 @@ public class StandardScriptFactory implements ScriptFactory, BeanClassLoaderAwar
if (script instanceof Class ? !requestedIfc.isAssignableFrom((Class<?>) script) : if (script instanceof Class ? !requestedIfc.isAssignableFrom((Class<?>) script) :
!requestedIfc.isInstance(script)) { !requestedIfc.isInstance(script)) {
adaptationRequired = true; adaptationRequired = true;
break;
} }
} }
if (adaptationRequired) { if (adaptationRequired) {

3
spring-core/src/test/java/org/springframework/core/io/support/PathMatchingResourcePatternResolverTests.java
View File

@ -89,7 +89,7 @@ public class PathMatchingResourcePatternResolverTests {
noCloverResources.add(resource); noCloverResources.add(resource);
} }
} }
resources = noCloverResources.toArray(new Resource[noCloverResources.size()]); resources = noCloverResources.toArray(new Resource[0]);
assertProtocolAndFilenames(resources, "file", assertProtocolAndFilenames(resources, "file",
StringUtils.concatenateStringArrays(CLASSES_IN_CORE_IO_SUPPORT, TEST_CLASSES_IN_CORE_IO_SUPPORT)); StringUtils.concatenateStringArrays(CLASSES_IN_CORE_IO_SUPPORT, TEST_CLASSES_IN_CORE_IO_SUPPORT));
} }
@ -113,6 +113,7 @@ public class PathMatchingResourcePatternResolverTests {
for (Resource resource : resources) { for (Resource resource : resources) {
if (resource.getFilename().equals("aspectj_1_5_0.dtd")) { if (resource.getFilename().equals("aspectj_1_5_0.dtd")) {
found = true; found = true;
break;
} }
} }
assertTrue("Could not find aspectj_1_5_0.dtd in the root of the aspectjweaver jar", found); assertTrue("Could not find aspectj_1_5_0.dtd in the root of the aspectjweaver jar", found);