From aa2829455b9b5a27b9dfb4cbbb11d26366ef4d0f Mon Sep 17 00:00:00 2001 From: Sam Brannen <104798+sbrannen@users.noreply.github.com> Date: Sat, 13 Jul 2024 17:26:26 +0200 Subject: [PATCH] Expand test coverage for gh-14200 --- .../converter/DefaultConversionServiceTests.java | 14 ++++++++++++-- .../support/GenericConversionServiceTests.java | 4 ++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/spring-core/src/test/java/org/springframework/core/convert/converter/DefaultConversionServiceTests.java b/spring-core/src/test/java/org/springframework/core/convert/converter/DefaultConversionServiceTests.java index 6a90a8f4cf8..0dadb37c2d9 100644 --- a/spring-core/src/test/java/org/springframework/core/convert/converter/DefaultConversionServiceTests.java +++ b/spring-core/src/test/java/org/springframework/core/convert/converter/DefaultConversionServiceTests.java @@ -666,9 +666,19 @@ class DefaultConversionServiceTests { assertThat(converted).isEqualTo(new Byte[]{1, 2, 3}); } - @Test + @Test // gh-14200, SPR-9566 + void convertPrimitiveByteArrayToPrimitiveByteArray() { + byte[] byteArray = new byte[] {1, 2, 3}; + byte[] result = conversionService.convert(byteArray, byte[].class); + assertThat(result).isSameAs(byteArray); + assertThat(result).containsExactly(1, 2, 3); + } + + @Test // gh-14200, SPR-9566 void convertIntArrayToIntArray() { - int[] result = conversionService.convert(new int[] {1, 2, 3}, int[].class); + int[] intArray = new int[] {1, 2, 3}; + int[] result = conversionService.convert(intArray, int[].class); + assertThat(result).isSameAs(intArray); assertThat(result).containsExactly(1, 2, 3); } diff --git a/spring-core/src/test/java/org/springframework/core/convert/support/GenericConversionServiceTests.java b/spring-core/src/test/java/org/springframework/core/convert/support/GenericConversionServiceTests.java index 114f712e292..3faacdbfeb7 100644 --- a/spring-core/src/test/java/org/springframework/core/convert/support/GenericConversionServiceTests.java +++ b/spring-core/src/test/java/org/springframework/core/convert/support/GenericConversionServiceTests.java @@ -461,12 +461,12 @@ class GenericConversionServiceTests { assertThat(converter.getSourceTypes().stream().allMatch(td -> Integer.class.equals(td.getType()))).isTrue(); } - @Test + @Test // gh-14200, SPR-9566 void convertOptimizeArray() { - // SPR-9566 byte[] byteArray = new byte[] { 1, 2, 3 }; byte[] converted = conversionService.convert(byteArray, byte[].class); assertThat(converted).isSameAs(byteArray); + assertThat(converted).containsExactly(1, 2, 3); } @Test