Polishing
This commit is contained in:
parent
f443cf965a
commit
b04803de99
|
|
@ -1,5 +1,5 @@
|
||||||
/*
|
/*
|
||||||
* Copyright 2002-2020 the original author or authors.
|
* Copyright 2002-2023 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
|
@ -22,7 +22,7 @@ import org.springframework.lang.Nullable;
|
||||||
* Abstract the invocation of a cache operation.
|
* Abstract the invocation of a cache operation.
|
||||||
*
|
*
|
||||||
* <p>Does not provide a way to transmit checked exceptions but
|
* <p>Does not provide a way to transmit checked exceptions but
|
||||||
* provide a special exception that should be used to wrap any
|
* provides a special exception that should be used to wrap any
|
||||||
* exception that was thrown by the underlying invocation.
|
* exception that was thrown by the underlying invocation.
|
||||||
* Callers are expected to handle this issue type specifically.
|
* Callers are expected to handle this issue type specifically.
|
||||||
*
|
*
|
||||||
|
|
|
||||||
|
|
@ -70,7 +70,7 @@ public interface TaskScheduler {
|
||||||
* wrapping a cron expression
|
* wrapping a cron expression
|
||||||
* @return a {@link ScheduledFuture} representing pending completion of the task,
|
* @return a {@link ScheduledFuture} representing pending completion of the task,
|
||||||
* or {@code null} if the given Trigger object never fires (i.e. returns
|
* or {@code null} if the given Trigger object never fires (i.e. returns
|
||||||
* {@code null} from {@link Trigger#nextExecutionTime})
|
* {@code null} from {@link Trigger#nextExecution})
|
||||||
* @throws org.springframework.core.task.TaskRejectedException if the given task was not accepted
|
* @throws org.springframework.core.task.TaskRejectedException if the given task was not accepted
|
||||||
* for internal reasons (e.g. a pool overload handling policy or a pool shutdown in progress)
|
* for internal reasons (e.g. a pool overload handling policy or a pool shutdown in progress)
|
||||||
* @see org.springframework.scheduling.support.CronTrigger
|
* @see org.springframework.scheduling.support.CronTrigger
|
||||||
|
|
|
||||||
|
|
@ -159,7 +159,7 @@ final class SerializableTypeWrapper {
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Return the source of the type, or {@code null} if not known.
|
* Return the source of the type, or {@code null} if not known.
|
||||||
* <p>The default implementations returns {@code null}.
|
* <p>The default implementation returns {@code null}.
|
||||||
*/
|
*/
|
||||||
@Nullable
|
@Nullable
|
||||||
default Object getSource() {
|
default Object getSource() {
|
||||||
|
|
|
||||||
|
|
@ -1,5 +1,5 @@
|
||||||
/*
|
/*
|
||||||
* Copyright 2002-2021 the original author or authors.
|
* Copyright 2002-2023 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
|
@ -23,7 +23,6 @@ import org.junit.jupiter.api.Test;
|
||||||
import org.springframework.expression.EvaluationException;
|
import org.springframework.expression.EvaluationException;
|
||||||
import org.springframework.expression.TypeComparator;
|
import org.springframework.expression.TypeComparator;
|
||||||
import org.springframework.expression.spel.support.StandardTypeComparator;
|
import org.springframework.expression.spel.support.StandardTypeComparator;
|
||||||
import org.springframework.lang.NonNull;
|
|
||||||
|
|
||||||
import static org.assertj.core.api.Assertions.assertThat;
|
import static org.assertj.core.api.Assertions.assertThat;
|
||||||
|
|
||||||
|
|
@ -134,6 +133,7 @@ public class StandardTypeComparatorTests {
|
||||||
assertThat(comparator.compare(t2, t1)).isPositive();
|
assertThat(comparator.compare(t2, t1)).isPositive();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
static class ComparableType implements Comparable<ComparableType> {
|
static class ComparableType implements Comparable<ComparableType> {
|
||||||
|
|
||||||
private final int id;
|
private final int id;
|
||||||
|
|
@ -143,10 +143,9 @@ public class StandardTypeComparatorTests {
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public int compareTo(@NonNull ComparableType other) {
|
public int compareTo(ComparableType other) {
|
||||||
return this.id - other.id;
|
return this.id - other.id;
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -142,8 +142,7 @@ public class SimpleClientHttpRequestFactory implements ClientHttpRequestFactory
|
||||||
* {@link HttpURLConnection#setChunkedStreamingMode} methods of the underlying connection will never
|
* {@link HttpURLConnection#setChunkedStreamingMode} methods of the underlying connection will never
|
||||||
* be called.
|
* be called.
|
||||||
* @param outputStreaming if output streaming is enabled
|
* @param outputStreaming if output streaming is enabled
|
||||||
* @deprecated as of 6.1, this property is ignored with no direct replacement.
|
* @deprecated as of 6.1 requests are always streamed, as if this property is {@code true}
|
||||||
* @deprecated since 6.1 requests are always streamed, as if this property is {@code true}
|
|
||||||
*/
|
*/
|
||||||
@Deprecated(since = "6.1", forRemoval = true)
|
@Deprecated(since = "6.1", forRemoval = true)
|
||||||
public void setOutputStreaming(boolean outputStreaming) {
|
public void setOutputStreaming(boolean outputStreaming) {
|
||||||
|
|
|
||||||
|
|
@ -105,7 +105,6 @@ public class SimpleClientHttpRequestFactoryTests extends AbstractHttpRequestFact
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
@Test // SPR-13225
|
@Test // SPR-13225
|
||||||
public void headerWithNullValue() {
|
public void headerWithNullValue() {
|
||||||
HttpURLConnection urlConnection = mock();
|
HttpURLConnection urlConnection = mock();
|
||||||
|
|
@ -117,7 +116,6 @@ public class SimpleClientHttpRequestFactoryTests extends AbstractHttpRequestFact
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
private static class TestHttpURLConnection extends HttpURLConnection {
|
private static class TestHttpURLConnection extends HttpURLConnection {
|
||||||
|
|
||||||
public TestHttpURLConnection(URL uri) {
|
public TestHttpURLConnection(URL uri) {
|
||||||
|
|
|
||||||
|
|
@ -1,5 +1,5 @@
|
||||||
/*
|
/*
|
||||||
* Copyright 2002-2022 the original author or authors.
|
* Copyright 2002-2023 the original author or authors.
|
||||||
*
|
*
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
* you may not use this file except in compliance with the License.
|
* you may not use this file except in compliance with the License.
|
||||||
|
|
@ -51,7 +51,6 @@ import org.springframework.core.io.buffer.DefaultDataBufferFactory;
|
||||||
import org.springframework.http.HttpMethod;
|
import org.springframework.http.HttpMethod;
|
||||||
import org.springframework.http.HttpStatus;
|
import org.springframework.http.HttpStatus;
|
||||||
import org.springframework.http.ReactiveHttpOutputMessage;
|
import org.springframework.http.ReactiveHttpOutputMessage;
|
||||||
import org.springframework.lang.NonNull;
|
|
||||||
|
|
||||||
import static org.assertj.core.api.Assertions.assertThat;
|
import static org.assertj.core.api.Assertions.assertThat;
|
||||||
import static org.assertj.core.api.Assertions.fail;
|
import static org.assertj.core.api.Assertions.fail;
|
||||||
|
|
@ -173,7 +172,6 @@ public class ClientHttpConnectorTests {
|
||||||
.verify();
|
.verify();
|
||||||
}
|
}
|
||||||
|
|
||||||
@NonNull
|
|
||||||
private Buffer randomBody(int size) {
|
private Buffer randomBody(int size) {
|
||||||
Buffer responseBody = new Buffer();
|
Buffer responseBody = new Buffer();
|
||||||
Random rnd = new Random();
|
Random rnd = new Random();
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue