root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Polishing

This commit is contained in:
Juergen Hoeller 2018-03-28 12:06:38 +02:00
parent d1a0b8d53f
commit b2d87abcbb
6 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spring-core/src/test/java/org/springframework/util/ConcurrentReferenceHashMapTests.java
View File

@ -599,8 +599,7 @@ public class ConcurrentReferenceHashMapTests {
protected ReferenceManager createReferenceManager() {
return new ReferenceManager() {
@Override
public Reference<K, V> createReference(Entry<K, V> entry, int hash,
@Nullable Reference<K, V> next) {
public Reference<K, V> createReference(Entry<K, V> entry, int hash, @Nullable Reference<K, V> next) {
if (TestWeakConcurrentCache.this.disableTestHooks) {
return super.createReference(entry, hash, next);
}

2
spring-expression/src/test/java/org/springframework/expression/spel/SpelReproTests.java
View File

@ -236,7 +236,7 @@ public class SpelReproTests extends AbstractExpressionTests {
}
@Test
public void accessingNullPropertyViaReflection_SPR5663() throws AccessException {
public void propertyAccessOnNullTarget_SPR5663() throws AccessException {
PropertyAccessor accessor = new ReflectivePropertyAccessor();
EvaluationContext context = TestScenarioCreator.getTestEvaluationContext();
assertFalse(accessor.canRead(context, null, "abc"));

2
spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/CallMetaDataContext.java
View File

@ -276,7 +276,7 @@ public class CallMetaDataContext {
}
else {
throw new InvalidDataAccessApiUsageException(
"Return of a ResultSet from a stored procedure is not supported.");
"Return of a ResultSet from a stored procedure is not supported");
}
}
}

4
spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/CallMetaDataProviderFactory.java
View File

@ -60,8 +60,8 @@ public class CallMetaDataProviderFactory {
/**
* Create a {@link CallMetaDataProvider} based on the database meta-data
* @param dataSource used to retrieve meta-data
* Create a {@link CallMetaDataProvider} based on the database meta-data.
* @param dataSource the JDBC DataSource to use for retrieving meta-data
* @param context the class that holds configuration and meta-data
* @return instance of the CallMetaDataProvider implementation to be used
*/

18
spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/GenericCallMetaDataProvider.java
View File

@ -256,14 +256,14 @@ public class GenericCallMetaDataProvider implements CallMetaDataProvider {
/**
* Specify whether the database supports the use of catalog name in procedure calls
* Specify whether the database supports the use of catalog name in procedure calls.
*/
protected void setSupportsCatalogsInProcedureCalls(boolean supportsCatalogsInProcedureCalls) {
this.supportsCatalogsInProcedureCalls = supportsCatalogsInProcedureCalls;
}
/**
* Does the database support the use of catalog name in procedure calls
* Does the database support the use of catalog name in procedure calls?
*/
@Override
public boolean isSupportsCatalogsInProcedureCalls() {
@ -271,14 +271,14 @@ public class GenericCallMetaDataProvider implements CallMetaDataProvider {
}
/**
* Specify whether the database supports the use of schema name in procedure calls
* Specify whether the database supports the use of schema name in procedure calls.
*/
protected void setSupportsSchemasInProcedureCalls(boolean supportsSchemasInProcedureCalls) {
this.supportsSchemasInProcedureCalls = supportsSchemasInProcedureCalls;
}
/**
* Does the database support the use of schema name in procedure calls
* Does the database support the use of schema name in procedure calls?
*/
@Override
public boolean isSupportsSchemasInProcedureCalls() {
@ -286,28 +286,28 @@ public class GenericCallMetaDataProvider implements CallMetaDataProvider {
}
/**
* Specify whether the database uses upper case for identifiers
* Specify whether the database uses upper case for identifiers.
*/
protected void setStoresUpperCaseIdentifiers(boolean storesUpperCaseIdentifiers) {
this.storesUpperCaseIdentifiers = storesUpperCaseIdentifiers;
}
/**
* Does the database use upper case for identifiers
* Does the database use upper case for identifiers?
*/
protected boolean isStoresUpperCaseIdentifiers() {
return this.storesUpperCaseIdentifiers;
}
/**
* Specify whether the database uses lower case for identifiers
* Specify whether the database uses lower case for identifiers.
*/
protected void setStoresLowerCaseIdentifiers(boolean storesLowerCaseIdentifiers) {
this.storesLowerCaseIdentifiers = storesLowerCaseIdentifiers;
}
/**
* Does the database use lower case for identifiers
* Does the database use lower case for identifiers?
*/
protected boolean isStoresLowerCaseIdentifiers() {
return this.storesLowerCaseIdentifiers;
@ -315,7 +315,7 @@ public class GenericCallMetaDataProvider implements CallMetaDataProvider {
/**
* Process the procedure column meta-data
* Process the procedure column meta-data.
*/
private void processProcedureColumns(DatabaseMetaData databaseMetaData,
@Nullable String catalogName, @Nullable String schemaName, @Nullable String procedureName) {

2
spring-web/src/main/java/org/springframework/http/converter/BufferedImageHttpMessageConverter.java
View File

@ -100,7 +100,7 @@ public class BufferedImageHttpMessageConverter implements HttpMessageConverter<B
* @throws IllegalArgumentException if the given content type is not supported by the Java Image I/O API
*/
public void setDefaultContentType(@Nullable MediaType defaultContentType) {
if (defaultContentType!= null) {
if (defaultContentType != null) {
Iterator<ImageWriter> imageWriters = ImageIO.getImageWritersByMIMEType(defaultContentType.toString());
if (!imageWriters.hasNext()) {
throw new IllegalArgumentException(