Polishing

spring-core/src/test/java/org/springframework/util/ConcurrentReferenceHashMapTests.java

@@ -599,8 +599,7 @@ public class ConcurrentReferenceHashMapTests {
 		protected ReferenceManager createReferenceManager() {
 			return new ReferenceManager() {
 				@Override
-				public Reference<K, V> createReference(Entry<K, V> entry, int hash,
+				public Reference<K, V> createReference(Entry<K, V> entry, int hash, @Nullable Reference<K, V> next) {
-						@Nullable Reference<K, V> next) {
 					if (TestWeakConcurrentCache.this.disableTestHooks) {
 						return super.createReference(entry, hash, next);
 					}

spring-expression/src/test/java/org/springframework/expression/spel/SpelReproTests.java

@@ -236,7 +236,7 @@ public class SpelReproTests extends AbstractExpressionTests {
 	}
 
 	@Test
-	public void accessingNullPropertyViaReflection_SPR5663() throws AccessException {
+	public void propertyAccessOnNullTarget_SPR5663() throws AccessException {
 		PropertyAccessor accessor = new ReflectivePropertyAccessor();
 		EvaluationContext context = TestScenarioCreator.getTestEvaluationContext();
 		assertFalse(accessor.canRead(context, null, "abc"));

spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/CallMetaDataContext.java

@@ -276,7 +276,7 @@ public class CallMetaDataContext {
 			}
 			else {
 				throw new InvalidDataAccessApiUsageException(
-						"Return of a ResultSet from a stored procedure is not supported.");
+						"Return of a ResultSet from a stored procedure is not supported");
 			}
 		}
 	}

spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/CallMetaDataProviderFactory.java

@@ -60,8 +60,8 @@ public class CallMetaDataProviderFactory {
 
 
 	/**
-	 * Create a {@link CallMetaDataProvider} based on the database meta-data
+	 * Create a {@link CallMetaDataProvider} based on the database meta-data.
-	 * @param dataSource used to retrieve meta-data
+	 * @param dataSource the JDBC DataSource to use for retrieving meta-data
 	 * @param context the class that holds configuration and meta-data
 	 * @return instance of the CallMetaDataProvider implementation to be used
 	 */

spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/GenericCallMetaDataProvider.java

@@ -256,14 +256,14 @@ public class GenericCallMetaDataProvider implements CallMetaDataProvider {
 
 
 	/**
-	 * Specify whether the database supports the use of catalog name in procedure calls
+	 * Specify whether the database supports the use of catalog name in procedure calls.
 	 */
 	protected void setSupportsCatalogsInProcedureCalls(boolean supportsCatalogsInProcedureCalls) {
 		this.supportsCatalogsInProcedureCalls = supportsCatalogsInProcedureCalls;
 	}
 
 	/**
-	 * Does the database support the use of catalog name in procedure calls
+	 * Does the database support the use of catalog name in procedure calls?
 	 */
 	@Override
 	public boolean isSupportsCatalogsInProcedureCalls() {
@@ -271,14 +271,14 @@ public class GenericCallMetaDataProvider implements CallMetaDataProvider {
 	}
 
 	/**
-	 * Specify whether the database supports the use of schema name in procedure calls
+	 * Specify whether the database supports the use of schema name in procedure calls.
 	 */
 	protected void setSupportsSchemasInProcedureCalls(boolean supportsSchemasInProcedureCalls) {
 		this.supportsSchemasInProcedureCalls = supportsSchemasInProcedureCalls;
 	}
 
 	/**
-	 * Does the database support the use of schema name in procedure calls
+	 * Does the database support the use of schema name in procedure calls?
 	 */
 	@Override
 	public boolean isSupportsSchemasInProcedureCalls() {
@@ -286,28 +286,28 @@ public class GenericCallMetaDataProvider implements CallMetaDataProvider {
 	}
 
 	/**
-	 * Specify whether the database uses upper case for identifiers
+	 * Specify whether the database uses upper case for identifiers.
 	 */
 	protected void setStoresUpperCaseIdentifiers(boolean storesUpperCaseIdentifiers) {
 		this.storesUpperCaseIdentifiers = storesUpperCaseIdentifiers;
 	}
 
 	/**
-	 * Does the database use upper case for identifiers
+	 * Does the database use upper case for identifiers?
 	 */
 	protected boolean isStoresUpperCaseIdentifiers() {
 		return this.storesUpperCaseIdentifiers;
 	}
 
 	/**
-	 * Specify whether the database uses lower case for identifiers
+	 * Specify whether the database uses lower case for identifiers.
 	 */
 	protected void setStoresLowerCaseIdentifiers(boolean storesLowerCaseIdentifiers) {
 		this.storesLowerCaseIdentifiers = storesLowerCaseIdentifiers;
 	}
 
 	/**
-	 * Does the database use lower case for identifiers
+	 * Does the database use lower case for identifiers?
 	 */
 	protected boolean isStoresLowerCaseIdentifiers() {
 		return this.storesLowerCaseIdentifiers;
@@ -315,7 +315,7 @@ public class GenericCallMetaDataProvider implements CallMetaDataProvider {
 
 
 	/**
-	 * Process the procedure column meta-data
+	 * Process the procedure column meta-data.
 	 */
 	private void processProcedureColumns(DatabaseMetaData databaseMetaData,
 			@Nullable String catalogName, @Nullable String schemaName, @Nullable String procedureName) {