preserving desc context for collection/map elements

git-svn-id: https://src.springframework.org/svn/spring-framework/trunk@3263 50f2f4bb-b051-0410-bef5-90022cba6387

org.springframework.context/src/test/java/org/springframework/format/support/FormattingConversionServiceTests.java

@@ -16,18 +16,21 @@
 
 package org.springframework.format.support;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+
 import java.text.ParseException;
+import java.util.ArrayList;
 import java.util.Date;
+import java.util.List;
 import java.util.Locale;
 
 import org.joda.time.DateTime;
 import org.joda.time.LocalDate;
 import org.joda.time.format.DateTimeFormat;
 import org.junit.After;
-import static org.junit.Assert.*;
 import org.junit.Before;
 import org.junit.Test;
-
 import org.springframework.context.i18n.LocaleContextHolder;
 import org.springframework.core.convert.TypeDescriptor;
 import org.springframework.core.convert.converter.Converter;
@@ -102,6 +105,31 @@ public class FormattingConversionServiceTests {
 		assertEquals(new LocalDate(2009, 10, 31), date);
 	}
 	
+	@Test
+	public void testFormatCollectionFieldForAnnotation() throws Exception {
+		formattingService.addConverter(new Converter<Date, Long>() {
+			public Long convert(Date source) {
+				return source.getTime();
+			}
+		});
+		formattingService.addConverter(new Converter<DateTime, Date>() {
+			public Date convert(DateTime source) {
+				return source.toDate();
+			}
+		});
+		formattingService.addFormatterForFieldAnnotation(new JodaDateTimeFormatAnnotationFormatterFactory());
+		List<Date> dates = new ArrayList<Date>();
+		dates.add(new LocalDate(2009, 10, 31).toDateTimeAtCurrentTime().toDate());
+		dates.add(new LocalDate(2009, 11, 1).toDateTimeAtCurrentTime().toDate());
+		dates.add(new LocalDate(2009, 11, 2).toDateTimeAtCurrentTime().toDate());
+		String formatted = (String) formattingService.convert(dates, new TypeDescriptor(Model.class.getField("dates")), TypeDescriptor.valueOf(String.class));
+		assertEquals("10/31/09,11/1/09,11/2/09", formatted);
+		dates = (List<Date>) formattingService.convert("10/31/09,11/1/09,11/2/09", TypeDescriptor.valueOf(String.class), new TypeDescriptor(Model.class.getField("dates")));
+		assertEquals(new LocalDate(2009, 10, 31), new LocalDate(dates.get(0)));
+		assertEquals(new LocalDate(2009, 11, 1), new LocalDate(dates.get(1)));
+		assertEquals(new LocalDate(2009, 11, 2), new LocalDate(dates.get(2)));
+	}
+	
 	@Test
 	public void testPrintNull() throws ParseException {
 		formattingService.addFormatterForFieldType(Number.class, new NumberFormatter());
@@ -141,6 +169,10 @@ public class FormattingConversionServiceTests {
 		@org.springframework.format.annotation.DateTimeFormat(style="S-")
 		public Date date;
 		
+		@SuppressWarnings("unused")
+		@org.springframework.format.annotation.DateTimeFormat(style="S-")
+		public List<Date> dates;
+
 	}
 
 }

org.springframework.core/src/main/java/org/springframework/core/convert/TypeDescriptor.java

@@ -42,43 +42,37 @@ public class TypeDescriptor {
 
 	private static final Map<Class<?>, TypeDescriptor> typeDescriptorCache = new HashMap<Class<?>, TypeDescriptor>();
 
+	private static final Annotation[] EMPTY_ANNOTATION_ARRAY = new Annotation[0];
+	
 	static {
 		typeDescriptorCache.put(boolean.class, new TypeDescriptor(boolean.class));
 		typeDescriptorCache.put(Boolean.class, new TypeDescriptor(Boolean.class));
-
 		typeDescriptorCache.put(byte.class, new TypeDescriptor(byte.class));
 		typeDescriptorCache.put(Byte.class, new TypeDescriptor(Byte.class));
-		
 		typeDescriptorCache.put(char.class, new TypeDescriptor(char.class));
 		typeDescriptorCache.put(Character.class, new TypeDescriptor(Character.class));
-		
-		typeDescriptorCache.put(double.class, new TypeDescriptor(double.class));
-		typeDescriptorCache.put(Double.class, new TypeDescriptor(Double.class));
-
-		typeDescriptorCache.put(float.class, new TypeDescriptor(float.class));
-		typeDescriptorCache.put(Float.class, new TypeDescriptor(Float.class));
-
-		typeDescriptorCache.put(int.class, new TypeDescriptor(int.class));
-		typeDescriptorCache.put(Integer.class, new TypeDescriptor(Integer.class));
-		
-		typeDescriptorCache.put(long.class, new TypeDescriptor(long.class));
-		typeDescriptorCache.put(Long.class, new TypeDescriptor(Long.class));
-		
 		typeDescriptorCache.put(short.class, new TypeDescriptor(short.class));
 		typeDescriptorCache.put(Short.class, new TypeDescriptor(Short.class));
-
+		typeDescriptorCache.put(int.class, new TypeDescriptor(int.class));
+		typeDescriptorCache.put(Integer.class, new TypeDescriptor(Integer.class));
+		typeDescriptorCache.put(long.class, new TypeDescriptor(long.class));
+		typeDescriptorCache.put(Long.class, new TypeDescriptor(Long.class));
+		typeDescriptorCache.put(float.class, new TypeDescriptor(float.class));
+		typeDescriptorCache.put(Float.class, new TypeDescriptor(Float.class));
+		typeDescriptorCache.put(double.class, new TypeDescriptor(double.class));
+		typeDescriptorCache.put(Double.class, new TypeDescriptor(Double.class));
 		typeDescriptorCache.put(String.class, new TypeDescriptor(String.class));
 	}
 	
 
-	private Object value;
-
 	private Class<?> type;
 
 	private MethodParameter methodParameter;
 
 	private Field field;
 
+	private Object value;
+
 	private Annotation[] cachedFieldAnnotations;
 
 
@@ -120,6 +114,7 @@ public class TypeDescriptor {
 	 * Create a new type descriptor for a field.
 	 * Use this constructor when a target conversion point originates from a field.
 	 * @param field the field to wrap
+	 * @param type the specific type to expose (may be an array/collection element)
 	 */
 	public TypeDescriptor(Field field, Class<?> type) {
 		Assert.notNull(field, "Field must not be null");
@@ -127,36 +122,38 @@ public class TypeDescriptor {
 		this.type = type;
 	}
 
+	// static factory methods
+
 	/**
-	 * Internal constructor for a NULL descriptor.
+	 * Create a new type descriptor for the class of the given object.
+	 * @param object the object
+	 * @return the type descriptor
 	 */
-	private TypeDescriptor() {
+	public static TypeDescriptor forObject(Object object) {
+		if (object == null) {
+			return NULL;
+		}
+		else if (object instanceof Collection<?> || object instanceof Map<?, ?>) {
+			return new TypeDescriptor(object);
+		}
+		else {
+			return valueOf(object.getClass());
+		}
 	}
 	
 	/**
-	 * Create a new descriptor for the type of the given value.
+	 * Create a new type descriptor for the given class.
-	 * <p>Use this constructor when a conversion point comes from a source such as a Map or
+	 * @param type the class
-	 * Collection, where no additional context is available but elements can be introspected.
+	 * @return the type descriptor
-	 * @param type the actual type to wrap
 	 */
-	private TypeDescriptor(Object value) {
+	public static TypeDescriptor valueOf(Class<?> type) {
-		Assert.notNull(value, "Value must not be null");
+		if (type == null) {
-		this.value = value;
+			return TypeDescriptor.NULL;
-		this.type = value.getClass();
 		}
-
+		TypeDescriptor desc = typeDescriptorCache.get(type);
-	/**
+		return (desc != null ? desc : new TypeDescriptor(type));
-	 * Create a new descriptor for the given type.
-	 * <p>Use this constructor when a conversion point comes from a plain source type,
-	 * where no additional context is available.
-	 * @param type the actual type to wrap
-	 */
-	private TypeDescriptor(Class<?> type) {
-		Assert.notNull(type, "Type must not be null");
-		this.type = type;
 	}
 	
-
 	/**
 	 * Return the wrapped MethodParameter, if any.
 	 * <p>Note: Either MethodParameter or Field is available.
@@ -254,7 +251,7 @@ public class TypeDescriptor {
 	 * Return the element type as a type descriptor.
 	 */
 	public TypeDescriptor getElementTypeDescriptor() {
-		return TypeDescriptor.valueOf(getElementType());
+		return forElementType(getElementType());
 	}
 
 	/**
@@ -266,25 +263,6 @@ public class TypeDescriptor {
 		return getElementType() != null ? getElementTypeDescriptor() : TypeDescriptor.forObject(element);
 	}
 
-	/**
-	 * Create a copy of this type descriptor, preserving the context information
-	 * but exposing the specified element type (e.g. an array/collection element).
-	 * @param elementType the desired type to expose
-	 * @return the type descriptor
-	 */
-	public TypeDescriptor forElementType(Class<?> elementType) {
-		Assert.notNull(elementType, "Element type must not be null");
-		if (getType().equals(elementType)) {
-			return this;
-		}
-		else if (this.methodParameter != null) {
-			return new TypeDescriptor(this.methodParameter, elementType);
-		}
-		else {
-			return new TypeDescriptor(this.field, elementType);
-		}
-	}
-
 	/**
 	 * Is this type a {@link Map} type?
 	 */
@@ -305,6 +283,7 @@ public class TypeDescriptor {
 	 */
 	@SuppressWarnings("unchecked")
 	public Class<?> getMapKeyType() {
+		if (isMap()) {
 			if (this.field != null) {
 				return GenericCollectionTypeResolver.getMapKeyFieldType(this.field);
 			}
@@ -320,10 +299,8 @@ public class TypeDescriptor {
 					}
 				}
 			}
-		if (this.type != null) {
 			return GenericCollectionTypeResolver.getMapKeyType((Class<? extends Map>) this.type);
-		}
+		} else {
-		else {
 			return null;
 		}
 	}
@@ -334,6 +311,7 @@ public class TypeDescriptor {
 	 */
 	@SuppressWarnings("unchecked")
 	public Class<?> getMapValueType() {
+		if (isMap()) {
 			if (this.field != null) {
 				return GenericCollectionTypeResolver.getMapValueFieldType(this.field);
 			}
@@ -349,10 +327,8 @@ public class TypeDescriptor {
 					}
 				}
 			}
-		if (this.type != null) {
 			return GenericCollectionTypeResolver.getMapValueType((Class<? extends Map>) this.type);			
-		}
+		} else {
-		else {
 			return null;
 		}
 	}
@@ -361,7 +337,7 @@ public class TypeDescriptor {
 	 * Returns map key type as a type descriptor.
 	 */
 	public TypeDescriptor getMapKeyTypeDescriptor() {
-		return TypeDescriptor.valueOf(getMapKeyType());
+		return forElementType(getMapKeyType());
 	}
 
 	/**
@@ -377,7 +353,7 @@ public class TypeDescriptor {
 	 * Returns map value type as a type descriptor.
 	 */
 	public TypeDescriptor getMapValueTypeDescriptor() {
-		return TypeDescriptor.valueOf(getMapValueType());
+		return forElementType(getMapValueType());
 	}
 
 	/**
@@ -408,7 +384,7 @@ public class TypeDescriptor {
 			}
 		}
 		else {
-			return new Annotation[0];
+			return EMPTY_ANNOTATION_ARRAY;
 		}
 	}
 
@@ -442,6 +418,27 @@ public class TypeDescriptor {
 		}
 	}
 
+	/**
+	 * Create a copy of this type descriptor, preserving the context information
+	 * but exposing the specified element type (e.g. an array/collection/map element).
+	 * @param elementType the desired type to expose
+	 * @return the type descriptor
+	 */
+	public TypeDescriptor forElementType(Class<?> elementType) {
+		if (getType().equals(elementType)) {
+			return this;
+		} else if (elementType == null) {
+			return TypeDescriptor.NULL;
+		} else if (this.methodParameter != null) {
+			return new TypeDescriptor(this.methodParameter, elementType);
+		}
+		else if (this.field != null) {
+			return new TypeDescriptor(this.field, elementType);
+		} else { 
+			return TypeDescriptor.valueOf(elementType);
+		}
+	}
+	
 	/**
 	 * A textual representation of the type descriptor (eg. Map<String,Foo>) for use in messages
 	 */
@@ -506,36 +503,33 @@ public class TypeDescriptor {
 		}
 	}
 	
-	// static factory methods
-
 	/**
-	 * Create a new type descriptor for the given class.
+	 * Internal constructor for a NULL descriptor.
-	 * @param type the class
-	 * @return the type descriptor
 	 */
-	public static TypeDescriptor valueOf(Class<?> type) {
+	private TypeDescriptor() {
-		if (type == null) {
-			return TypeDescriptor.NULL;
-		}
-		TypeDescriptor desc = typeDescriptorCache.get(type);
-		return (desc != null ? desc : new TypeDescriptor(type));
 	}
 
 	/**
-	 * Create a new type descriptor for the class of the given object.
+	 * Create a new descriptor for the type of the given value.
-	 * @param object the object
+	 * <p>Use this constructor when a conversion point comes from a source such as a Map or
-	 * @return the type descriptor
+	 * Collection, where no additional context is available but elements can be introspected.
+	 * @param type the actual type to wrap
 	 */
-	public static TypeDescriptor forObject(Object object) {
+	private TypeDescriptor(Object value) {
-		if (object == null) {
+		Assert.notNull(value, "Value must not be null");
-			return NULL;
+		this.value = value;
-		}
+		this.type = value.getClass();
-		else if (object instanceof Collection<?> || object instanceof Map<?, ?>) {
-			return new TypeDescriptor(object);
-		}
-		else {
-			return valueOf(object.getClass());
 	}
+
+	/**
+	 * Create a new descriptor for the given type.
+	 * <p>Use this constructor when a conversion point comes from a plain source type,
+	 * where no additional context is available.
+	 * @param type the actual type to wrap
+	 */
+	private TypeDescriptor(Class<?> type) {
+		Assert.notNull(type, "Type must not be null");
+		this.type = type;
 	}
 
 }