From b79f981510f79ca4d2be2323a4941680740c77e5 Mon Sep 17 00:00:00 2001 From: Sam Brannen Date: Mon, 30 May 2022 19:57:20 +0200 Subject: [PATCH] Document Checkstyle issue regarding instanceof pattern variables See https://github.com/checkstyle/checkstyle/issues/10969 --- .../java/org/springframework/util/xml/DomContentHandler.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spring-core/src/main/java/org/springframework/util/xml/DomContentHandler.java b/spring-core/src/main/java/org/springframework/util/xml/DomContentHandler.java index 5c7e458d29..a36ff0db64 100644 --- a/spring-core/src/main/java/org/springframework/util/xml/DomContentHandler.java +++ b/spring-core/src/main/java/org/springframework/util/xml/DomContentHandler.java @@ -50,6 +50,8 @@ class DomContentHandler implements ContentHandler { */ DomContentHandler(Node node) { this.node = node; + // The following pattern variable "doc" cannot be named "document" due to lacking + // support in Checkstyle: https://github.com/checkstyle/checkstyle/issues/10969 if (node instanceof Document doc) { this.document = doc; }