From b92515bdee5a3f153183e2f86ee5e378c28b0d1e Mon Sep 17 00:00:00 2001 From: Qimiao Chen Date: Tue, 10 Mar 2020 21:41:20 +0800 Subject: [PATCH] Add logger.isInfoEnabled check before logger.info Closes gh-24667 --- .../org/springframework/aop/framework/ProxyFactoryBean.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java b/spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java index 364e5225af0..2b40e3767c8 100644 --- a/spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java +++ b/spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java @@ -254,7 +254,7 @@ public class ProxyFactoryBean extends ProxyCreatorSupport return getSingletonInstance(); } else { - if (this.targetName == null) { + if (this.targetName == null && logger.isInfoEnabled()) { logger.info("Using non-singleton proxies with singleton targets is often undesirable. " + "Enable prototype proxies by setting the 'targetName' property."); }