parent
6ca3884759
commit
bdac937a43
|
@ -66,7 +66,7 @@ automatically when you submit a pull request.
|
||||||
|
|
||||||
1. For all but the most trivial of contributions, please [create a ticket](#create-a-ticket).
|
1. For all but the most trivial of contributions, please [create a ticket](#create-a-ticket).
|
||||||
The purpose of the ticket is to understand and discuss the underlying issue or feature.
|
The purpose of the ticket is to understand and discuss the underlying issue or feature.
|
||||||
We use the Github issue tracker as the preferred place of record for conversations and
|
We use the GitHub issue tracker as the preferred place of record for conversations and
|
||||||
conclusions. In that sense discussions directly under a PR are more implementation detail
|
conclusions. In that sense discussions directly under a PR are more implementation detail
|
||||||
oriented and transient in nature.
|
oriented and transient in nature.
|
||||||
|
|
||||||
|
@ -75,7 +75,7 @@ oriented and transient in nature.
|
||||||
Backports to prior versions will be considered on a case-by-case basis and reflected as
|
Backports to prior versions will be considered on a case-by-case basis and reflected as
|
||||||
the fix version in the issue tracker.
|
the fix version in the issue tracker.
|
||||||
|
|
||||||
1. Use short branch names, preferably based on the Github issue (e.g. `SPR-1234`), or
|
1. Use short branch names, preferably based on the GitHub issue (e.g. `22276`), or
|
||||||
otherwise using succinct, lower-case, dash (-) delimited names, such as `fix-warnings`.
|
otherwise using succinct, lower-case, dash (-) delimited names, such as `fix-warnings`.
|
||||||
|
|
||||||
1. Choose the granularity of your commits consciously and squash commits that represent
|
1. Choose the granularity of your commits consciously and squash commits that represent
|
||||||
|
@ -84,12 +84,12 @@ multiple edits or corrections of the same logical change. See
|
||||||
for an overview of streamlining commit history.
|
for an overview of streamlining commit history.
|
||||||
|
|
||||||
1. Format commit messages using 55 characters for the subject line, 72 lines for the
|
1. Format commit messages using 55 characters for the subject line, 72 lines for the
|
||||||
description, followed by related issues, e.g. `Issues: SPR-1234, SPR-1235`.
|
description, followed by the issue fixed, e.g. `Fixes #22276`.
|
||||||
See the
|
See the
|
||||||
[Commit Guidelines section of Pro Git](http://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project#Commit-Guidelines)
|
[Commit Guidelines section of Pro Git](http://git-scm.com/book/en/Distributed-Git-Contributing-to-a-Project#Commit-Guidelines)
|
||||||
for best practices around commit messages and use `git log` to see some examples.
|
for best practices around commit messages and use `git log` to see some examples.
|
||||||
|
|
||||||
1. List the Github issue number in the PR description.
|
1. List the GitHub issue number in the PR description.
|
||||||
|
|
||||||
If accepted, your contribution may be heavily modified as needed prior to merging.
|
If accepted, your contribution may be heavily modified as needed prior to merging.
|
||||||
You will likely retain author attribution for your Git commits granted that the bulk of
|
You will likely retain author attribution for your Git commits granted that the bulk of
|
||||||
|
@ -116,7 +116,7 @@ defines the source file coding standards we use along with some IDEA editor sett
|
||||||
|
|
||||||
The reference documentation is in the [src/docs/asciidoc](src/docs/asciidoc) directory and, in
|
The reference documentation is in the [src/docs/asciidoc](src/docs/asciidoc) directory and, in
|
||||||
[Asciidoctor](http://asciidoctor.org/) format. For trivial changes, you may be able to browse,
|
[Asciidoctor](http://asciidoctor.org/) format. For trivial changes, you may be able to browse,
|
||||||
edit source files, and submit directly from Github.
|
edit source files, and submit directly from GitHub.
|
||||||
|
|
||||||
When making changes locally, use `./gradlew asciidoctor` and then browse the result under
|
When making changes locally, use `./gradlew asciidoctor` and then browse the result under
|
||||||
`build/asciidoc/html5/index.html`.
|
`build/asciidoc/html5/index.html`.
|
||||||
|
|
|
@ -19,7 +19,7 @@ plugins {
|
||||||
ext {
|
ext {
|
||||||
linkHomepage = "https://projects.spring.io/spring-framework"
|
linkHomepage = "https://projects.spring.io/spring-framework"
|
||||||
linkCi = "https://build.spring.io/browse/SPR"
|
linkCi = "https://build.spring.io/browse/SPR"
|
||||||
linkIssue = "https://jira.spring.io/browse/SPR"
|
linkIssue = "https://github.com/spring-projects/spring-framework/issues"
|
||||||
linkScmUrl = "https://github.com/spring-projects/spring-framework"
|
linkScmUrl = "https://github.com/spring-projects/spring-framework"
|
||||||
linkScmConnection = "scm:git:git://github.com/spring-projects/spring-framework.git"
|
linkScmConnection = "scm:git:git://github.com/spring-projects/spring-framework.git"
|
||||||
linkScmDevConnection = "scm:git:ssh://git@github.com:spring-projects/spring-framework.git"
|
linkScmDevConnection = "scm:git:ssh://git@github.com:spring-projects/spring-framework.git"
|
||||||
|
|
|
@ -52,7 +52,7 @@ def customizePom(pom, gradleProject) {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
issueManagement {
|
issueManagement {
|
||||||
system = "Github"
|
system = "GitHub"
|
||||||
url = "https://github.com/spring-projects/spring-framework/issues"
|
url = "https://github.com/spring-projects/spring-framework/issues"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -27,7 +27,7 @@ import static org.junit.Assert.*;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Reproduces SPR-8756, which has been marked as "won't fix" for reasons
|
* Reproduces SPR-8756, which has been marked as "won't fix" for reasons
|
||||||
* described in the JIRA issue. Also demonstrates the suggested workaround.
|
* described in the issue. Also demonstrates the suggested workaround.
|
||||||
*
|
*
|
||||||
* @author Chris Beams
|
* @author Chris Beams
|
||||||
*/
|
*/
|
||||||
|
|
|
@ -1,4 +1,4 @@
|
||||||
List of outstanding things to think about - turn into JIRAs once distilled to a core set of issues
|
List of outstanding things to think about - turn into tickets once distilled to a core set of issues
|
||||||
|
|
||||||
High Importance
|
High Importance
|
||||||
|
|
||||||
|
|
|
@ -66,7 +66,7 @@ import static org.hamcrest.Matchers.*;
|
||||||
import static org.junit.Assert.*;
|
import static org.junit.Assert.*;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Reproduction tests cornering various SpEL JIRA issues.
|
* Reproduction tests cornering various reported SpEL issues.
|
||||||
*
|
*
|
||||||
* @author Andy Clement
|
* @author Andy Clement
|
||||||
* @author Juergen Hoeller
|
* @author Juergen Hoeller
|
||||||
|
|
|
@ -1190,8 +1190,8 @@ The following `DateFormatter` is an example `Formatter` implementation:
|
||||||
----
|
----
|
||||||
====
|
====
|
||||||
|
|
||||||
The Spring team welcomes community-driven `Formatter` contributionsSee
|
The Spring team welcomes community-driven `Formatter` contributions. See
|
||||||
https://jira.spring.io/browse/SPR[jira.spring.io] to contribute.
|
https://github.com/spring-projects/spring-framework/issues[GitHub Issues] to contribute.
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
|
@ -4983,7 +4983,7 @@ You can extend Spring JDBC embedded database support in two ways:
|
||||||
connection pool to manage embedded database connections.
|
connection pool to manage embedded database connections.
|
||||||
|
|
||||||
We encourage you to contribute extensions to the Spring community at
|
We encourage you to contribute extensions to the Spring community at
|
||||||
https://jira.spring.io/browse/SPR[jira.spring.io].
|
https://github.com/spring-projects/spring-framework/issues[GitHub Issues].
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
|
|
@ -125,7 +125,7 @@ clean code structure with no circular dependencies between packages.
|
||||||
For how-to questions or diagnosing or debugging issues, we suggest using StackOverflow,
|
For how-to questions or diagnosing or debugging issues, we suggest using StackOverflow,
|
||||||
and we have a https://spring.io/questions[questions page] that lists the suggested tags to use.
|
and we have a https://spring.io/questions[questions page] that lists the suggested tags to use.
|
||||||
If you're fairly certain that there is a problem in the Spring Framework or would like
|
If you're fairly certain that there is a problem in the Spring Framework or would like
|
||||||
to suggest a feature, please use the https://jira.spring.io/browse/spr[JIRA issue tracker].
|
to suggest a feature, please use the https://github.com/spring-projects/spring-framework/issues[GitHub Issues].
|
||||||
|
|
||||||
If you have a solution in mind or a suggested fix, you can submit a pull request on
|
If you have a solution in mind or a suggested fix, you can submit a pull request on
|
||||||
https://github.com/spring-projects/spring-framework[Github]. However, please keep in mind
|
https://github.com/spring-projects/spring-framework[Github]. However, please keep in mind
|
||||||
|
|
|
@ -1,8 +1,8 @@
|
||||||
Spring Framework version ${version}
|
Spring Framework version ${version}
|
||||||
=====================================================================================
|
=====================================================================================
|
||||||
|
|
||||||
To find out what has changed since earlier releases, see the 'Change Log' section at
|
To find out what has changed since earlier releases, see the release notes at
|
||||||
https://jira.spring.io/browse/SPR
|
https://github.com/spring-projects/spring-framework/releases
|
||||||
|
|
||||||
Please consult the documentation located within the 'docs/spring-framework-reference'
|
Please consult the documentation located within the 'docs/spring-framework-reference'
|
||||||
directory of this release and also visit the official Spring Framework home at
|
directory of this release and also visit the official Spring Framework home at
|
||||||
|
|
Loading…
Reference in New Issue