AbstractMessageListenerContainer calls "Session.recover()" in case of rollback attempt on non-transacted Session

Issue: SPR-12015
This commit is contained in:
Juergen Hoeller 2014-07-22 16:50:41 +02:00
parent 5e2fbe7355
commit c082220b34
1 changed files with 18 additions and 8 deletions

View File

@ -711,9 +711,14 @@ public abstract class AbstractMessageListenerContainer
* @throws javax.jms.JMSException in case of a rollback error
*/
protected void rollbackIfNecessary(Session session) throws JMSException {
if (session.getTransacted() && isSessionLocallyTransacted(session)) {
// Transacted session created by this container -> rollback.
JmsUtils.rollbackIfNecessary(session);
if (session.getTransacted()) {
if (isSessionLocallyTransacted(session)) {
// Transacted session created by this container -> rollback.
JmsUtils.rollbackIfNecessary(session);
}
}
else {
session.recover();
}
}
@ -725,12 +730,17 @@ public abstract class AbstractMessageListenerContainer
*/
protected void rollbackOnExceptionIfNecessary(Session session, Throwable ex) throws JMSException {
try {
if (session.getTransacted() && isSessionLocallyTransacted(session)) {
// Transacted session created by this container -> rollback.
if (logger.isDebugEnabled()) {
logger.debug("Initiating transaction rollback on application exception", ex);
if (session.getTransacted()) {
if (isSessionLocallyTransacted(session)) {
// Transacted session created by this container -> rollback.
if (logger.isDebugEnabled()) {
logger.debug("Initiating transaction rollback on application exception", ex);
}
JmsUtils.rollbackIfNecessary(session);
}
JmsUtils.rollbackIfNecessary(session);
}
else {
session.recover();
}
}
catch (IllegalStateException ex2) {