From c14cbd07f449d845269c99faa29241e7e2d0dfc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Deleuze?= Date: Wed, 2 Nov 2022 12:01:49 +0100 Subject: [PATCH 1/2] Use non-null DateFormat for CustomDateEditor in tests Closes gh-29419 --- .../beans/propertyeditors/CustomEditorTests.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spring-beans/src/test/java/org/springframework/beans/propertyeditors/CustomEditorTests.java b/spring-beans/src/test/java/org/springframework/beans/propertyeditors/CustomEditorTests.java index e3dddf62db2..696e3088583 100644 --- a/spring-beans/src/test/java/org/springframework/beans/propertyeditors/CustomEditorTests.java +++ b/spring-beans/src/test/java/org/springframework/beans/propertyeditors/CustomEditorTests.java @@ -722,7 +722,7 @@ class CustomEditorTests { @Test void testCustomDateEditor() { - CustomDateEditor editor = new CustomDateEditor(null, false); + CustomDateEditor editor = new CustomDateEditor(new SimpleDateFormat("MM/dd/yyyy"), false); editor.setValue(null); assertThat(editor.getValue()).isNull(); assertThat(editor.getAsText()).isEmpty(); @@ -730,7 +730,7 @@ class CustomEditorTests { @Test void testCustomDateEditorWithEmptyAsNull() { - CustomDateEditor editor = new CustomDateEditor(null, true); + CustomDateEditor editor = new CustomDateEditor(new SimpleDateFormat("MM/dd/yyyy"), true); editor.setValue(null); assertThat(editor.getValue()).isNull(); assertThat(editor.getAsText()).isEmpty(); From fded79d807b7d6b69e01ecc4e241399a438ee220 Mon Sep 17 00:00:00 2001 From: Steve Gerhardt <113389206+stgerhardt@users.noreply.github.com> Date: Mon, 12 Sep 2022 19:03:09 -0600 Subject: [PATCH 2/2] Make SimpleMailMessage setters parameters nullable Closes gh-29139 --- .../mail/SimpleMailMessage.java | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/spring-context-support/src/main/java/org/springframework/mail/SimpleMailMessage.java b/spring-context-support/src/main/java/org/springframework/mail/SimpleMailMessage.java index 95268a2993e..a13f188ad7a 100644 --- a/spring-context-support/src/main/java/org/springframework/mail/SimpleMailMessage.java +++ b/spring-context-support/src/main/java/org/springframework/mail/SimpleMailMessage.java @@ -93,7 +93,7 @@ public class SimpleMailMessage implements MailMessage, Serializable { @Override - public void setFrom(String from) { + public void setFrom(@Nullable String from) { this.from = from; } @@ -103,7 +103,7 @@ public class SimpleMailMessage implements MailMessage, Serializable { } @Override - public void setReplyTo(String replyTo) { + public void setReplyTo(@Nullable String replyTo) { this.replyTo = replyTo; } @@ -113,7 +113,7 @@ public class SimpleMailMessage implements MailMessage, Serializable { } @Override - public void setTo(String to) { + public void setTo(@Nullable String to) { this.to = new String[] {to}; } @@ -128,12 +128,12 @@ public class SimpleMailMessage implements MailMessage, Serializable { } @Override - public void setCc(String cc) { + public void setCc(@Nullable String cc) { this.cc = new String[] {cc}; } @Override - public void setCc(String... cc) { + public void setCc(@Nullable String... cc) { this.cc = cc; } @@ -143,12 +143,12 @@ public class SimpleMailMessage implements MailMessage, Serializable { } @Override - public void setBcc(String bcc) { + public void setBcc(@Nullable String bcc) { this.bcc = new String[] {bcc}; } @Override - public void setBcc(String... bcc) { + public void setBcc(@Nullable String... bcc) { this.bcc = bcc; } @@ -158,7 +158,7 @@ public class SimpleMailMessage implements MailMessage, Serializable { } @Override - public void setSentDate(Date sentDate) { + public void setSentDate(@Nullable Date sentDate) { this.sentDate = sentDate; } @@ -168,7 +168,7 @@ public class SimpleMailMessage implements MailMessage, Serializable { } @Override - public void setSubject(String subject) { + public void setSubject(@Nullable String subject) { this.subject = subject; } @@ -178,7 +178,7 @@ public class SimpleMailMessage implements MailMessage, Serializable { } @Override - public void setText(String text) { + public void setText(@Nullable String text) { this.text = text; }