root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

WebMvcConfigurationSupport uses static NoOpValidator instead of anonymous inner class

This commit is contained in:
Juergen Hoeller 2014-09-16 23:43:25 +02:00
parent 5cd59d044e
commit c778868d66
1 changed files with 33 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/WebMvcConfigurationSupport.java
View File

@ -26,7 +26,6 @@ import javax.servlet.http.HttpServletRequest;
import javax.xml.transform.Source; import javax.xml.transform.Source;
import org.springframework.beans.BeanUtils; import org.springframework.beans.BeanUtils;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.BeanInitializationException; import org.springframework.beans.factory.BeanInitializationException;
import org.springframework.context.ApplicationContext; import org.springframework.context.ApplicationContext;
import org.springframework.context.ApplicationContextAware; import org.springframework.context.ApplicationContextAware;
@ -208,17 +207,17 @@ public class WebMvcConfigurationSupport implements ApplicationContextAware, Serv
* Set the Spring {@link ApplicationContext}, e.g. for resource loading. * Set the Spring {@link ApplicationContext}, e.g. for resource loading.
*/ */
@Override @Override
public void setApplicationContext(ApplicationContext applicationContext) throws BeansException { public void setApplicationContext(ApplicationContext applicationContext) {
this.applicationContext = applicationContext; this.applicationContext = applicationContext;
} }
/** /**
* Return a {@link RequestMappingHandlerMapping} ordered at 0 for mapping * Return a {@link RequestMappingHandlerMapping} ordered at 0 for mapping
* requests to annotated controllers. * requests to annotated controllers.
*/ */
@Bean @Bean
public RequestMappingHandlerMapping requestMappingHandlerMapping() { public RequestMappingHandlerMapping requestMappingHandlerMapping() {
RequestMappingHandlerMapping handlerMapping = new RequestMappingHandlerMapping(); RequestMappingHandlerMapping handlerMapping = new RequestMappingHandlerMapping();
handlerMapping.setOrder(0); handlerMapping.setOrder(0);
handlerMapping.setInterceptors(getInterceptors()); handlerMapping.setInterceptors(getInterceptors());
@ -265,7 +264,7 @@ public class WebMvcConfigurationSupport implements ApplicationContextAware, Serv
* use {@link #addInterceptors(InterceptorRegistry)} instead. * use {@link #addInterceptors(InterceptorRegistry)} instead.
*/ */
protected final Object[] getInterceptors() { protected final Object[] getInterceptors() {
if (interceptors == null) { if (this.interceptors == null) {
InterceptorRegistry registry = new InterceptorRegistry(); InterceptorRegistry registry = new InterceptorRegistry();
addInterceptors(registry); addInterceptors(registry);
registry.addInterceptor(new ConversionServiceExposingInterceptor(mvcConversionService())); registry.addInterceptor(new ConversionServiceExposingInterceptor(mvcConversionService()));
@ -336,7 +335,7 @@ public class WebMvcConfigurationSupport implements ApplicationContextAware, Serv
addViewControllers(registry); addViewControllers(registry);
AbstractHandlerMapping handlerMapping = registry.getHandlerMapping(); AbstractHandlerMapping handlerMapping = registry.getHandlerMapping();
handlerMapping = handlerMapping != null ? handlerMapping : new EmptyHandlerMapping(); handlerMapping = (handlerMapping != null ? handlerMapping : new EmptyHandlerMapping());
handlerMapping.setPathMatcher(mvcPathMatcher()); handlerMapping.setPathMatcher(mvcPathMatcher());
handlerMapping.setUrlPathHelper(mvcUrlPathHelper()); handlerMapping.setUrlPathHelper(mvcUrlPathHelper());
handlerMapping.setInterceptors(getInterceptors()); handlerMapping.setInterceptors(getInterceptors());
@ -369,11 +368,11 @@ public class WebMvcConfigurationSupport implements ApplicationContextAware, Serv
*/ */
@Bean @Bean
public HandlerMapping resourceHandlerMapping() { public HandlerMapping resourceHandlerMapping() {
ResourceHandlerRegistry registry = new ResourceHandlerRegistry( ResourceHandlerRegistry registry = new ResourceHandlerRegistry(this.applicationContext, this.servletContext);
this.applicationContext, this.servletContext);
addResourceHandlers(registry); addResourceHandlers(registry);
AbstractHandlerMapping handlerMapping = registry.getHandlerMapping(); AbstractHandlerMapping handlerMapping = registry.getHandlerMapping();
handlerMapping = handlerMapping != null ? handlerMapping : new EmptyHandlerMapping(); handlerMapping = (handlerMapping != null ? handlerMapping : new EmptyHandlerMapping());
handlerMapping.setPathMatcher(mvcPathMatcher()); handlerMapping.setPathMatcher(mvcPathMatcher());
handlerMapping.setUrlPathHelper(mvcUrlPathHelper()); handlerMapping.setUrlPathHelper(mvcUrlPathHelper());
return handlerMapping; return handlerMapping;
@ -509,24 +508,16 @@ public class WebMvcConfigurationSupport implements ApplicationContextAware, Serv
String className = "org.springframework.validation.beanvalidation.OptionalValidatorFactoryBean"; String className = "org.springframework.validation.beanvalidation.OptionalValidatorFactoryBean";
clazz = ClassUtils.forName(className, WebMvcConfigurationSupport.class.getClassLoader()); clazz = ClassUtils.forName(className, WebMvcConfigurationSupport.class.getClassLoader());
} }
catch (ClassNotFoundException e) { catch (ClassNotFoundException ex) {
throw new BeanInitializationException("Could not find default validator", e); throw new BeanInitializationException("Could not find default validator class", ex);
} }
catch (LinkageError e) { catch (LinkageError ex) {
throw new BeanInitializationException("Could not find default validator", e); throw new BeanInitializationException("Could not load default validator class", ex);
} }
validator = (Validator) BeanUtils.instantiate(clazz); validator = (Validator) BeanUtils.instantiate(clazz);
} }
else { else {
validator = new Validator() { validator = new NoOpValidator();
@Override
public boolean supports(Class<?> clazz) {
return false;
}
@Override
public void validate(Object target, Errors errors) {
}
};
} }
} }
return validator; return validator;
@ -618,14 +609,14 @@ public class WebMvcConfigurationSupport implements ApplicationContextAware, Serv
* used to add default message converters. * used to add default message converters.
*/ */
protected final List<HttpMessageConverter<?>> getMessageConverters() { protected final List<HttpMessageConverter<?>> getMessageConverters() {
if (messageConverters == null) { if (this.messageConverters == null) {
messageConverters = new ArrayList<HttpMessageConverter<?>>(); this.messageConverters = new ArrayList<HttpMessageConverter<?>>();
configureMessageConverters(messageConverters); configureMessageConverters(this.messageConverters);
if (messageConverters.isEmpty()) { if (this.messageConverters.isEmpty()) {
addDefaultHttpMessageConverters(messageConverters); addDefaultHttpMessageConverters(this.messageConverters);
} }
} }
return messageConverters; return this.messageConverters;
} }
/** /**
@ -791,11 +782,9 @@ public class WebMvcConfigurationSupport implements ApplicationContextAware, Serv
* resolution is used in which case the order is raised to * resolution is used in which case the order is raised to
* {@link org.springframework.core.Ordered#HIGHEST_PRECEDENCE * {@link org.springframework.core.Ordered#HIGHEST_PRECEDENCE
* Ordered.HIGHEST_PRECEDENCE}. * Ordered.HIGHEST_PRECEDENCE}.
*
* <p>If no other resolvers are configured, * <p>If no other resolvers are configured,
* {@link ViewResolverComposite#resolveViewName(String, Locale)} returns null in order * {@link ViewResolverComposite#resolveViewName(String, Locale)} returns null in order
* to allow other potential {@link ViewResolver} beans to resolve views. * to allow other potential {@link ViewResolver} beans to resolve views.
*
* @since 4.1 * @since 4.1
*/ */
@Bean @Bean
@ -821,12 +810,25 @@ public class WebMvcConfigurationSupport implements ApplicationContextAware, Serv
} }
private final static class EmptyHandlerMapping extends AbstractHandlerMapping { private static final class EmptyHandlerMapping extends AbstractHandlerMapping {
@Override @Override
protected Object getHandlerInternal(HttpServletRequest request) throws Exception { protected Object getHandlerInternal(HttpServletRequest request) {
return null; return null;
} }
} }
private static final class NoOpValidator implements Validator {
@Override
public boolean supports(Class<?> clazz) {
return false;
}
@Override
public void validate(Object target, Errors errors) {
}
}
} }