root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Increase StreamUtils.BUFFER_SIZE to 8192 

This aligns the buffer size used in StreamUtils with the buffer sizes
used throughout the JDK (see InputStream, BufferedInputStream, Files).

Closes gh-28965
This commit is contained in:
Patrick Strawderman 2022-08-13 15:02:52 -07:00 committed by Brian Clozel
parent c8ef2b2202
commit cdb38e8482
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spring-core/src/main/java/org/springframework/util/StreamUtils.java
View File

@ -33,7 +33,7 @@ import org.springframework.lang.Nullable;
/** /**
* Simple utility methods for dealing with streams. The copy methods of this class are * Simple utility methods for dealing with streams. The copy methods of this class are
* similar to those defined in {@link FileCopyUtils} except that all affected streams are * similar to those defined in {@link FileCopyUtils} except that all affected streams are
* left open when done. All copy methods use a block size of 4096 bytes. * left open when done. All copy methods use a block size of 8192 bytes.
* *
* <p>Mainly for use within the framework, but also useful for application code. * <p>Mainly for use within the framework, but also useful for application code.
* *
@ -48,7 +48,7 @@ public abstract class StreamUtils {
/** /**
* The default buffer size used when copying bytes. * The default buffer size used when copying bytes.
*/ */
public static final int BUFFER_SIZE = 4096; public static final int BUFFER_SIZE = 8192;
private static final byte[] EMPTY_CONTENT = new byte[0]; private static final byte[] EMPTY_CONTENT = new byte[0];
@ -83,7 +83,7 @@ public abstract class StreamUtils {
return ""; return "";
} }
StringBuilder out = new StringBuilder(BUFFER_SIZE); StringBuilder out = new StringBuilder();
InputStreamReader reader = new InputStreamReader(in, charset); InputStreamReader reader = new InputStreamReader(in, charset);
char[] buffer = new char[BUFFER_SIZE]; char[] buffer = new char[BUFFER_SIZE];
int charsRead; int charsRead;