root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Log message for unused @ModelAttribute name 

Closes gh-23877
This commit is contained in:
Rossen Stoyanchev 2020-05-06 10:37:44 +01:00
parent 66bb145247
commit d1708460e7
1 changed files with 22 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
spring-web/src/main/java/org/springframework/web/method/annotation/ModelFactory.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2019 the original author or authors. * Copyright 2002-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -24,6 +24,9 @@ import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Set; import java.util.Set;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.beans.BeanUtils; import org.springframework.beans.BeanUtils;
import org.springframework.core.Conventions; import org.springframework.core.Conventions;
import org.springframework.core.GenericTypeResolver; import org.springframework.core.GenericTypeResolver;
@ -58,6 +61,9 @@ import org.springframework.web.method.support.ModelAndViewContainer;
*/ */
public final class ModelFactory { public final class ModelFactory {
private static final Log logger = LogFactory.getLog(ModelFactory.class);
private final List<ModelMethod> modelMethods = new ArrayList<>(); private final List<ModelMethod> modelMethods = new ArrayList<>();
private final WebDataBinderFactory dataBinderFactory; private final WebDataBinderFactory dataBinderFactory;
@ -135,14 +141,22 @@ public final class ModelFactory {
} }
Object returnValue = modelMethod.invokeForRequest(request, container); Object returnValue = modelMethod.invokeForRequest(request, container);
if (!modelMethod.isVoid()){ if (modelMethod.isVoid()) {
String returnValueName = getNameForReturnValue(returnValue, modelMethod.getReturnType()); if (StringUtils.hasText(ann.value())) {
if (!ann.binding()) { if (logger.isDebugEnabled()) {
container.setBindingDisabled(returnValueName); logger.debug("Name in @ModelAttribute is ignored because method returns void: " +
} modelMethod.getShortLogMessage());
if (!container.containsAttribute(returnValueName)) { }
container.addAttribute(returnValueName, returnValue);
} }
continue;
}
String returnValueName = getNameForReturnValue(returnValue, modelMethod.getReturnType());
if (!ann.binding()) {
container.setBindingDisabled(returnValueName);
}
if (!container.containsAttribute(returnValueName)) {
container.addAttribute(returnValueName, returnValue);
} }
} }
} }