root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Polishing

This commit is contained in:
Juergen Hoeller 2018-06-28 18:02:07 +02:00
parent 8ad5299f4a
commit d34e6f7f70
8 changed files with 15 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spring-aop/src/main/java/org/springframework/aop/support/MethodMatchers.java
View File

@ -209,10 +209,8 @@ public abstract class MethodMatchers {
@Override @Override
public int hashCode() { public int hashCode() {
int hashCode = super.hashCode(); // Allow for matching with regular UnionMethodMatcher by providing same hash...
hashCode = 37 * hashCode + this.cf1.hashCode(); return super.hashCode();
hashCode = 37 * hashCode + this.cf2.hashCode();
return hashCode;
} }
} }

2
spring-beans/src/main/java/org/springframework/beans/factory/config/DependencyDescriptor.java
View File

@ -353,7 +353,6 @@ public class DependencyDescriptor extends InjectionPoint implements Serializable
Type[] args = ((ParameterizedType) type).getActualTypeArguments(); Type[] args = ((ParameterizedType) type).getActualTypeArguments();
type = args[args.length - 1]; type = args[args.length - 1];
} }
// TODO: Object.class if unresolvable
} }
if (type instanceof Class) { if (type instanceof Class) {
return (Class<?>) type; return (Class<?>) type;
@ -375,6 +374,7 @@ public class DependencyDescriptor extends InjectionPoint implements Serializable
} }
} }
@Override @Override
public boolean equals(Object other) { public boolean equals(Object other) {
if (this == other) { if (this == other) {

2
spring-web/src/main/java/org/springframework/http/ContentDisposition.java
View File

@ -199,7 +199,7 @@ public final class ContentDisposition {
sb.append(this.name).append('\"'); sb.append(this.name).append('\"');
} }
if (this.filename != null) { if (this.filename != null) {
if(this.charset == null || StandardCharsets.US_ASCII.equals(this.charset)) { if (this.charset == null || StandardCharsets.US_ASCII.equals(this.charset)) {
sb.append("; filename=\""); sb.append("; filename=\"");
sb.append(this.filename).append('\"'); sb.append(this.filename).append('\"');
} }

11
spring-webflux/src/main/java/org/springframework/web/reactive/resource/GzipResourceResolver.java
View File

@ -40,7 +40,7 @@ import org.springframework.web.server.ServerWebExchange;
* *
* @author Rossen Stoyanchev * @author Rossen Stoyanchev
* @since 5.0 * @since 5.0
* @deprecated as of 5.1 in favor of using {@link EncodedResourceResolver}. * @deprecated as of 5.1, in favor of using {@link EncodedResourceResolver}
*/ */
@Deprecated @Deprecated
public class GzipResourceResolver extends AbstractResourceResolver { public class GzipResourceResolver extends AbstractResourceResolver {
@ -161,13 +161,8 @@ public class GzipResourceResolver extends AbstractResourceResolver {
@Override @Override
public HttpHeaders getResponseHeaders() { public HttpHeaders getResponseHeaders() {
HttpHeaders headers; HttpHeaders headers = (this.original instanceof HttpResource ?
if(this.original instanceof HttpResource) { ((HttpResource) this.original).getResponseHeaders() : new HttpHeaders());
headers = ((HttpResource) this.original).getResponseHeaders();
}
else {
headers = new HttpHeaders();
}
headers.add(HttpHeaders.CONTENT_ENCODING, "gzip"); headers.add(HttpHeaders.CONTENT_ENCODING, "gzip");
headers.add(HttpHeaders.VARY, HttpHeaders.ACCEPT_ENCODING); headers.add(HttpHeaders.VARY, HttpHeaders.ACCEPT_ENCODING);
return headers; return headers;

9
spring-webflux/src/main/java/org/springframework/web/reactive/resource/VersionResourceResolver.java
View File

@ -314,13 +314,8 @@ public class VersionResourceResolver extends AbstractResourceResolver {
@Override @Override
public HttpHeaders getResponseHeaders() { public HttpHeaders getResponseHeaders() {
HttpHeaders headers; HttpHeaders headers = (this.original instanceof HttpResource ?
if(this.original instanceof HttpResource) { ((HttpResource) this.original).getResponseHeaders() : new HttpHeaders());
headers = ((HttpResource) this.original).getResponseHeaders();
}
else {
headers = new HttpHeaders();
}
headers.setETag("\"" + this.version + "\""); headers.setETag("\"" + this.version + "\"");
return headers; return headers;
} }

3
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ResponseEntityResultHandler.java
View File

@ -153,14 +153,13 @@ public class ResponseEntityResultHandler extends AbstractMessageWriterResultHand
HttpHeaders entityHeaders = httpEntity.getHeaders(); HttpHeaders entityHeaders = httpEntity.getHeaders();
HttpHeaders responseHeaders = exchange.getResponse().getHeaders(); HttpHeaders responseHeaders = exchange.getResponse().getHeaders();
if (!entityHeaders.isEmpty()) { if (!entityHeaders.isEmpty()) {
entityHeaders.entrySet().stream() entityHeaders.entrySet().stream()
.filter(entry -> !responseHeaders.containsKey(entry.getKey())) .filter(entry -> !responseHeaders.containsKey(entry.getKey()))
.forEach(entry -> responseHeaders.put(entry.getKey(), entry.getValue())); .forEach(entry -> responseHeaders.put(entry.getKey(), entry.getValue()));
} }
if(httpEntity.getBody() == null || returnValue instanceof HttpHeaders) { if (httpEntity.getBody() == null || returnValue instanceof HttpHeaders) {
return exchange.getResponse().setComplete(); return exchange.getResponse().setComplete();
} }

11
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/GzipResourceResolver.java
View File

@ -40,7 +40,7 @@ import org.springframework.lang.Nullable;
* @author Rossen Stoyanchev * @author Rossen Stoyanchev
* @author Sam Brannen * @author Sam Brannen
* @since 4.1 * @since 4.1
* @deprecated as of 5.1 in favor of using {@link EncodedResourceResolver}. * @deprecated as of 5.1, in favor of using {@link EncodedResourceResolver}
*/ */
@Deprecated @Deprecated
public class GzipResourceResolver extends AbstractResourceResolver { public class GzipResourceResolver extends AbstractResourceResolver {
@ -162,13 +162,8 @@ public class GzipResourceResolver extends AbstractResourceResolver {
@Override @Override
public HttpHeaders getResponseHeaders() { public HttpHeaders getResponseHeaders() {
HttpHeaders headers; HttpHeaders headers = (this.original instanceof HttpResource ?
if (this.original instanceof HttpResource) { ((HttpResource) this.original).getResponseHeaders() : new HttpHeaders());
headers = ((HttpResource) this.original).getResponseHeaders();
}
else {
headers = new HttpHeaders();
}
headers.add(HttpHeaders.CONTENT_ENCODING, "gzip"); headers.add(HttpHeaders.CONTENT_ENCODING, "gzip");
headers.add(HttpHeaders.VARY, HttpHeaders.ACCEPT_ENCODING); headers.add(HttpHeaders.VARY, HttpHeaders.ACCEPT_ENCODING);
return headers; return headers;

9
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/VersionResourceResolver.java
View File

@ -310,13 +310,8 @@ public class VersionResourceResolver extends AbstractResourceResolver {
@Override @Override
public HttpHeaders getResponseHeaders() { public HttpHeaders getResponseHeaders() {
HttpHeaders headers; HttpHeaders headers = (this.original instanceof HttpResource ?
if (this.original instanceof HttpResource) { ((HttpResource) this.original).getResponseHeaders() : new HttpHeaders());
headers = ((HttpResource) this.original).getResponseHeaders();
}
else {
headers = new HttpHeaders();
}
headers.setETag("\"" + this.version + "\""); headers.setETag("\"" + this.version + "\"");
return headers; return headers;
} }