root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Increase randomness in SocketUtils

This commit is contained in:
Sam Brannen 2015-08-15 23:48:20 +02:00
parent 1d3da12204
commit d5944c4e39
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
spring-core/src/main/java/org/springframework/util/SocketUtils.java
View File

@ -19,7 +19,7 @@ package org.springframework.util;
import java.net.DatagramSocket; import java.net.DatagramSocket;
import java.net.InetAddress; import java.net.InetAddress;
import java.net.ServerSocket; import java.net.ServerSocket;
import java.util.Random; import java.security.SecureRandom;
import java.util.SortedSet; import java.util.SortedSet;
import java.util.TreeSet; import java.util.TreeSet;
import javax.net.ServerSocketFactory; import javax.net.ServerSocketFactory;
@ -53,9 +53,6 @@ public class SocketUtils {
public static final int PORT_RANGE_MAX = 65535; public static final int PORT_RANGE_MAX = 65535;
private static final Random random = new Random(System.currentTimeMillis());
/** /**
* Although {@code SocketUtils} consists solely of static utility methods, * Although {@code SocketUtils} consists solely of static utility methods,
* this constructor is intentionally {@code public}. * this constructor is intentionally {@code public}.
@ -238,7 +235,7 @@ public class SocketUtils {
*/ */
private int findRandomPort(int minPort, int maxPort) { private int findRandomPort(int minPort, int maxPort) {
int portRange = maxPort - minPort; int portRange = maxPort - minPort;
return minPort + random.nextInt(portRange); return minPort + new SecureRandom().nextInt(portRange);
} }
/** /**