From d08ce303f12042555ef34af70b53f8d7681711aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=A1=D0=B5=D1=80=D0=B3=D0=B5=D0=B9=20=D0=A6=D1=8B=D0=BF?= =?UTF-8?q?=D0=B0=D0=BD=D0=BE=D0=B2?= Date: Sat, 27 Jun 2020 14:50:50 +0300 Subject: [PATCH] Extract Class.getName() from String concatenation This commit extracts a Class.getName() invocation from String concatenation in AbstractMonitoringInterceptor to avoid an issue related to profile pollution. Closes gh-25324 --- .../aop/interceptor/AbstractMonitoringInterceptor.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spring-aop/src/main/java/org/springframework/aop/interceptor/AbstractMonitoringInterceptor.java b/spring-aop/src/main/java/org/springframework/aop/interceptor/AbstractMonitoringInterceptor.java index 494de786e5..9ebe3a9dc1 100644 --- a/spring-aop/src/main/java/org/springframework/aop/interceptor/AbstractMonitoringInterceptor.java +++ b/spring-aop/src/main/java/org/springframework/aop/interceptor/AbstractMonitoringInterceptor.java @@ -103,7 +103,8 @@ public abstract class AbstractMonitoringInterceptor extends AbstractTraceInterce if (this.logTargetClassInvocation && clazz.isInstance(invocation.getThis())) { clazz = invocation.getThis().getClass(); } - return getPrefix() + clazz.getName() + '.' + method.getName() + getSuffix(); + String clazzName = clazz.getName(); + return getPrefix() + clazzName + '.' + method.getName() + getSuffix(); } }