root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Performance improvement 

Use entrySet instead of keySet followed by a lookup per key as the
former is more efficient.

Issue: SPR-12363
This commit is contained in:
Sang Gi Ryu 2014-10-23 13:27:50 +09:00 committed by Stephane Nicoll
parent d9df50c6cd
commit d62522982f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
spring-context/src/main/java/org/springframework/ui/ModelMap.java
View File

@ -127,9 +127,10 @@ public class ModelMap extends LinkedHashMap<String, Object> {
*/ */
public ModelMap mergeAttributes(Map<String, ?> attributes) { public ModelMap mergeAttributes(Map<String, ?> attributes) {
if (attributes != null) { if (attributes != null) {
for (String key : attributes.keySet()) { for (Map.Entry<String, ?> entry : attributes.entrySet()) {
String key = entry.getKey();
if (!containsKey(key)) { if (!containsKey(key)) {
put(key, attributes.get(key)); put(key, entry.getValue());
} }
} }
} }