root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

No log level check unless String concatenation is following

This commit is contained in:
Juergen Hoeller 2020-03-14 00:01:13 +01:00
parent 6599383dac
commit d91fc8c672
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2019 the original author or authors. * Copyright 2002-2020 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -254,7 +254,7 @@ public class ProxyFactoryBean extends ProxyCreatorSupport
return getSingletonInstance(); return getSingletonInstance();
} }
else { else {
if (this.targetName == null && logger.isInfoEnabled()) { if (this.targetName == null) {
logger.info("Using non-singleton proxies with singleton targets is often undesirable. " + logger.info("Using non-singleton proxies with singleton targets is often undesirable. " +
"Enable prototype proxies by setting the 'targetName' property."); "Enable prototype proxies by setting the 'targetName' property.");
} }
@ -600,8 +600,8 @@ public class ProxyFactoryBean extends ProxyCreatorSupport
// We expected this to be an Advisor or Advice, // We expected this to be an Advisor or Advice,
// but it wasn't. This is a configuration error. // but it wasn't. This is a configuration error.
throw new AopConfigException("Unknown advisor type " + next.getClass() + throw new AopConfigException("Unknown advisor type " + next.getClass() +
"; Can only include Advisor or Advice type beans in interceptorNames chain except for last entry, " + "; can only include Advisor or Advice type beans in interceptorNames chain " +
"which may also be target or TargetSource", ex); "except for last entry which may also be target instance or TargetSource", ex);
} }
} }