diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanDefinition.java b/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanDefinition.java
index 4a10cdb1555..4fa941961a5 100644
--- a/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanDefinition.java
+++ b/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanDefinition.java
@@ -179,8 +179,7 @@ public abstract class AbstractBeanDefinition extends BeanMetadataAttributeAccess
@Nullable
private MutablePropertyValues propertyValues;
- @Nullable
- private MethodOverrides methodOverrides;
+ private MethodOverrides methodOverrides = new MethodOverrides();
@Nullable
private String initMethodName;
@@ -869,9 +868,6 @@ public abstract class AbstractBeanDefinition extends BeanMetadataAttributeAccess
*
Never returns {@code null}.
*/
public MethodOverrides getMethodOverrides() {
- if (this.methodOverrides == null) {
- this.methodOverrides = new MethodOverrides();
- }
return this.methodOverrides;
}
@@ -880,7 +876,7 @@ public abstract class AbstractBeanDefinition extends BeanMetadataAttributeAccess
* @since 5.0.2
*/
public boolean hasMethodOverrides() {
- return (this.methodOverrides != null && !this.methodOverrides.isEmpty());
+ return !this.methodOverrides.isEmpty();
}
/**
@@ -1064,10 +1060,9 @@ public abstract class AbstractBeanDefinition extends BeanMetadataAttributeAccess
public void validate() throws BeanDefinitionValidationException {
if (hasMethodOverrides() && getFactoryMethodName() != null) {
throw new BeanDefinitionValidationException(
- "Cannot combine static factory method with method overrides: " +
- "the static factory method must create the instance");
+ "Cannot combine factory method with container-generated method overrides: " +
+ "the factory method must create the concrete bean instance.");
}
-
if (hasBeanClass()) {
prepareMethodOverrides();
}
@@ -1079,14 +1074,9 @@ public abstract class AbstractBeanDefinition extends BeanMetadataAttributeAccess
* @throws BeanDefinitionValidationException in case of validation failure
*/
public void prepareMethodOverrides() throws BeanDefinitionValidationException {
- // Check that lookup methods exists.
+ // Check that lookup methods exist and determine their overloaded status.
if (hasMethodOverrides()) {
- Set overrides = getMethodOverrides().getOverrides();
- synchronized (overrides) {
- for (MethodOverride mo : overrides) {
- prepareMethodOverride(mo);
- }
- }
+ getMethodOverrides().getOverrides().forEach(this::prepareMethodOverride);
}
}
diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/support/MethodOverrides.java b/spring-beans/src/main/java/org/springframework/beans/factory/support/MethodOverrides.java
index 50f507aaec4..937f3c0e039 100644
--- a/spring-beans/src/main/java/org/springframework/beans/factory/support/MethodOverrides.java
+++ b/spring-beans/src/main/java/org/springframework/beans/factory/support/MethodOverrides.java
@@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,9 +17,8 @@
package org.springframework.beans.factory.support;
import java.lang.reflect.Method;
-import java.util.Collections;
-import java.util.LinkedHashSet;
import java.util.Set;
+import java.util.concurrent.CopyOnWriteArraySet;
import org.springframework.lang.Nullable;
@@ -37,9 +36,7 @@ import org.springframework.lang.Nullable;
*/
public class MethodOverrides {
- private final Set overrides = Collections.synchronizedSet(new LinkedHashSet<>(2));
-
- private volatile boolean modified = false;
+ private final Set overrides = new CopyOnWriteArraySet<>();
/**
@@ -61,7 +58,6 @@ public class MethodOverrides {
*/
public void addOverrides(@Nullable MethodOverrides other) {
if (other != null) {
- this.modified = true;
this.overrides.addAll(other.overrides);
}
}
@@ -70,7 +66,6 @@ public class MethodOverrides {
* Add the given method override.
*/
public void addOverride(MethodOverride override) {
- this.modified = true;
this.overrides.add(override);
}
@@ -80,7 +75,6 @@ public class MethodOverrides {
* @see MethodOverride
*/
public Set getOverrides() {
- this.modified = true;
return this.overrides;
}
@@ -88,7 +82,7 @@ public class MethodOverrides {
* Return whether the set of method overrides is empty.
*/
public boolean isEmpty() {
- return (!this.modified || this.overrides.isEmpty());
+ return this.overrides.isEmpty();
}
/**
@@ -98,18 +92,13 @@ public class MethodOverrides {
*/
@Nullable
public MethodOverride getOverride(Method method) {
- if (!this.modified) {
- return null;
- }
- synchronized (this.overrides) {
- MethodOverride match = null;
- for (MethodOverride candidate : this.overrides) {
- if (candidate.matches(method)) {
- match = candidate;
- }
+ MethodOverride match = null;
+ for (MethodOverride candidate : this.overrides) {
+ if (candidate.matches(method)) {
+ match = candidate;
}
- return match;
}
+ return match;
}
@@ -123,7 +112,6 @@ public class MethodOverrides {
}
MethodOverrides that = (MethodOverrides) other;
return this.overrides.equals(that.overrides);
-
}
@Override