root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

SPR-6303 - Add more logging to RestTemplate

This commit is contained in:
Arjen Poutsma 2009-11-05 13:32:14 +00:00
parent f1075c7b04
commit db252cd0af
1 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
org.springframework.web/src/main/java/org/springframework/web/client/RestTemplate.java
View File

@ -382,8 +382,11 @@ public class RestTemplate extends HttpAccessor implements RestOperations {
requestCallback.doWithRequest(request); requestCallback.doWithRequest(request);
} }
response = request.execute(); response = request.execute();
if (getErrorHandler().hasError(response)) { if (!getErrorHandler().hasError(response)) {
getErrorHandler().handleError(response); logResponseStatus(method, url, response);
}
else {
handleResponseError(method, url, response);
} }
if (responseExtractor != null) { if (responseExtractor != null) {
return responseExtractor.extractData(response); return responseExtractor.extractData(response);
@ -419,6 +422,31 @@ public class RestTemplate extends HttpAccessor implements RestOperations {
throw new IllegalArgumentException("Could not resolve HttpMessageConverter for [" + type.getName() + "]"); throw new IllegalArgumentException("Could not resolve HttpMessageConverter for [" + type.getName() + "]");
} }
private void logResponseStatus(HttpMethod method, URI url, ClientHttpResponse response) {
if (logger.isDebugEnabled()) {
try {
logger.debug(method.name() + " request for \"" + url + "\" resulted in " + response.getStatusCode() +
" (" + response.getStatusText() + ")");
}
catch (IOException e) {
// ignore
}
}
}
private void handleResponseError(HttpMethod method, URI url, ClientHttpResponse response) throws IOException {
if (logger.isWarnEnabled()) {
try {
logger.warn(method.name() + " request for \"" + url + "\" resulted in " + response.getStatusCode() +
" (" + response.getStatusText() + "); invoking error handler");
}
catch (IOException e) {
// ignore
}
}
getErrorHandler().handleError(response);
}
/** Request callback implementation that prepares the request's accept headers. */ /** Request callback implementation that prepares the request's accept headers. */
private class AcceptHeaderRequestCallback<T> implements RequestCallback { private class AcceptHeaderRequestCallback<T> implements RequestCallback {