root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Fix deadlock issue in DeferredResult 

Previously DeferredResult locked around the setting of the result
including handling up to the part of submitting a dispatch. This
can cause a deadlock if a timeout occurs at the same time since
the Tomcat timeout thread has its own locking that permits only
one thread to do timeout or dispatch processing.

The fix reduces the locking to cover only the attempt to set the
DeferredResult but not the dispatching.

Issue: SPR-10485
This commit is contained in:
Rossen Stoyanchev 2013-05-14 17:01:46 -04:00
parent 6825aaf41f
commit db596d23de
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java
View File

@ -173,9 +173,9 @@ public class DeferredResult<T> {
return false;
}
this.result = result;
if (this.resultHandler != null) {
this.resultHandler.handleResult(this.result);
}
}
if (this.resultHandler != null) {
this.resultHandler.handleResult(this.result);
}
return true;
}