From dbe8f200a919635f44dcd2917eabb5e6b216ed77 Mon Sep 17 00:00:00 2001 From: Vedran Pavic Date: Fri, 17 Jun 2022 16:25:23 +0200 Subject: [PATCH] Simplify creation of LoggingCacheErrorHandler with logged stacktrace At present, creating a LoggingCacheErrorHandler that logs stack traces also requires supplying the logger to be used. This might be inconvenient for some users, as it requires usage of the Commons Logging API. This commit simplifies creation of such as LoggingCacheErrorHandler instance by adding a constructor that only accepts a boolean flag indicating whether to log stack traces. Closes gh-28670 --- .../cache/interceptor/LoggingCacheErrorHandler.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/spring-context/src/main/java/org/springframework/cache/interceptor/LoggingCacheErrorHandler.java b/spring-context/src/main/java/org/springframework/cache/interceptor/LoggingCacheErrorHandler.java index e2f6c33127d..681a59b2c80 100644 --- a/spring-context/src/main/java/org/springframework/cache/interceptor/LoggingCacheErrorHandler.java +++ b/spring-context/src/main/java/org/springframework/cache/interceptor/LoggingCacheErrorHandler.java @@ -29,6 +29,7 @@ import org.springframework.util.Assert; * * @author Adam Ostrožlík * @author Stephane Nicoll + * @author Vedran Pavic * @since 5.3.16 */ public class LoggingCacheErrorHandler implements CacheErrorHandler { @@ -49,11 +50,19 @@ public class LoggingCacheErrorHandler implements CacheErrorHandler { this.logStacktrace = logStacktrace; } + /** + * Create an instance. + * @param logStacktrace whether to log stacktrace + */ + public LoggingCacheErrorHandler(boolean logStacktrace) { + this(LogFactory.getLog(LoggingCacheErrorHandler.class), logStacktrace); + } + /** * Create an instance that does not log stack traces. */ public LoggingCacheErrorHandler() { - this(LogFactory.getLog(LoggingCacheErrorHandler.class), false); + this(false); }