root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Defer cleanup in DefaultServerWebExchange 

This commit ensures that the multipartRead flag is read in a deferred
block, and is not evaluated too early.

Closes gh-31567
This commit is contained in:
Arjen Poutsma 2023-10-25 10:38:37 +02:00
parent 7f94c64b72
commit dc26d3b0ec
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spring-web/src/main/java/org/springframework/web/server/adapter/DefaultServerWebExchange.java
View File

@ -247,18 +247,20 @@ public class DefaultServerWebExchange implements ServerWebExchange {
@Override @Override
public Mono<Void> cleanupMultipart() { public Mono<Void> cleanupMultipart() {
return Mono.defer(() -> {
if (this.multipartRead) { if (this.multipartRead) {
return getMultipartData() return getMultipartData()
.onErrorResume(t -> Mono.empty()) // ignore errors reading multipart data .onErrorComplete()
.flatMapIterable(Map::values) .flatMapIterable(Map::values)
.flatMapIterable(Function.identity()) .flatMapIterable(Function.identity())
.flatMap(part -> part.delete() .flatMap(part -> part.delete()
.onErrorResume(ex -> Mono.empty())) .onErrorComplete())
.then(); .then();
} }
else { else {
return Mono.empty(); return Mono.empty();
} }
});
} }
@Override @Override