root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 8 Packages Projects Releases Wiki Activity

MimeTypeUtils trims parameter names / values 

Issue: SPR-16630
This commit is contained in:
Rossen Stoyanchev 2018-03-27 19:19:09 -04:00
parent 4aae6a6dda
commit e00384a6fd
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spring-core/src/main/java/org/springframework/util/MimeTypeUtils.java
View File

@ -225,8 +225,8 @@ public abstract class MimeTypeUtils {
}
int eqIndex = parameter.indexOf('=');
if (eqIndex >= 0) {
String attribute = parameter.substring(0, eqIndex);
String value = parameter.substring(eqIndex + 1, parameter.length());
String attribute = parameter.substring(0, eqIndex).trim();
String value = parameter.substring(eqIndex + 1, parameter.length()).trim();
parameters.put(attribute, value);
}
}

12
spring-core/src/test/java/org/springframework/util/MimeTypeTests.java
View File

@ -247,6 +247,18 @@ public class MimeTypeTests {
assertEquals("'v>alue'", mimeType.getParameter("attr"));
}
@Test // SPR-16630
public void parseMimeTypeWithSpacesAroundEquals() {
MimeType mimeType = MimeTypeUtils.parseMimeType("multipart/x-mixed-replace;boundary = --myboundary");
assertEquals("--myboundary", mimeType.getParameter("boundary"));
}
@Test // SPR-16630
public void parseMimeTypeWithSpacesAroundEqualsAndQuotedValue() {
MimeType mimeType = MimeTypeUtils.parseMimeType("text/plain; foo = \" bar \" ");
assertEquals("\" bar \"", mimeType.getParameter("foo"));
}
@Test(expected = InvalidMimeTypeException.class)
public void parseMimeTypeIllegalQuotedParameterValue() {
MimeTypeUtils.parseMimeType("audio/*;attr=\"");